Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     linux-pci@vger.kernel.org, netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Rob Herring <robh@kernel.org>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Michael Walle <michael@walle.cc>, linux-kernel@vger.kernel.org,
        Jianmin Lv <lvjianmin@loongson.cn>,
        Liu Peibao <liupeibao@loongson.cn>,
        Binbin Zhou <zhoubinbin@loongson.cn>,
        Huacai Chen <chenhuacai@loongson.cn>
Subject: [PATCH v2 pci/net 3/3] net: enetc: remove of_device_is_available() handling
Date:   Thu,  3 Aug 2023 16:58:58 +0300
Message-Id: <20230803135858.2724342-4-vladimir.oltean@nxp.com>
In-Reply-To: <20230803135858.2724342-1-vladimir.oltean@nxp.com>
References: <20230803135858.2724342-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?66WrtLHgvDgYl8FsDdyCOH6jm8LXbV10kDQGpHATKeHQWGMddRSvw4TCNxM/?=
 =?us-ascii?Q?PT78iJstxEhlA1HEY6pN4iX1JMOgWjTnROWlTAm0YIBF1fNWh/Gkvtji8R0I?=
 =?us-ascii?Q?kRbS5r7jfCFC+UbjTX7syXJ7vYVwLJwHWIvdjaSqEGVb8R+IaNV7zOSs5/v8?=
 =?us-ascii?Q?O7l/jCyw1aHt41ZTdosc0n3ZZCnvJaYglTSNNw88u5bwUSI+wtrKgl6GEWIp?=
 =?us-ascii?Q?KSkFYJKVA5Ir+FtbaoUxCeAd4gTOoZBgdnyTrbioNNQJbOBcMUc+fja2bdhn?=
 =?us-ascii?Q?e2T476xaQBobZkMWa/gROkj8uitd+33/+Xnf31TEgc6alTmwPA1se1yVDQg/?=
 =?us-ascii?Q?KwzRmwH5flWHck0hxEHSHmngFewaC0floVgV9bztZ4hRlXjIuY47B0X46qL1?=
 =?us-ascii?Q?9aScnQ9Tj/PvYDzOwES5Z1saRZGyzQI1ah9vxrR0jF012uRqieN+QPMVcWnu?=
 =?us-ascii?Q?fWt97+lDNTnCYrJTRmtTI+j3TpT1p2zi9LlebRs/jFNzp2o9zNpqRrzQ7blr?=
 =?us-ascii?Q?aUGIMfbQJVF+L12FlfZO28n3iZerK7CBZMaLMd7so2LFkwSzphpx4uynSt2U?=
 =?us-ascii?Q?JaLd/aPES/pyzWo5SyTnqAJAWcavoyqJLQLvvTQFGjiG5bXNAumUWfckvU1m?=
 =?us-ascii?Q?FgngchmbmMadtB2f35gEVYue6u+E3BuVAmRZyB9s4DM7t7XVToArJMkOwk4U?=
 =?us-ascii?Q?cXipDT2YgmxJOzdLureLyBon3cIkzvVL9jbd0ijUykLm4eVVIauT2lSGp985?=
 =?us-ascii?Q?zzNcWl/P+wV37pt0KDM8q+DyUA7ebgoNogN6u0hSEUSJgQGYZO3/maInvFKW?=
 =?us-ascii?Q?dmti46e5pAzUbBDA9B9aT7dfdKw15hkA/qBIRvZOGPxoMnh+4dU0j8A1XjGY?=
 =?us-ascii?Q?3nJWo/kz3u4Uy5KMETxJJnfgfut5GTWQrCLnu1RFl/N6jP8os7hGiLdU+dOk?=
 =?us-ascii?Q?EE3d+D4Xcqr6s36kkx9GowPux4WaYHMLSyMerbrnJ8cD+mZnwv6ntTj4OLV+?=
 =?us-ascii?Q?KsCRdOHbNVWwPLFLxt2BTc2Fq+PD+ZMzezMkdw1joYpqJryzcK90DzHyJv+5?=
 =?us-ascii?Q?/5Yc59+r6CK/AObyC0iW9Zd9BMrwlwS3Uk7gGTGDy+Arh0Ny6AxsenfjLW8Z?=
 =?us-ascii?Q?wlej0hy5qbu3fygzAjbRxFSm6YVsUohXmKM1DItESeBtj7tTMbc89LH9UtSY?=
 =?us-ascii?Q?XB0DItP/JoRN70UeqXN6/f0PH1oOHi1lTzm7en1rCPL7VSDbVsIVj3kUyM+l?=
 =?us-ascii?Q?ZLIGfBrLblAbO54O4hqRd+V7VOt7sqcilwR1Z5E1fwW3OjtNZIUkWKaLaYrQ?=
 =?us-ascii?Q?28rb8r5uB9PJQOiXte84o+eqmgTieGSXOld6ytIdMprdgwr2VxT9ujr3JOul?=
 =?us-ascii?Q?2JfOLrGuS/fWb8Z3OlQ7or1wZWSphtSlUilvrPXn8/zzLq85/JAKaJggEbmJ?=
 =?us-ascii?Q?3yxyxz9dwkEYTRH9JFh2doSeUMd4RFVAauwuTFYZF05rSGtCOC+69csNP2hl?=
 =?us-ascii?Q?mJ5cZhVpXCYICn8Qgot8Hv3+R/NXC5i3C1EA30MLFMFpXUphXqS6osehyzlR?=
 =?us-ascii?Q?ZF4UKtw9opdTl3Lq1WxMImUChDgsZvltsbJlr0W1neaCYa2fYCFEX5uiVIjk?=
 =?us-ascii?Q?zQ=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0fd3422b-6c3f-4459-1224-08db9429d15b
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 13:59:13.1486
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FFErHsG56drzKdhguREF9y+a8gY4JqFFcJf72gRqN6sNPNbNy656yhEAxxMSerHwX9TxP6jaHMcwI6cmjDV2ug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8799
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Since commit 6fffbc7ae137 ("PCI: Honor firmware's device disabled
status"), this is redundant and does nothing, because enetc_pf_probe()
no longer even gets called.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/ethernet/freescale/enetc/enetc_pf.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/drivers/net/ethernet/freescale/enetc/enetc_pf.c b/drivers/net/ethernet/freescale/enetc/enetc_pf.c
index d52ac0b6add6..e0a4cb7e3f50 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_pf.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_pf.c
@@ -1186,14 +1186,9 @@ static int enetc_init_port_rss_memory(struct enetc_si *si)
 
 static int enetc_pf_register_with_ierb(struct pci_dev *pdev)
 {
-	struct device_node *node = pdev->dev.of_node;
 	struct platform_device *ierb_pdev;
 	struct device_node *ierb_node;
 
-	/* Don't register with the IERB if the PF itself is disabled */
-	if (!node || !of_device_is_available(node))
-		return 0;
-
 	ierb_node = of_find_compatible_node(NULL, NULL,
 					    "fsl,ls1028a-enetc-ierb");
 	if (!ierb_node || !of_device_is_available(ierb_node))
@@ -1285,12 +1280,6 @@ static int enetc_pf_probe(struct pci_dev *pdev,
 		goto err_psi_create;
 	}
 
-	if (node && !of_device_is_available(node)) {
-		dev_info(&pdev->dev, "device is disabled, skipping\n");
-		err = -ENODEV;
-		goto err_device_disabled;
-	}
-
 	pf = enetc_si_priv(si);
 	pf->si = si;
 	pf->total_vfs = pci_sriov_get_totalvfs(pdev);
@@ -1370,7 +1359,6 @@ static int enetc_pf_probe(struct pci_dev *pdev,
 	si->ndev = NULL;
 	free_netdev(ndev);
 err_alloc_netdev:
-err_device_disabled:
 err_setup_mac_addresses:
 	enetc_psi_destroy(pdev);
 err_psi_create:
-- 
2.34.1