Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 3 Aug 2023 17:45:48 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>, linux-kernel@vger.kernel.org,
        intel-wired-lan@lists.osuosl.org,
        Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>,
        Peilin Ye <yepeilin.cs@gmail.com>,
        Pedro Tammela <pctammela@mojatatu.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Zhengchao Shao <shaozhengchao@huawei.com>,
        Maxim Georgiev <glipus@gmail.com>
Subject: Re: [PATCH v3 net-next 06/10] net: ptp: create a mock-up PTP
 Hardware Clock driver
Message-ID: <20230803144548.qfis7z4eoaz5h6oy@skbuf>
References: <20230801182421.1997560-1-vladimir.oltean@nxp.com>
 <20230801182421.1997560-7-vladimir.oltean@nxp.com>
 <87wmyd14zj.fsf@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87wmyd14zj.fsf@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Sk7dNCOXXeGTal9FedLFDDKCAUk+hCvr+/PcgnmD1K38YeG/Vp/jnLCo9dGL?=
 =?us-ascii?Q?0sCBQiHx1sI+Z9XaNDq2eGVk8NxTw2D4fWMaNWpNmoI+NMS0pZcoc8zoH0Nt?=
 =?us-ascii?Q?qMUZT2huvBvf+VoEkbEeBmqlrh1dwXE0IVZrVPn/fa+RsgZU5LZUKESboJro?=
 =?us-ascii?Q?mQ0HCuloMNBffjC0a2/Rqep2dEjmX6oRPqka8THl5lOxCxjHTNAJNJ26sMic?=
 =?us-ascii?Q?yUbXWvB/xGbPFa7JNq+PGpM+5rzDRzs8tajiyRJS9qJq5CC86/PTslg6ubSc?=
 =?us-ascii?Q?p65RI9M0Kl/rW47P6XpZ5bKp3buicMDdMnGu+NN2uDVULEjIWkg+nrQrAt2i?=
 =?us-ascii?Q?NtayjiyPUnWsC4A+dEw2Lt6kCxXc9UKjp/aIrMPH2gY7pIglRal0ZtbuhzfS?=
 =?us-ascii?Q?/VXEK0U8YDpOqA75NniL/HtUuVqR/L902sxOikX9ONQeO5CqcY3N8yCfXnzV?=
 =?us-ascii?Q?fPflNIW6JGl/9+W0V3JUauh1i4XiBPaHcZpP/ah1F1UL//XBVCruir3zf99+?=
 =?us-ascii?Q?QO7eFrI7hMYA9CWqNsTduMFYhKpt07hGD5cI3Nyxi1VnwFJwaWpCHwplHduc?=
 =?us-ascii?Q?44c7ON2F50rtDor+zD1Jb3tsDHrLI6yAALksUFw4YbaUkmpx85Id9fKBU9sb?=
 =?us-ascii?Q?WGDTFktv5hL/PDdV1P7dMN+KgHR850ynm9s20RRTvlK2s2eouv26D3W/zEVV?=
 =?us-ascii?Q?JFQbQ5MdS1gYCNLLG48mNSsxebRoT/JYT0mkrjXF1qsBbPPoIW0OhKOpKZx1?=
 =?us-ascii?Q?cjeu2Rw1zG7TellTW3eu7Wc7v6U2rZzBoqhkWns2BlhaNcrZMbN84Yg12mMq?=
 =?us-ascii?Q?Ih+q1/InvhTdMKECKd+PUTylhLchpRSMeqpzW1DWrG5IROFPw87QGuCzaluB?=
 =?us-ascii?Q?gE8S0CCf97vmQnyAemwxx/kHjvyhpun62IUAFD1tbh3XaUzmnOd+bNKSD0CU?=
 =?us-ascii?Q?YmervLGPzf033TIEueuYh5FmpyDRPF8RxhP5seHic1fbE6v4KpEgCHQQcC/l?=
 =?us-ascii?Q?6C2ErEdAxA3gB3Ur5jV1vaUwD3SoN7PVyVTyRE0gJgC/4IqpOPAdWKECCz+h?=
 =?us-ascii?Q?zJSNtpRuFAqO40iXSMA59CKDjuvVuHyclHD4bzYvGFlE6zMk/bbRO+/uYxi+?=
 =?us-ascii?Q?98Ta983sov0TcMemuIZKvdGO8cNcrbsf6S8bjGJscgpZ/X25gWFXDT6kcT6V?=
 =?us-ascii?Q?k5w70KFpoF+iWXfAed97onWbQ1crSSmCrBLYZ9EJq3wvO5A37poBOrnHJlNA?=
 =?us-ascii?Q?/pV90KiwvuZr7UKuko+9ZF5JMnW25n5Zxur7tCiorT8gN/Xz/itNmXIYikco?=
 =?us-ascii?Q?w9zFAPYynsCS06CvfS8o0LsNZvxZ+cOZv8jnITc6L0OAf4apEHv30QTugIun?=
 =?us-ascii?Q?qtSWweWHauWxAcvsOgIOq8DsNrn8tWifQjNRl+dopsrlM/CcnvsR3/irL7/I?=
 =?us-ascii?Q?jprIk0SEbRdc+Xf8V5s1qkTBP/xZPNaSyu/PGWto/NwBSYkUz/fmfQILv1CC?=
 =?us-ascii?Q?5tTm/PEXNjq6UUmEOG1xzHBhRNLxO87wuw/YHSmNMMWQnEPDLIBiBZE+KplB?=
 =?us-ascii?Q?3SDU+vN2qWhrsJ14P0PHGWhYGkZ/9ygRN0yYorYH9SoBgeIFRwiSwDlJLAmn?=
 =?us-ascii?Q?fg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e214c2d9-0ded-46fe-3ba0-08db94305584
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 14:45:51.8627
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C5bvKKSscDPKnXW0ciF1rFPhJk9pU4tXI8BbEPcrKqPbnMKOHzpQTebqUscxnI6PqbPRc4mHcld9KAwZfmT2qw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7858
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 02, 2023 at 02:58:24PM -0700, Vinicius Costa Gomes wrote:
> > +static DEFINE_SPINLOCK(mock_phc_lock);
> > +
> 
> Not a big deal, but as it is possible to have multiple netdevsim
> instances (is it?), I think it's better to move the lock inside struct
> mock_phc.

Ok. I'll respin with this and Kurt's comments addressed. I'll wait for a
little bit longer, in case there are more change requests.