Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0FF79B770AD31251+44408a50-d082-f3db-a60b-59ed0cb75e42@biqu3d.com>
Date:   Thu, 3 Aug 2023 17:50:42 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v1 5/6] arm64: dts: allwinner: h616: Add BigTreeTech CB1
 SoM & boards support
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Konrad Dybcio <konrad.dybcio@somainline.org>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@somainline.org>,
        Marijn Suijten <marijn.suijten@somainline.org>,
        Jami Kettunen <jamipkettunen@somainline.org>,
        Paul Bouchara <paul.bouchara@somainline.org>,
        Martin Botka <martin.botka@somainline.org>,
        Andre Przywara <andre.przywara@arm.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        Icenowy Zheng <uwu@icenowy.me>,
        Ludwig Kormann <ludwig.kormann@ict42.de>,
        Andrew Lunn <andrew@lunn.ch>, Heiko Stuebner <heiko@sntech.de>,
        Shawn Guo <shawnguo@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Chris Morgan <macromorgan@hotmail.com>,
        Jagan Teki <jagan@edgeble.ai>,
        Maxime Ripard <mripard@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
        linux-kernel@vger.kernel.org
References: <20230802220309.163804-1-martin@biqu3d.com>
 <85E425AED000D34C+20230802220309.163804-6-martin@biqu3d.com>
 <9f1210b8-1726-a7a3-622b-8fef778cba3e@linaro.org>
From:   Martin Botka <martin@biqu3d.com>
In-Reply-To: <9f1210b8-1726-a7a3-622b-8fef778cba3e@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Feedback-ID: bizesmtp:biqu3d.com:qybglogicsvrgz:qybglogicsvrgz5a-1
Precedence: bulk


On 8/3/23 4:28 PM, Krzysztof Kozlowski wrote:
> On 03/08/2023 00:02, Martin Botka wrote:
>> From: Martin Botka <martin.botka@somainline.org>
>>
>> CB1 is Compute Module style board that plugs into Rpi board style adapter or
>> Manta 3D printer boards (M4P/M8P).
>>
>> The SoM features:
>>    - H616 SoC
>>    - 1GiB of RAM
>>    - AXP313A PMIC
>>    - RTL8189FTV WiFi
> 
> ...
> 
>> +&mmc0 {
>> +	vmmc-supply = <&reg_dldo1>;
>> +	broken-cd;
>> +	bus-width = <4>;
>> +	status = "okay";
>> +};
>> +
>> +&mmc1 {
>> +	vmmc-supply = <&reg_vcc33_wifi>;
>> +	vqmmc-supply = <&reg_vcc_wifi_io>;
>> +	mmc-pwrseq = <&wifi_pwrseq>;
>> +	bus-width = <4>;
>> +	non-removable;
>> +	mmc-ddr-1_8v;
>> +	status = "okay";
>> +
>> +	rtl8189ftv: sdio_wifi@1 {
> 
> No underxcores in node names. Generic node names, so probably "wifi".
Got it.
> 
>> +		reg = <1>;
> 
> Missing compatible?
No it is an explicitly defined SDIO device so we can add ethernet alias 
for it so we can for example set the MAC address of it via u-boot and etc :)

The actual driver for it is out of tree and from the current state of it 
looks like will be for a while.
Orange Pi Zero Plus based on H5 does this exact thing as well for the 
same purpose with the same wifi chip :)

Cheers,
Martin
> 
> 
> 
> Best regards,
> Krzysztof
> 
>