Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp2476803rwo; Thu, 3 Aug 2023 09:55:06 -0700 (PDT) X-Google-Smtp-Source: APBJJlGKakY3GCUHrHORDsvT0pEf7EpiNxfFlnVlLQ60mflwVDB6umLx3Xzr7MBD3CrGhOaHu4ZC X-Received: by 2002:a05:6808:21aa:b0:3a3:dc0e:4d0f with SMTP id be42-20020a05680821aa00b003a3dc0e4d0fmr24562052oib.22.1691081706117; Thu, 03 Aug 2023 09:55:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691081706; cv=none; d=google.com; s=arc-20160816; b=qYtDXm/aR5FiQJWzMq0hWLuTQauL+OmBBwaQXDL61n1vXC7c1tfB9xcROYtIoET8Cz 7edxqF6aJqilhHsFZVtVL2jpt8PW0PLL+/14MAWUgz13lN0WBMql5tPVKsLNIA4uOomy ALasIXlaJIvPH66eKZw/olBClAK8aj8UrhdwDJfMcVwM6B0nvvkhWXTq6O0/pJRKDRRl a7lu/mg6j9vrlETlt7k0idHYSw9NEbQyaVIF83wGI7nA+PHBsz+dvWlc1CFnFDDCmDqt +lxxM6Im6VzQEP3GFQAyP8XV2R9UzcXy+O8F1+aS1s/WrPtaajgXNRUOU+H8S7NZu3td HxnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=MjNI8GF8OoVGghW2eOUsJd2BPsvL24ktQWlO9377+CE=; fh=35U6N7KGyYiRO1gaY5NuAwb5hP3jOMlOPrkLwRF/R98=; b=FpNo915IZdCWuPCckdQvQg/e5B7fTs6zIwdQYwGRCGOD+PLs+m2jzbgDcs20E9XkOa tO7LcZsaT8MFfvxT5fKzbJOBGlFVzpvSS2nd350xzXla7+ODphpya5SgPRwb6NexQequ F/ihotRB34zfgmxfLZjStK938qwBruJDjPtobEgAuEOF/FFaJFDDCDi9f/O9Jq+7vWC3 OPDmnOuML3t00Ub0uPFz+Q7H4IMDL19uZqdcgD+Al4AIN9hxw3XcejsW3sAKpgEW0ywo +36R84U90CBrZa2uQXfyfKSV7nb3STyfnbKELpEwH6mMuQ4fqxAnduzbkAVRylhXmZ2A yAOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="dv9/S6UC"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b24-20020a631b58000000b00563dbab36e1si156301pgm.645.2023.08.03.09.54.52; Thu, 03 Aug 2023 09:55:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="dv9/S6UC"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237007AbjHCQfj (ORCPT + 99 others); Thu, 3 Aug 2023 12:35:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237177AbjHCQfW (ORCPT ); Thu, 3 Aug 2023 12:35:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67CA930D2; Thu, 3 Aug 2023 09:35:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EC5FC61E37; Thu, 3 Aug 2023 16:35:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6BF9C433CC; Thu, 3 Aug 2023 16:35:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691080517; bh=ZTZgeCCqcCk5qt3bqo0mNlPdVNRWhr4NJIvWHGkwC7Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dv9/S6UCgzugrr5kPIj6znHz+y8Os2gQPoLd8ZeUNNwQghH91gAp+49PEiQkUrh/V RLu4q35WGpN5kTIcvdM/Hge7K5OLoqTTaHL1pDgMXX/N3TEMnpQw0BqwD1/h0tVNmk 1DCN2OMmGDTGNyP25xINCLwMzcWR0pdFi2wpi+OCIKr6I3q0E1d41qru7J3dlol5kW oCyZi5g8XkyB1J11lG1oFWIxg/c8bAYLHqteQWMCNsfaTj0SXkO4+I7iISC4Ae07io 9zKP1ON7B0JZaenfd7MOL9W3OuL/M3o+5cOaOzi2iNYXpBqQP51csTngk44E/GqgRV Yfa1ykcjNEuXg== From: Bjorn Andersson To: agross@kernel.org, konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Praveenkumar I Cc: quic_varada@quicinc.com, quic_clew@quicinc.com Subject: Re: [PATCH v3] soc: qcom: qmi_encdec: Restrict string length in decode Date: Thu, 3 Aug 2023 09:38:07 -0700 Message-ID: <169108064636.108343.3377347407906942880.b4-ty@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230801064712.3590128-1-quic_ipkumar@quicinc.com> References: <20230801064712.3590128-1-quic_ipkumar@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 01 Aug 2023 12:17:12 +0530, Praveenkumar I wrote: > The QMI TLV value for strings in a lot of qmi element info structures > account for null terminated strings with MAX_LEN + 1. If a string is > actually MAX_LEN + 1 length, this will cause an out of bounds access > when the NULL character is appended in decoding. > > Applied, thanks! [1/1] soc: qcom: qmi_encdec: Restrict string length in decode commit: 8d207400fd6b79c92aeb2f33bb79f62dff904ea2 Best regards, -- Bjorn Andersson