Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp2495176rwo; Thu, 3 Aug 2023 10:08:57 -0700 (PDT) X-Google-Smtp-Source: APBJJlEjopw7AHa+wA7AU/OozsqHHK84y25V/lEX+5SCC617Szu7hFq/KNTnFLk3GLdRnMJfaOkN X-Received: by 2002:a17:903:18c:b0:1bb:fa61:b1b4 with SMTP id z12-20020a170903018c00b001bbfa61b1b4mr18392090plg.1.1691082537230; Thu, 03 Aug 2023 10:08:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691082537; cv=none; d=google.com; s=arc-20160816; b=iCYmDo2aeVmJirx/yi7i407C0ghgpsMMopEUOniPbOBORhpJW0E8wAUgP7Xg2beH3N T/DzkzBTTDnoskJgSJIJiCeKTGEFUyh8lC3NmAthuSm0hCJ9xkDraadcGis7PYxjGckB T5IlPUmkqFROQyIQl5bDShomDo4kdiaJwC0ymyDfj4ljs7e3lDfsIuI846DnJ3uO9hPV /2fE8GFjuyt4ivIR1kSs9+6nmKLFDpFUTzFi9Y9gTZXvhz4Y5pSWBn8WgJmMDCOvb+jK fXzIJsfc5jXWjztyzdvFzNHtv/XzrRsn8AZ2DT4SdR+EQ9ikjVSZCPhWIDp0OjeaIaya ZMFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=z59eNgn4M1iFIVPk3YUNjMH4Rw0H6AS/y6pnBDPk960=; fh=r31kaYWruoI3WP+9vWagsS0DcoKOymZyxA4ov3lB38c=; b=ETvMcNfJFMGK/IcjtxfJlyPMQzxaXxu/4C0EyLCjrt9klUnvCzcn8CbFom4z897ZnJ eaBifty+LHQprRR0ouZJEkPd1txtvH7zq3uNIP0dYMyNmor7G7eWxZwoiD7AdFPgdc+h Q0KNwV/NjAYioqRHyTilVSkPs7L6POazS/OX7Yre5NflEdtNiD4LieyFbMjHRk3pGJuh 39i1XwsgAVqA+9jb0gzu1DHkErk0jFJviY77rBvBkaFt8glCSXj0Ct8olFhNRLgFSITd uZ0T6R3c2Tdmzwkkxh8D1Djs9cVw79oH3KO1jrEWk0OEzmHc6l8k7mEM+ta6G1Ntu6Ue mV+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=uieyuRpv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j15-20020a170903024f00b001bb96de922dsi222356plh.140.2023.08.03.10.08.43; Thu, 03 Aug 2023 10:08:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=uieyuRpv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234751AbjHCQLz (ORCPT + 99 others); Thu, 3 Aug 2023 12:11:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232387AbjHCQLy (ORCPT ); Thu, 3 Aug 2023 12:11:54 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E37A1BF6 for ; Thu, 3 Aug 2023 09:11:53 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2b703a0453fso18046111fa.3 for ; Thu, 03 Aug 2023 09:11:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1691079112; x=1691683912; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=z59eNgn4M1iFIVPk3YUNjMH4Rw0H6AS/y6pnBDPk960=; b=uieyuRpvIvhpaHK7XMYzm19z9WHalOnZMeyPbAsA/kjFh2GQQfmE7FvpncdEYCj/Hm c7ePHemHtYA28LZmCAqy8FDb434onv5oPlpYyRsaXhKoMrWh0/EfO8dyUcpDT2hBFCpE ZjxZElQdag3CY/jzL8QSbms65RIh1GceIitOo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691079112; x=1691683912; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z59eNgn4M1iFIVPk3YUNjMH4Rw0H6AS/y6pnBDPk960=; b=X2bbg+WHtUoTqj1XbMfpEmFzNXOL9OPRLqHAIfSW0GKCOa1R/1ewsByOzjdlZs+eil ZC0wloTv4mUiKQv+/4bWU3w+QetDdHpAaVsRNRSBYmmHU2SJsA2+QApD4FvTPI3N3RmC /1nGCk0YSWsnx1EAtzwa8ZgKDmBcJbpkxA1JbUvZr0NSYVL2XyXhInC6jiB6OgFzaIt8 Jd+iVmV/m5hhSFcPXxdW6HE63KpFq0OZl1Bzw+3qpA1U4Jger1E5SkuY3i/zngt6d6Gh aS29Uays5hfo601r8ffUf9/S/jlYMbugriWvHDt7FWo/xCEou0YsUD+L55ajZguxa2l0 kf+A== X-Gm-Message-State: ABy/qLaFHALou0LX4bbuqraq0a89YInV43/n79knlXdPQMHoqNy45CPJ ctg6nyLFhhj5x4HsHi2E81MqH2eaLNFxaCbarZNJcw== X-Received: by 2002:a2e:9008:0:b0:2b9:7513:3596 with SMTP id h8-20020a2e9008000000b002b975133596mr7558095ljg.5.1691079111757; Thu, 03 Aug 2023 09:11:51 -0700 (PDT) MIME-Version: 1.0 References: <20230803080659.99071-1-jiapeng.chong@linux.alibaba.com> In-Reply-To: <20230803080659.99071-1-jiapeng.chong@linux.alibaba.com> From: Joel Fernandes Date: Thu, 3 Aug 2023 12:11:41 -0400 Message-ID: Subject: Re: [PATCH] rcu-tasks: make rcu_tasks_lazy_ms static To: Jiapeng Chong Cc: paulmck@kernel.org, frederic@kernel.org, quic_neeraju@quicinc.com, josh@joshtriplett.org, boqun.feng@gmail.com, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, qiang.zhang1211@gmail.com, linux-kernel@vger.kernel.org, Abaci Robot Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 3, 2023 at 4:07=E2=80=AFAM Jiapeng Chong wrote: > > The rcu_tasks_lazy_ms are not used outside the file tasks.h, so the > modification is defined as static. > > kernel/rcu/tasks.h:1085:5: warning: symbol 'rcu_tasks_lazy_ms' was not de= clared. Should it be static? > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=3D6086 > Signed-off-by: Jiapeng Chong Reviewed-by: Joel Fernandes (Google) - Joel > --- > kernel/rcu/tasks.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h > index 83049a893de5..ee1379671798 100644 > --- a/kernel/rcu/tasks.h > +++ b/kernel/rcu/tasks.h > @@ -1084,7 +1084,7 @@ void rcu_barrier_tasks(void) > } > EXPORT_SYMBOL_GPL(rcu_barrier_tasks); > > -int rcu_tasks_lazy_ms =3D -1; > +static int rcu_tasks_lazy_ms =3D -1; > module_param(rcu_tasks_lazy_ms, int, 0444); > > static int __init rcu_spawn_tasks_kthread(void) > -- > 2.20.1.7.g153144c >