Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230803080659.99071-1-jiapeng.chong@linux.alibaba.com>
In-Reply-To: <20230803080659.99071-1-jiapeng.chong@linux.alibaba.com>
From:   Joel Fernandes <joel@joelfernandes.org>
Date:   Thu, 3 Aug 2023 12:11:41 -0400
Message-ID: <CAEXW_YRQkovToQJA1FuPDtfVx0-z=Mp29KZC3irCSd7jDeA35w@mail.gmail.com>
Subject: Re: [PATCH] rcu-tasks: make rcu_tasks_lazy_ms static
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     paulmck@kernel.org, frederic@kernel.org, quic_neeraju@quicinc.com,
        josh@joshtriplett.org, boqun.feng@gmail.com, rostedt@goodmis.org,
        mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
        qiang.zhang1211@gmail.com, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Aug 3, 2023 at 4:07=E2=80=AFAM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> The rcu_tasks_lazy_ms are not used outside the file tasks.h, so the
> modification is defined as static.
>
> kernel/rcu/tasks.h:1085:5: warning: symbol 'rcu_tasks_lazy_ms' was not de=
clared. Should it be static?
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=3D6086
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>

 - Joel


> ---
>  kernel/rcu/tasks.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
> index 83049a893de5..ee1379671798 100644
> --- a/kernel/rcu/tasks.h
> +++ b/kernel/rcu/tasks.h
> @@ -1084,7 +1084,7 @@ void rcu_barrier_tasks(void)
>  }
>  EXPORT_SYMBOL_GPL(rcu_barrier_tasks);
>
> -int rcu_tasks_lazy_ms =3D -1;
> +static int rcu_tasks_lazy_ms =3D -1;
>  module_param(rcu_tasks_lazy_ms, int, 0444);
>
>  static int __init rcu_spawn_tasks_kthread(void)
> --
> 2.20.1.7.g153144c
>