Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yoann Congal <yoann.congal@smile.fr>
To:     Masahiro Yamada <masahiroy@kernel.org>,
        linux-kbuild@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, Yoann Congal <yoann.congal@smile.fr>
Subject: [PATCH] kconfig: avoid an infinite loop in oldconfig/syncconfig
Date:   Thu,  3 Aug 2023 18:40:22 +0200
Message-Id: <20230803164022.2232051-1-yoann.congal@smile.fr>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Exit on error when asking for value that has an invalid default value
and stdin is closed. Previously, this case would loop.

Signed-off-by: Yoann Congal <yoann.congal@smile.fr>
---
 scripts/kconfig/conf.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index 33d19e419908b..38ff9c81e071d 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
@@ -376,6 +376,15 @@ static int conf_string(struct menu *menu)
 		}
 		if (def && sym_set_string_value(sym, def))
 			return 0;
+		else {
+			if (feof(stdin) && !sym_string_valid(sym, sym_get_string_value(sym))) {
+				fprintf(stderr,
+						"Symbol %s has invalid default value and stdin reached EOF\n",
+						sym->name);
+				exit(1);
+			}
+		}
+
 	}
 }
 
-- 
2.30.2