Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a34b1c3c-6fc6-d762-4139-bcc397a00f3f@amd.com>
Date:   Thu, 3 Aug 2023 21:58:04 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] x86/smp: Validate APIC ID before parking CPU in INIT
Content-Language: en-US
To:     tglx@linutronix.de, linux-kernel@vger.kernel.org
Cc:     x86@kernel.org, dave.hansen@linux.intel.com, bp@alien8.de,
        mingo@redhat.com,
        Dheeraj Kumar Srivastava <dheerajkumar.srivastava@amd.com>
References: <20230719051302.15801-1-vasant.hegde@amd.com>
From:   Vasant Hegde <vasant.hegde@amd.com>
In-Reply-To: <20230719051302.15801-1-vasant.hegde@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qmd2S1VXNlk3eC9aTEt6WlVxcWttWDZjY1dlaHBoNlRNSEZCMythdVNqbFc3?=
 =?utf-8?B?MklZZUZjRitCOEdYNG1jbUhtTmdBZ0JvbWhpc1J0VmF4MDEvd01qUHZlQmhi?=
 =?utf-8?B?WkNzQm1EdC9QSWtSRGVhamxhYi9hZ1paU2l2Ymh2YjdrQmtCWmFtOGQrQklC?=
 =?utf-8?B?bDY4aytxdUd3eG9nNW9HQXBCSXZEdUttSnBmL1liVzIzSXd3UHZqRFFQZjhy?=
 =?utf-8?B?K2FIMW9XSGhheHA2REdSSXEwbWdKZnltUmhZbGsxNjg3MnduMGFXZkJyVFFm?=
 =?utf-8?B?RlZBQm9BYk0rV3JnUktJajJsdmJkZnppc05xbWRpSHZNUGl6eXlZamZYakxw?=
 =?utf-8?B?c2dsM0F0TjE3WmV3NHFDdE9wK1plUGVnS3NZYXU1Nk9EYlFwUHU3eWdNeGd1?=
 =?utf-8?B?ZmlKcjBQb2NpeHhOdWI1bkl0UE0zRXA5M05ObE1wMXg1TTVaaC94RjQ4c3Fi?=
 =?utf-8?B?aCs4Z09yUDhxc2ZucnM0UjFQTC9ORWlqdFVncHRxSjd2VTNKMVpobm9xcVBp?=
 =?utf-8?B?ZmZyc0dhV2IyWms0TUI1ZjJVcG9XU3BmZ3o1bFlzWHpxM0R1TlJ3UkVjd2Zm?=
 =?utf-8?B?T0xIbXh4TTFyU0dwKzdYdlJyMUtndDNzbnc1azBIZHpYaWJEUmU5NFdLYmtT?=
 =?utf-8?B?WHdJbFRlQ291ZEg5czVaWFVlNEg0MU5zMVVSVW9yMGNFTkVRMXZyUjBybzhQ?=
 =?utf-8?B?cmZ2b3JCUUVYM2V1RHluZnVHR2phSmJxamMvRlRJdTNsWGNCRmsrTHA2QzRr?=
 =?utf-8?B?MHUyMU8zT0Z2NXE0dXZURlpDTWlCOFpWV0NRQTdUazlPYmlKb0dMVERXZFFX?=
 =?utf-8?B?Z1ZUdnNoZnJZOWlmMjBWRzBJc0VUNVNFUmUralNobHdlODQ3ck56czRpSkps?=
 =?utf-8?B?Q05LSHc3dmM5RmpZVUluaW5rOGo4Y09DdWk0cmFDWHUxY1FzeFNUVHpPM2sr?=
 =?utf-8?B?ZWNST2FvcXFpaGpwMTA2K3VXTFRqUmc5V1BiOGUrdzZwTE0zMjJrWXBBS3My?=
 =?utf-8?B?bUVkZ2hMQTN6cVN4QW9VOWQ4clNONWpjRUhFdHhVZk1La3hiR0VBSkRoZHM0?=
 =?utf-8?B?amFPUTF5WmlVeTdVSTBjT2JVOTRwMGNUdDA4b2huUVMyNzZxYm9ZY3JKWDJU?=
 =?utf-8?B?VVAyNFZUY3FXeW1uakpoVnUrZ1huTzU2R01UYUYzczAwVlFXd2VJOW1LVjll?=
 =?utf-8?B?aDZnNGZTOHh6ZFkrbVNpOENSSWNQVDNRYm0rSHk4QTc5d2xvS1dmZHdCaUIy?=
 =?utf-8?B?OTMzQy9vMndDMUdMVVJJaUE4WWorWDV0bW9XMkI4MEpIVzhpQXdka0RIcmdh?=
 =?utf-8?B?SUVCSDdMdGY3ZmJmZ3pFWXFBT0RTb2R0YXhkdlllUSs5Z2JIZUpkeFI0QnIy?=
 =?utf-8?B?cFlKc1R2c2dPWmIxSTRXNDR2T0RweDU4dHpQaFpqRzJ2M3l2MHlSVzNpbjhj?=
 =?utf-8?B?Vm15QXBrRXcwMWlaNzdaTUoyVWtyVXNSenNTNW5ndWpuM1Y0WVhla2c3ZmZk?=
 =?utf-8?B?ZEsvd1dQOXZzR2tMbVp2M3ZXQWlVV0hkNjUzNWR2eVpwVUYvM3FRZG1sS0E4?=
 =?utf-8?B?NjU1VUFibmdJakEwVXREUmEvV3JacnlmeCtCL05uTFBBcjJielk4WklnT2Fv?=
 =?utf-8?B?VkNLd3ZoZ1FkMEJ4Yng5NHE1MDNPaUdwN3Y5UDRLaUV5ckJ0ekFHWlZ2QnlI?=
 =?utf-8?B?Y21uRGEzajVuNzFUSzhOUS9pQ2g0dEFFV3BxVHNtRnduYW5kQkpLWVViQ3RL?=
 =?utf-8?B?UTRyY21wU0V1YTF4dmN5cUtteVJvZWQrUGt1ZzVTcmNobzBhRzhMKzdSNlVG?=
 =?utf-8?B?MVh2VlJsem9qeWU1NVBOZzhmdFpMZFlPSHNlUHkxWUhQMWVmcjNOMjQ0MzJF?=
 =?utf-8?B?SGNNT2RVaWFjS0o3VHU0MkVTeXcrbkUzWENGMVUreTJjb3ZpOUV4Uko2UTRH?=
 =?utf-8?B?UzVlUVJEZytXNktZNDZmeWJ1bnI4U2Q5M0VwT0pFRW9yUHVuaDUvZmc1d2lM?=
 =?utf-8?B?Ukh4WE4ycllicnNYMUpwSlptY2Z3T1hUVkY1UStwZGVJcTlZYUNMU1Q2RUtB?=
 =?utf-8?B?WURjdFBlZzh6d204R1prMVFEb1ZXTDZDaE85dUZBT1BVa1RiZnQ3K1JmMGxD?=
 =?utf-8?Q?R87YBoYE1FvkCCAsQ6PtD/8TU?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d818a53-7f5a-4653-b977-08db943ea56f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6048.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 16:28:19.1696
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fgVviyJPK+rhQp4kQFWLiQFkqXaI7mx/UUIo3oeqEOGVPwN12arP1KWVGVNC8AbvXWPt+lFZLAepSUB/Ny825w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4854
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi

Did you get a chance to look into this patch?


-Vasant

On 7/19/2023 10:43 AM, Vasant Hegde wrote:
> Below commit is causing kexec to hang in certain scenarios with >255 CPUs.
> 
> Reproduce steps:
>   - We are using 2 socket system with 384 CPUs
>   - Booting first kernel with kernel command line intremap=off
>     This disabled x2apic in kernel and booted with apic mode
>   - During kexec it tries to send INIT to all CPUs except boot CPU
>     If APIC ID is 0x100 (like in our case) then it will send CPU0
>     to INIT mode and system hangs (in APIC mode DEST field is 8bit)
> 
> Fix this issue by adding apic->apic_id_valid() check before sending
> INIT sequence.
> 
> Fixes: 45e34c8af58f ("x86/smp: Put CPUs into INIT on shutdown if possible")
> Reported-by: Dheeraj Kumar Srivastava <dheerajkumar.srivastava@amd.com>
> Tested-by: Dheeraj Kumar Srivastava <dheerajkumar.srivastava@amd.com>
> Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
> ---
>  arch/x86/kernel/smpboot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> index e1aa2cd7734b..e5ca0689c4dd 100644
> --- a/arch/x86/kernel/smpboot.c
> +++ b/arch/x86/kernel/smpboot.c
> @@ -1360,7 +1360,7 @@ bool smp_park_other_cpus_in_init(void)
>  		if (cpu == this_cpu)
>  			continue;
>  		apicid = apic->cpu_present_to_apicid(cpu);
> -		if (apicid == BAD_APICID)
> +		if (apicid == BAD_APICID || !apic->apic_id_valid(apicid))
>  			continue;
>  		send_init_sequence(apicid);
>  	}