Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH -next v3] usb: gadget: udc: gr_udc: Do not check 0 for
 platform_get_irq()
To:     Zhu Wang <wangzhu9@huawei.com>, gregkh@linuxfoundation.org,
        herve.codina@bootlin.com, stern@rowland.harvard.edu,
        robh@kernel.org, aaro.koskinen@iki.fi, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230803121136.86037-1-wangzhu9@huawei.com>
From:   Sergei Shtylyov <sergei.shtylyov@gmail.com>
Message-ID: <e85efc8e-5a12-5f9f-a23e-d701b5722896@gmail.com>
Date:   Thu, 3 Aug 2023 20:00:36 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20230803121136.86037-1-wangzhu9@huawei.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/3/23 3:11 PM, Zhu Wang wrote:

> When platform_get_irq() failed, it may return -EPROBE_DEFER, -EINVAL or
> -ENXIO, it is important to propagate the detail upstream, we cannot
> override it.

   Deferred probing being fixed should be emphasized. And the patch is
no longer "-next" material due to that...

> And platform_get_irq() used to return 0 (as both IRQ0 and error
> indication), there are several patches fixing the inconsistencies.

   No, this "historical" passage wasn't meant to be a part of the patch
description.

> Commit ce753ad1549c ("platform: finally disallow IRQ0 in
> platform_get_irq() and its ilk") makes sure IRQ0 is not returned.
> 
> Signed-off-by: Zhu Wang <wangzhu9@huawei.com>
> 
> ---
> Changes in v2:
> - Update the commit message, present the reason of replacing the return
> value of the probe.
> 
> ---
> Changes in v3:
> - Update the commit message, explain in detail why the return value of
> platform_get_irq() cannot be override.

   As I said, your descrioption isn't very convincing as you don't
emphasize the deferred probing being fixed.

[...]

MBR, Sergey