Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a8466f4b-f773-4d0a-f22b-34c83a7aa942@intel.com>
Date:   Thu, 3 Aug 2023 17:55:43 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH net-next 0/3] virtchnl: fix fake 1-elem arrays
Content-Language: en-US
To:     "David S. Miller" <davem@davemloft.net>
CC:     Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Larysa Zaremba <larysa.zaremba@intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Kees Cook <keescook@chromium.org>, <netdev@vger.kernel.org>,
        <linux-hardening@vger.kernel.org>,
        <intel-wired-lan@lists.osuosl.org>, <linux-kernel@vger.kernel.org>
References: <20230728155207.10042-1-aleksander.lobakin@intel.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230728155207.10042-1-aleksander.lobakin@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N09OMDA5YmdUc3E1V3dIMWd1eTAvVDlaM2FWN1hxQWRncnVvSjRuNjZUU2Zq?=
 =?utf-8?B?SmNlS1UvVVc0N3VmVEo0VjVKZFMxc0djeWkvLzM3VnNjdDNhdnJDRWdUSndo?=
 =?utf-8?B?Z3MvL1lDa1FNNjByR25nMHdOTFJwTTNFbERBNkdKK2FyNTcrdExTY3JPMGNv?=
 =?utf-8?B?V3diRk8zUUJVNGpCTi80TnVWSHg4bTF6T3BDK0d2UTJra0ZmUXZBV1BUZU02?=
 =?utf-8?B?NUoxaHlPZXIrbVpNK0xvMFZKOG1EWnFjZEN6bFlUditrR0dnaEJoRmVrbDdl?=
 =?utf-8?B?UnpnNzZKTVE5OGJMb2xzM2pyQjNPZ0JEMVkzT2d3UTZFaVNzeit0d3J6SlZL?=
 =?utf-8?B?MVl2VmNGVHBvWm02RU1YSWVDVHhKZFBrZlB6OUNKRmdzYnAvZG9rOUdsTjlZ?=
 =?utf-8?B?Zityb01kUkNMZFQ5YytIQXJ5Umg4RHAranQyZ0VOeWF5YlR3TjNUMVlKL2g5?=
 =?utf-8?B?M2EvVmhvNFpJSzdsMWFjV3JmUER0aWxIYkNJTDZSemtzWnA4bk9adEZMMEQz?=
 =?utf-8?B?dlFNdHZ0VTc1ZjFwcy9ackIyamFNZFpUcXBPVW83cTJqbEsvc0lBa1dBc3FM?=
 =?utf-8?B?akIwbDZPaXJjK2VJeWk0OU4xNHZvaFRmVXlCM2M0TDl2eEJTUG41WDRqS3Vz?=
 =?utf-8?B?RkxBajZ2MXdXUm84cnNzNkR3SDNPZmJRZnBkL1N0amQrVWJpUTVRdC9uQU9w?=
 =?utf-8?B?QlFDUFRhZzNXU1JWRWs0MnRGQWxBd1NhbStOK0hWdjNBb3V3WHFGZzBaaUNU?=
 =?utf-8?B?Kzg3MUEwY0VFNWVlVGRMRWUxdVlKQVVTSW1CMmU3RmN0OElGR0NqTktXZFRX?=
 =?utf-8?B?Rm56L2taNlBDbmRRTmhrY0tGRVdvMlBSbGZjNHYrT25IaVdWUGFWRnhqU0Mz?=
 =?utf-8?B?N2FLSEVEQWllNHFvV2RpMS9PNXVrcjZsa3I2SGlmcVlsQVhoUjZ6Q3Nxd3FK?=
 =?utf-8?B?V3UzRlIwVk1NU0U3T3FtRDdGSExJV0hGM1hvMFJMTGhFd1M4SzROSFRQLzNy?=
 =?utf-8?B?OEphTC85WGpsYXRjN3ArQ2hsWmFxQXd2MmhaVjRLODdFbzgxc2lIYVpHU3Yz?=
 =?utf-8?B?alp1eC8wLzVweDJvQWJUcmE2MjFUZ0hqblg0b3g2SHVlV2ZWUUJvOHdFemRM?=
 =?utf-8?B?WTlyT3JqNHU5ZHB5SlhtMldVL3l4V3lZMExxdmt2RTNvU00zREoxSDZDMXpX?=
 =?utf-8?B?Y04ra25qazlzZ043aXB4WHNYMU4vVTB1VWtaQjlZeDhQTlluMzB2bDdsajdw?=
 =?utf-8?B?dWs2VkJoUUVOTHpFbDk4dFQvTWZ3b0QyTDdKQmI1ZHZCdVFINGRrVzRKcWVN?=
 =?utf-8?B?TEMyL01xS2t0dlllVnlYRFMrM3ZSS1lHNnZDMlk2ak81eFJ5d05IRmp3bkl1?=
 =?utf-8?B?Y3RRaUduQlBGd0YwYWR5akxlbXV3SkNoSER3RDlzOUUrRHRJZ1YvVkNnT3Bk?=
 =?utf-8?B?ZUVaaTFDTjZlaU9rUThHWEhlMEJmOUk3b1BscVZvdThNZ1ZucndHMXJObUVW?=
 =?utf-8?B?OWtUZnJSK1FkZFJFRFNwWWluVEpCVDVwMHViNy9ldlBvMFNVWG9BQ21STTVK?=
 =?utf-8?B?dCtPOHZrSXJ5c0E3QkY4Z2ZpRWRycUhjVFZXT0lSM01uZVk5T0xUTm4rK09B?=
 =?utf-8?B?SXNYNDdiNWZRM3NnNG5FV3NDU2JneWQ3RHh3Mk5VNjMyK29SZVRVTDZFQzBs?=
 =?utf-8?B?d2VHajBkeEViNmFoMXZqL3I5aWp4T3R5VzhGTVVrd25XTFhhcjVFWkpoSTVX?=
 =?utf-8?B?UUI0Z3QrU0FBQUgvMktWVEV1SU5PQnVDVGFWZVN4Njkvekx4RWE4Z2xPdSs4?=
 =?utf-8?B?TkpGMUxraStxb25RT2FOTWxTbDNZWkFkTTFiV3RFNEdHUmJUSmFYTk1PNE9E?=
 =?utf-8?B?TU8xcDdRUVBhZmMzZDczYWxSdGl2SFBsOU9TZS9Wdm9XVU9QbGRoRkhUWnRr?=
 =?utf-8?B?bmx2NFBjL3hCK0FKZzZwYlFPQzBZY0dQWXBYQ3VtSHZkcWVIN0JuVy9FU2Zz?=
 =?utf-8?B?N2xmYUQrRVVFSncwa0Y5R1BUN1JkdzhmNGdvZnk1VUYzdXoxK2xhTU1zRjhD?=
 =?utf-8?B?U3ZIZlJuUmlIWlVEMzVoa2NteHUrWGZMbWU0WEdxVFFSY01sNjZKV0x5TkRF?=
 =?utf-8?B?QmhxSDBadW8xb3Q4MlVSZFdiS1pKOGJPaTZUS2pTWHRqYXVvdlB6VzlUNzZp?=
 =?utf-8?B?TEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c12ce2e9-785b-4edf-fcd5-08db943a1bf5
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 15:55:50.3922
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pR64vSqbKQgPxNbEK94aWOJwGlp2bgyh8Orgv/dLJILC3jOHQGhj0dd7j1yqKRN2MAZcX66h3kFVA2fSRd+H0Cergsd0RJYR4FEmUS/2/5w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4577
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Alexander Lobakin <aleksander.lobakin@intel.com>
Date: Fri, 28 Jul 2023 17:52:04 +0200

> 6.5-rc1 started spitting warning splats when composing virtchnl
> messages, precisely on virtchnl_rss_key and virtchnl_lut:
> 
> [   84.167709] memcpy: detected field-spanning write (size 52) of single
> field "vrk->key" at drivers/net/ethernet/intel/iavf/iavf_virtchnl.c:1095
> (size 1)
> [   84.169915] WARNING: CPU: 3 PID: 11 at drivers/net/ethernet/intel/
> iavf/iavf_virtchnl.c:1095 iavf_set_rss_key+0x123/0x140 [iavf]

(tender ping :D)

Thanks,
Olek