Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 3 Aug 2023 11:40:27 -0700
From:   "Paul E. McKenney" <paulmck@kernel.org>
To:     Joel Fernandes <joel@joelfernandes.org>
Cc:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        frederic@kernel.org, quic_neeraju@quicinc.com,
        josh@joshtriplett.org, boqun.feng@gmail.com, rostedt@goodmis.org,
        mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
        qiang.zhang1211@gmail.com, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] rcu-tasks: make rcu_tasks_lazy_ms static
Message-ID: <d70f4a6b-4adf-446d-b29c-8ecb4b85d689@paulmck-laptop>
Reply-To: paulmck@kernel.org
References: <20230803080659.99071-1-jiapeng.chong@linux.alibaba.com>
 <CAEXW_YRQkovToQJA1FuPDtfVx0-z=Mp29KZC3irCSd7jDeA35w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAEXW_YRQkovToQJA1FuPDtfVx0-z=Mp29KZC3irCSd7jDeA35w@mail.gmail.com>
Precedence: bulk

On Thu, Aug 03, 2023 at 12:11:41PM -0400, Joel Fernandes wrote:
> On Thu, Aug 3, 2023 at 4:07 AM Jiapeng Chong
> <jiapeng.chong@linux.alibaba.com> wrote:
> >
> > The rcu_tasks_lazy_ms are not used outside the file tasks.h, so the
> > modification is defined as static.
> >
> > kernel/rcu/tasks.h:1085:5: warning: symbol 'rcu_tasks_lazy_ms' was not declared. Should it be static?
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6086
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> 
> Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>

Queued, thank you both!

							Thanx, Paul

>  - Joel
> 
> 
> > ---
> >  kernel/rcu/tasks.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
> > index 83049a893de5..ee1379671798 100644
> > --- a/kernel/rcu/tasks.h
> > +++ b/kernel/rcu/tasks.h
> > @@ -1084,7 +1084,7 @@ void rcu_barrier_tasks(void)
> >  }
> >  EXPORT_SYMBOL_GPL(rcu_barrier_tasks);
> >
> > -int rcu_tasks_lazy_ms = -1;
> > +static int rcu_tasks_lazy_ms = -1;
> >  module_param(rcu_tasks_lazy_ms, int, 0444);
> >
> >  static int __init rcu_spawn_tasks_kthread(void)
> > --
> > 2.20.1.7.g153144c
> >