Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp2717629rwo; Thu, 3 Aug 2023 13:55:21 -0700 (PDT) X-Google-Smtp-Source: APBJJlHFO0hnpLQCsEFYQr2LBzIfVFpycYUjbAgNVLLhlS+OhaSizyd7xKAwsuGzIXrXnu0Gkrax X-Received: by 2002:a17:90a:5d01:b0:262:f8b8:dba2 with SMTP id s1-20020a17090a5d0100b00262f8b8dba2mr17434483pji.35.1691096121184; Thu, 03 Aug 2023 13:55:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691096121; cv=none; d=google.com; s=arc-20160816; b=DVpvjmrKtwCBLIrpc/nG9hqCPZCjAi7ovEd3tE3bjFSN1l1WNMXREzf4kQaQutePVy nOwOrNlOuXUEZvEXZcF1Z8bH33G9I5loF2D0yVfpCPwb9BHVTA7w2n7ftRfmVleNd0iN +DvBv24WnVgcYe+OBWjo/ZrRHl6edUHJ7c5YrOE3GrjadHwEZUVmASWeNX0E1YSLevy+ YUG3zcEeLuHsF+98BINkdBT1MlFM2OxYXJ/9atgPV3odVe6frVnLQWdmAHcpH127xQRD SXoJNcZvnfFYZfqUnH/F4URWO64P3XLE677vQY3tb55mc/bdqebOBSKnEXjgftn22dNa Y5Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Na39kC0nP6XiW875V274Re2PU/Nlj2wRY/n4Ot8HLjM=; fh=mFxIFnnXlqqX34qasivGv4gqlRONFW9t1msFeRPzhpI=; b=jSD4VlW/cqMYo2awzF96/rEd7L/VssAUQCkp56hW6Ps+8IiBQYfTAzgKwhsK6GsLEC r0oTEuTQNjVXbtjKVZanj8oCLmUZx6UDOFbcodsALkF1oHdzqZewWhpef8A/60VR0NmH OuEOI3iHluXeGCrYB/cuAQq7JAdxIw+1HA6rDSQP5ccvu0PkM1FilBRLQb7QtVrZ82Pp kynJekSkEpwAVPL73AeoEnFRLb0gbAXDI01cT07dpoF0h8gjSWRG8ceooGRIlV4bawNr bQU+YaB+wCUJTFTr7QlRnEUVvixtACGWUWRPY1MtUoPtw20pfyWpQ25lE9DGfaRaVnhX 61rg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Vq2BHfXd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cs7-20020a17090af50700b00267ec79de52si2767732pjb.11.2023.08.03.13.54.38; Thu, 03 Aug 2023 13:55:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Vq2BHfXd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230163AbjHCTdZ (ORCPT + 99 others); Thu, 3 Aug 2023 15:33:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229495AbjHCTdY (ORCPT ); Thu, 3 Aug 2023 15:33:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7579A3C3B for ; Thu, 3 Aug 2023 12:33:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DB55160C5B for ; Thu, 3 Aug 2023 19:33:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1C3AC433C7; Thu, 3 Aug 2023 19:33:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691091202; bh=Na39kC0nP6XiW875V274Re2PU/Nlj2wRY/n4Ot8HLjM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Vq2BHfXd0gAouZIkgnzf1DfzUa8NZDzU1x8y7+3dNLTFUILMcNkIJvKYBfYJQSzW3 RYYZmW45VHl7DbGGghUJpfaBpUH7es8pY2cMU1BfFMZQEQ0Iqz4ZnMGRTfEr/XRwBy 1bvtHux6jRaWV01Q2gCrU44FeWfqiLUgX1Qmj6zGCNRK+gxK98jY1X++g7wIfP24If a0E9MgRAXWgIB39M4D8d9tda3B8eJkLwYUhbevvI8+k6Nuu8n7GvRO8ULiKUfic2JV G3TZQwTX9hYfUSjPpfhPafGmOTpya0qnfqCkV8UxYslk+fOkc8JquUxObDallXK/R7 /lKiMhto7KJrg== Date: Thu, 3 Aug 2023 20:33:15 +0100 From: Mark Brown To: Jiaxin Yu =?utf-8?B?KOS/nuWutumRqyk=?= Cc: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "ajye_huang@compal.corp-partner.google.com" , Chunxu Li =?utf-8?B?KOadjuaYpeaXrSk=?= , Allen-KH Cheng =?utf-8?B?KOeoi+WGoOWLsik=?= , "dri-devel@lists.freedesktop.org" , "kuninori.morimoto.gx@renesas.com" , "andrzej.hajda@intel.com" , "linux-arm-kernel@lists.infradead.org" , Project_Global_Chrome_Upstream_Group , "robert.foss@linaro.org" , "Laurent.pinchart@ideasonboard.com" , "neil.armstrong@linaro.org" , "angelogioacchino.delregno@collabora.com" , "nfraprado@collabora.com" , "alsa-devel@alsa-project.org" Subject: Re: [v3 2/3] ASoC: mediatek: mt8186: correct the HDMI widgets Message-ID: <9c90185c-9cd4-4a08-9925-be5d460af54d@sirena.org.uk> References: <20230730180803.22570-1-jiaxin.yu@mediatek.com> <20230730180803.22570-3-jiaxin.yu@mediatek.com> <25e6ab45-ecad-4bc3-bf4d-983243c939ad@sirena.org.uk> <089fe457-1c61-4b7b-ad37-a67e7f46cb56@sirena.org.uk> <6aa6947865795fc534b61f5b8a80b3c42fd5a0cd.camel@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+mbNnAHmVhFc8DSv" Content-Disposition: inline In-Reply-To: <6aa6947865795fc534b61f5b8a80b3c42fd5a0cd.camel@mediatek.com> X-Cookie: One Bell System - it works. X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --+mbNnAHmVhFc8DSv Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 03, 2023 at 07:20:15AM +0000, Jiaxin Yu (=E4=BF=9E=E5=AE=B6=E9= =91=AB) wrote: > I agree with you, in fact the speaker is indeed doing this way. But > about the hdmi that on the board, I did not find a defination link > snd_soc_dapm_hdmi, so I use snd_soc_dapm_line to replace. The purpose > is to control it link speaker. Or what do you suggest I should do?=20 I think the sensible thing here is to define a DIGITAL_OUTPUT() which can be used for HDMI, S/PDIF and anything else that comes up and isn't clearly wrong like reusing one of the analog descriptions is. --+mbNnAHmVhFc8DSv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmTMAPoACgkQJNaLcl1U h9CWewf/XtBsII8aM+PvwnIJ4Sr4fN16oOfY1UY32SAMvG5kfv55GzqucnYVEkQW a1Xs2el6AlSouSelQ12FvpaBAXjHAlQpyUoMwI0BYjncBoJ1aHZEGgwE54710y5H eRQmJH2oarBgD4MbO5N1pqUVbajjCg4mtU61yWgPhYlniAMILOmzyF5jxcpE7EET 7cd0djgpIZHR/osfIG3EA7WQKjuZyMtB/0YKncA1qRoUP0pqZQfetbeHqtchfqJy 3YvmkidEFoaROm7dSZWbNImhDbRVPNal4iot/8JUghN+yo867eidr/0i1kgzgJ8j +A+PCUclKZDIDoGbmL2M5hlTe+Ihbg== =3kqt -----END PGP SIGNATURE----- --+mbNnAHmVhFc8DSv--