Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp2832728rwo; Thu, 3 Aug 2023 16:09:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG4Dm0DS6xtEZ2wvasJf0VPuZxfZgRVRSFaFQnHUjBVLbgOpzvcFJMcUUukpWScQlu/3wzH X-Received: by 2002:a17:903:124d:b0:1bb:961e:dfbc with SMTP id u13-20020a170903124d00b001bb961edfbcmr192374plh.20.1691104160030; Thu, 03 Aug 2023 16:09:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691104160; cv=none; d=google.com; s=arc-20160816; b=L1aL6LlcTJckuqV4ZqCLIh67jP9IiBg6fMK1OFILREtywvbtIILRkmPV+jbfxtC66F z2DyiakwXiDcYF51NmoANChGP0Vp2NkeMk54zWcpajQvgL4S1TbGnNWSbvp/Pn7rlZrv w75UW1LZkmSjhxwB8Vrd6ScwzbvcajRSP3dd0rxERTEQJMFrp2okIsAvZIGCNkR1XOq+ sryqnVvS54VrqF9IA8A7t14ND1ybRWDbeHhbmKxaV5M863flhbonk5+iKFuotzadgpbR 8hZSFjIm2myP7cn3upvzttGtLs1M7Kh3US7XxKSNkELHhPiYz2zy0SJwAAY1ibH1WeUh lqxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=K6cEzgaBtocZJigpN/M1QRJPG6OFB1fH+2eZXCJJXmc=; fh=mlxJew9CVZ4g+Al794h+irzadBlRfRbBPvTI+Z7h0G4=; b=Cahdc0ZJn+CrOaNrakroEZC50yy+XXSM04ipj7IFIx007PrmjxefsPMk9yMEB+HZLE f/WU5bLqLNYNsEDAYAn4759N+ny/hV3QqMFF4tJBRRnrcFFYShZjQh7djTF6b0Mu49+Q 8SSGlHqpZt29eV31rF/8OQnAoyj/p7kUMf9gRYRuBR6MywGTSVoWx/LGet15puXarwUq ggtX95lwTkDdXOPhwNblzCptmk327ZW/7pHOw6w3CF8Q0fgQ9Slb+V9iXwvpkaZ20827 lky86GsF7ooxZfhvo4H5vrZ0JR4nQsrYylTDPYCOMkSHxB3O/cF80Vj+0cYywzzUamlv NhOA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=irl.hu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d7-20020a170902cec700b001b8b6089eeasi700378plg.326.2023.08.03.16.09.07; Thu, 03 Aug 2023 16:09:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=irl.hu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231998AbjHCV47 (ORCPT + 99 others); Thu, 3 Aug 2023 17:56:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231597AbjHCV4y (ORCPT ); Thu, 3 Aug 2023 17:56:54 -0400 Received: from irl.hu (irl.hu [95.85.9.111]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEF163C2D; Thu, 3 Aug 2023 14:56:51 -0700 (PDT) Received: from fedori.lan (51b69adf.dsl.pool.telekom.hu [::ffff:81.182.154.223]) (AUTH: CRAM-MD5 soyer@irl.hu, ) by irl.hu with ESMTPSA id 0000000000072E2E.0000000064CC1C45.0001D182; Thu, 03 Aug 2023 23:29:41 +0200 From: =?UTF-8?q?Gerg=C5=91=20K=C3=B6teles?= To: Mauro Carvalho Chehab , Laurent Pinchart Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Gerg=C5=91=20K=C3=B6teles?= Subject: [RFC PATCH 0/2] media: v4l2: map UVC_CT_ROLL_ABSOLUTE_CONTROL Date: Thu, 3 Aug 2023 23:28:56 +0200 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Logitech Streamcam can be mounted in 'portrait mode' as well. It reports the current roll (-90, 0, 90, 180) with UVC_CT_ROLL_ABSOLUTE_CONTROL. This RFC defines V4L2_CID_ROLL_ABSOLUTE, and maps UVC_CT_ROLL_ABSOLUTE_CONTROL to make it available to userspace. Then, the userspace can rotate the stream based on the roll. Is it better to use V4L2_CID_CAMERA_SENSOR_ROTATION for this? The value set matches that control. If yes, is it worth mapping UVC_CT_ROLL_ABSOLUTE_CONTROL to V4L2_CID_CAMERA_SENSOR_ROTATION for this camera only? Any feedback is greately appreciated. Gergő Köteles (2): media: v4l2: ctrls: Add ROLL_ABSOLUTE control media: v4l2: map UVC_CT_ROLL_ABSOLUTE_CONTROL .../userspace-api/media/v4l/ext-ctrls-camera.rst | 5 +++++ drivers/media/usb/uvc/uvc_ctrl.c | 9 +++++++++ drivers/media/v4l2-core/v4l2-ctrls-defs.c | 1 + include/uapi/linux/v4l2-controls.h | 2 ++ 4 files changed, 17 insertions(+) base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5 -- 2.41.0