Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <973ae60f-15cd-19a3-7314-d165696b833c@intel.com>
Date:   Thu, 3 Aug 2023 15:42:15 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [patch V3 12/60] x86/of: Fix the APIC address registration
Content-Language: en-US
To:     Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>
Cc:     x86@kernel.org, Andrew Cooper <andrew.cooper3@citrix.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Wei Liu <wei.liu@kernel.org>,
        Arjan van de Ven <arjan@linux.intel.com>,
        Juergen Gross <jgross@suse.com>,
        Michael Kelley <mikelley@microsoft.com>,
        Peter Keresztes Schmidt <peter@keresztesschmidt.de>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>
References: <20230801103042.936020332@linutronix.de>
 <20230801103815.818545643@linutronix.de>
From:   Dave Hansen <dave.hansen@intel.com>
In-Reply-To: <20230801103815.818545643@linutronix.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/1/23 03:46, Thomas Gleixner wrote:
> The device tree APIC parser tries to force enable the local APIC when it is
> not set in CPUID. apic_force_enable() registers the boot CPU apic on
> success.

I went looking for how this registration happens.  I was expecting to
see something apic_force_enable() do something similar to
register_lapic_address().

But the apic_force_enable()=>apic_verify() call chain is pretty shallow
and I'm not seeing a lot of overlap.

Am I reading the "registers" part of this too literally?