Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <40d49276-fae9-e538-61cf-64bb79233bc3@intel.com>
Date:   Fri, 4 Aug 2023 07:27:14 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH 0/2] don't use mapcount() to check large folio sharing
Content-Language: en-US
To:     Yu Zhao <yuzhao@google.com>
CC:     Ryan Roberts <ryan.roberts@arm.com>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>,
        <akpm@linux-foundation.org>, <willy@infradead.org>,
        <vishal.moola@gmail.com>, <wangkefeng.wang@huawei.com>,
        <minchan@kernel.org>, <david@redhat.com>, <shy828301@gmail.com>
References: <20230728161356.1784568-1-fengwei.yin@intel.com>
 <3bbfde16-ced1-dca8-6a3f-da893e045bc5@arm.com>
 <56c8f4f9-b54b-b0bb-250c-ec8643accfc7@intel.com>
 <3541d2de-5cf8-2f84-8153-277e2bfc0101@arm.com>
 <5f98748a-97ca-6426-1e24-a5675da75381@intel.com>
 <a590da86-0c42-7d46-d320-c661a59a46c1@arm.com>
 <837ba176-c97f-f81b-c044-eb6aa3d88bb7@intel.com>
 <CAOUHufY9EQ70Pn-n2zVa9=Gm3-WHxxphp7VHia4qv9x2domdbg@mail.gmail.com>
From:   "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <CAOUHufY9EQ70Pn-n2zVa9=Gm3-WHxxphp7VHia4qv9x2domdbg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0Q2aGVtQmNuWVpZRGdjU0VCUGtWTy9rb0E3c0sybnU5azVydDAxY0I3VG5V?=
 =?utf-8?B?eWZIbW91Q3g4SEo1T0JQdjIweUt4Wk1tekdLdWFWOUIwV05JYU9aNmJMRGhj?=
 =?utf-8?B?OEYyK0s3aE5xU0sxb2dpc0htNG85em9VeVpFK1ZmNVYreVU3SDZhTHg2K3F3?=
 =?utf-8?B?T1pJYUg2dTcwYzdwSldRS0pzMFJ1UHVuN2U5Ty9QQW1WVjkvOFVNTytPSzly?=
 =?utf-8?B?czFSL2NRRUQ3aXI1V2pwUGNaK3lwa1Nlbi9KZEVxcS9HSXE5bVFnSDlGVGdi?=
 =?utf-8?B?U1ZVQ3cvQWtYSGpwRDRDQ2RqY2owU2Q5bStHd2w1LzdISG9tWEVGcG5WU3F0?=
 =?utf-8?B?NGJET0pJVHJDMllKNHJ5czhPeXZReEVhSVNXVnZDdFNtUVdlQVhPc3lhK0hi?=
 =?utf-8?B?OWM0NnkzakxONjhwWklqN1VnViszL0VlVkVXV1R3T1hWdm9PWDJJVmFDUVJl?=
 =?utf-8?B?V0k3S2NYRWpMcEluVWg1cThiRXpjZ0thSit0Q2tuNGhEN3JOVXpYcFV2VWsx?=
 =?utf-8?B?UnZwVzBVL29mY21jUCsvS1NmdG1mYURuMG94b0dzZ3cwekRTWEtQZTBIazM5?=
 =?utf-8?B?SmZhNGp5TlBZeit1WE5QNHZ4V1UycVAxZHF0dlFORjgwWnAzRzhKbFlnN2xh?=
 =?utf-8?B?bi95L2FWc0R6dG45Y0tiU2lNY3JsVFd6bnZvb01HZ0xyQzU3STkwd01ycWZo?=
 =?utf-8?B?T3QwcnBDUEtNZGJsUitzVDJWcXcydUszQS9neDBYQndyTnljQTNxcVpJL3ow?=
 =?utf-8?B?K1RIYzVwcFdBME0ycEszSjROam9haUhYWnpwdmQ0ZzUycC9KcnhyQUQxV3Jl?=
 =?utf-8?B?Y2M5TkQ4WkFHa2s2VnlGK3RxbE9BNTh3K1B0VVJXV01xaFRtMWFvaml5V0Ju?=
 =?utf-8?B?YUdSak84NlVzcWt3aXYwVW1SZW1HTExSU0lHZVRIQXBFWFZkUU5qa1JQaCt6?=
 =?utf-8?B?WDEzaWduTDYrN3NuZHdUaXFqSFI3c3VXUzFhRXZHbWtBT2RDdWRtNzRNbmNE?=
 =?utf-8?B?RTNacGpFaTAyd01ibTRKcXZXZ3hzdWVWZjNBL3ZNOVVtK3d4N2pRQ2w2ZGtl?=
 =?utf-8?B?WVA1Q0ZTd29iczBZUFdSbzJNcm4yTGsyWHJIc1RpODJjOGdkOHBySjR6T2pD?=
 =?utf-8?B?S0ZEeE4vMFR3dCsyZERzbzZrSTRKV2xwWmRjOGV1WThXYUZ0cXd0cFRVblNx?=
 =?utf-8?B?UjhoSG9Vcm9jek5SNmFYTlo3SS9aa21kQ2xqVzQ2RzlsakNabTdONks4bXhJ?=
 =?utf-8?B?OUFOaTJMdStxUEJ6bHZFcmQxRkJHNlQrR0RUOHpodTdLV1dFN21lc1Z5UU9Q?=
 =?utf-8?B?aHl4bk5HM2kzRXhpd1c3aHg3Y3dsOEdGSnhEeFZtTTUxajZJK2dKTHhHUmN6?=
 =?utf-8?B?SWdRbmFXVlBUcUJDT1hrbXRRY2RDZnZRdkFqaUdFWFFySUpFc3pNTUJVUm9v?=
 =?utf-8?B?c0xabkttdlZlb2loUVNaREMraU1IMnBRaGplSUtTTFhyR29XNXBpTjZETngv?=
 =?utf-8?B?ZExPZ1FSM2pUeWk3SnJuRERaam9KRE1GME9SNEdVbTZhVnU2UlpDYVZZRG5Y?=
 =?utf-8?B?WmFmOHJXWDVQaXVrbmxxaHZqMlpQVVhPRXpZeVZVdGk1WkJVbnhwWFVicm9h?=
 =?utf-8?B?a05JTGUvVGFXYTU0Y2lGc0pYTUFxcmFoaytKUTA0L3BjZnQyOTNJN1ZzS2sv?=
 =?utf-8?B?SS9VRnJjQ2hEVWFtRDZ3bUtXODJoZ2ZFNDJVbTN6RDNGanNYNjFReXFlTGFG?=
 =?utf-8?B?ckdEMEJad2ZxRkFYbWM3SGIvNFVYYnc3Slh4dm0rZUEvT2tUVkkrOGdSRWNV?=
 =?utf-8?B?aTZuUm1zK0FzTjRRQy85L2VrNThVUjRkOGV0cklPVTR3bHRFWmJUbkdxWFAy?=
 =?utf-8?B?UER1YXJTN0pieDcwQlNxZ1g0S2JZNGVZeHNvMm5tWVIrV1I3SFp0UTdDTDQv?=
 =?utf-8?B?N3YxaXZUKzMyT2VlbFRPajdGelR1OVY1VTdncHFyUVV6QjRPWXJ0di96YlpY?=
 =?utf-8?B?blB5SkFqS3RFN1FWQy82Rk15cC9CUWZ0SG5qc3NSL0pRZ3k2YkhqaU5mYnln?=
 =?utf-8?B?d3MxcmFXZFF6VTBhR2E2T3kyOG5DOGJrSTlYemhQNlFDREhIODBlK3ZPLzhP?=
 =?utf-8?B?L0UwUlRyellnTzA4dzY2amppbHA5MlF6UXYrSmtFbEhOWU1LaUJWUGxYV0FC?=
 =?utf-8?B?cGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 498d4927-087c-4116-b877-08db94793277
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 23:27:26.4472
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3PhzIQXnwuwbQOW1fJ1UI2oOT/fPM4Gbj/R+nW6Y9yYZOsT/rJh3iRQ2A65ecam956BtQya2FKtyorm1YRVeDw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8557
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/4/2023 4:46 AM, Yu Zhao wrote:
> On Wed, Aug 2, 2023 at 6:56 AM Yin, Fengwei <fengwei.yin@intel.com> wrote:
>>
>>
>>
>> On 8/2/2023 8:49 PM, Ryan Roberts wrote:
>>> On 02/08/2023 13:42, Yin, Fengwei wrote:
>>>>
>>>>
>>>> On 8/2/2023 8:40 PM, Ryan Roberts wrote:
>>>>> On 02/08/2023 13:35, Yin, Fengwei wrote:
>>>>>>
>>>>>>
>>>>>> On 8/2/2023 6:27 PM, Ryan Roberts wrote:
>>>>>>> On 28/07/2023 17:13, Yin Fengwei wrote:
>>>>>>>> In madvise_cold_or_pageout_pte_range() and madvise_free_pte_range(),
>>>>>>>> folio_mapcount() is used to check whether the folio is shared. But it's
>>>>>>>> not correct as folio_mapcount() returns total mapcount of large folio.
>>>>>>>>
>>>>>>>> Use folio_estimated_sharers() here as the estimated number is enough.
>>>>>>>>
>>>>>>>> Yin Fengwei (2):
>>>>>>>>   madvise: don't use mapcount() against large folio for sharing check
>>>>>>>>   madvise: don't use mapcount() against large folio for sharing check
>>>>>>>>
>>>>>>>>  mm/huge_memory.c | 2 +-
>>>>>>>>  mm/madvise.c     | 6 +++---
>>>>>>>>  2 files changed, 4 insertions(+), 4 deletions(-)
>>>>>>>>
>>>>>>>
>>>>>>> As a set of fixes, I agree this is definitely an improvement, so:
>>>>>>>
>>>>>>> Reviewed-By: Ryan Roberts
>>>>>> Thanks.
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> But I have a couple of comments around further improvements;
>>>>>>>
>>>>>>> Once we have the scheme that David is working on to be able to provide precise
>>>>>>> exclusive vs shared info, we will probably want to move to that. Although that
>>>>>>> scheme will need access to the mm_struct of a process known to be mapping the
>>>>>>> folio. We have that info, but its not passed to folio_estimated_sharers() so we
>>>>>>> can't just reimplement folio_estimated_sharers() - we will need to rework these
>>>>>>> call sites again.
>>>>>> Yes. This could be extra work. Maybe should delay till David's work is done.
>>>>>
>>>>> What you have is definitely an improvement over what was there before. And is
>>>>> probably the best we can do without David's scheme. So I wouldn't delay this.
>>>>> Just pointing out that we will be able to make it even better later on (if
>>>>> David's stuff goes in).
>>>> Yes. I agree that we should wait for David's work ready and do fix based on that.
>>>
>>> I was suggesting the opposite - not waiting. Then we can do separate improvement
>>> later.
>> Let's wait for David's work ready.
> 
> Waiting is fine as long as we don't miss the next merge window -- we
> don't want these two bugs to get into another release. Also I think we
> should cc stable, since as David mentioned, they have been causing
> selftest failures.

Stable was CCed. Andrew asked about the user-visible impact and I replied:
https://lore.kernel.org/linux-mm/24e7429c-14ed-d953-e652-eac178de76e3@intel.com/

I was not aware that selftest is impact by the issue. And waiting for whether these
patches are necessary for stable.

But I don't want to promote this kind of change in other place as we will move to
David's solution.


Regards
Yin, Fengwei