Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Dave Hansen <dave.hansen@intel.com>,
        LKML <linux-kernel@vger.kernel.org>
Cc:     x86@kernel.org, Andrew Cooper <andrew.cooper3@citrix.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Wei Liu <wei.liu@kernel.org>,
        Arjan van de Ven <arjan@linux.intel.com>,
        Juergen Gross <jgross@suse.com>,
        Michael Kelley <mikelley@microsoft.com>,
        Peter Keresztes Schmidt <peter@keresztesschmidt.de>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>
Subject: Re: [patch V3 12/60] x86/of: Fix the APIC address registration
In-Reply-To: <973ae60f-15cd-19a3-7314-d165696b833c@intel.com>
References: <20230801103042.936020332@linutronix.de>
 <20230801103815.818545643@linutronix.de>
 <973ae60f-15cd-19a3-7314-d165696b833c@intel.com>
Date:   Fri, 04 Aug 2023 01:35:11 +0200
Message-ID: <87r0oj1yz4.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Thu, Aug 03 2023 at 15:42, Dave Hansen wrote:
> On 8/1/23 03:46, Thomas Gleixner wrote:
>> The device tree APIC parser tries to force enable the local APIC when it is
>> not set in CPUID. apic_force_enable() registers the boot CPU apic on
>> success.
>
> I went looking for how this registration happens.  I was expecting to
> see something apic_force_enable() do something similar to
> register_lapic_address().
>
> But the apic_force_enable()=>apic_verify() call chain is pretty shallow
> and I'm not seeing a lot of overlap.

apic_verify() ends up invoking register_lapic_address() on success, no?