Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp2949489rwo; Thu, 3 Aug 2023 18:43:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGY5vDA6WheHTLKhaqtxZHCOMp9zbO27GMQP0NfCPvFLe2WXZasnSGcZHGWmhKSHZz3B0nC X-Received: by 2002:a05:6512:2827:b0:4fb:8bad:1cdf with SMTP id cf39-20020a056512282700b004fb8bad1cdfmr225000lfb.42.1691113417442; Thu, 03 Aug 2023 18:43:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691113417; cv=none; d=google.com; s=arc-20160816; b=0mWPFnmdZoO94+frM5vwoZLuMv/coG4MUfqoeoRNMA9Ug+wLS+VEosVRXKSvjQRaW7 3XJEO6dhxZwsPzHLYqMG8QxOii5j4otMjnH5olnxUIucG/GCF0PliR6jPVTFrt99JzHR NLH5Q9vUr4M9+mJ+UWfAXhKZfcA7GNIDAnz/f/ME2Xyqx9+/aa1Uf9d0lcBPWawS/a5v 3T1uUclDz4wjELsC+OqpfXOSH2+hf/4bQ44lziXRhKU3kiaiLYIh7jgjXX3ypcuN+xmQ ruCeEEWlJlIjwQ4OyPiwN/Ggv0idqGBUnnYSIxbyH6shxeNYnzzyIOmQJq6VgB67/hA2 RhYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=OsyeFWl8mwP3VjEIYZRy5Nm+Y7MYMjXm36Xs7CwxFNM=; fh=xlT3WZn60kz9NtMtR73gNL3DqkvY+cgh2bzE0dC7z6Y=; b=D/1tfMrvvR3jbSufIjGc+pRJ9It0z038vnaZXqWKv55AxzvJWpcnC4at9ahlbpXlYv 7x7n7sYk55/oYc2QLhTvYXCDh1nOmBuXoW2ZvacmIZwRsTb+bMCpN7SBmVF7SELU0Tk+ JynGBlkhHTI88quKmB0xqBG/NL1vxLbCreiY71A1pt9vwa4KdQqxzD4N84Wk5f88GEQk L0sk67L4IU0VPVwMZe1blr9vbItE4oCh5+KVt5zf98etBLNMmXsUrONlGrgBVHrCL5fv KhrUAJpDwY6FoHxFth2836U0eYeRlaLacbkPFFIdOPefozw/iC+j6ZpLsDYiOGAkzQ4z VocA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=m5xBf9GI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b20-20020a056402139400b0051e2a1744f3si743441edv.26.2023.08.03.18.43.12; Thu, 03 Aug 2023 18:43:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=m5xBf9GI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231496AbjHDBV2 (ORCPT + 99 others); Thu, 3 Aug 2023 21:21:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbjHDBVZ (ORCPT ); Thu, 3 Aug 2023 21:21:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 526A9420A for ; Thu, 3 Aug 2023 18:21:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E267261EE2 for ; Fri, 4 Aug 2023 01:21:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4599C433C8; Fri, 4 Aug 2023 01:21:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691112083; bh=5orjVrOpDSU7lC6XWYb50yRi3CyLxe0uhFWTNPZ+CRY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=m5xBf9GI8DX3y/fuXlCBtDK7cRcob9oC8Nz1sKXUNYSwMPCiymCrXi011oT3l6X7E evYGDzSyATBaYUJ2X5VeLV++MpTgO6qE35b7x/mBrxrnUGI+O7R/Q686iwiDlpOMgO auxX8vIb+KjPjtjY2giFU2+uxsPCpkA0kOiCF/fAh7xaG8JLra2ufaFS4AibNzYQch XjtUrmJlPIA7lSDaGgxujKvP+C29ywGsY48NePl/yKiCrbI0CtFvZ98AAoFZL/Xpdi mDgswrsF5MHBJNFNg3Nnics9Hj4yptqC/tjydyXI0738RIAj9zvBtpEjFmjEzZ95jn Z6d4XEpuDHiww== Date: Thu, 3 Aug 2023 18:21:21 -0700 From: Jakub Kicinski To: Alexander Lobakin Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Maciej Fijalkowski , Larysa Zaremba , Yunsheng Lin , Alexander Duyck , Jesper Dangaard Brouer , Ilias Apalodimas , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3 0/6] page_pool: a couple of assorted optimizations Message-ID: <20230803182121.1baf4c13@kernel.org> In-Reply-To: <20230803182038.2646541-1-aleksander.lobakin@intel.com> References: <20230803182038.2646541-1-aleksander.lobakin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 Aug 2023 20:20:32 +0200 Alexander Lobakin wrote: > That initially was a spin-off of the IAVF PP series[0], but has grown > (and shrunk) since then a bunch. In fact, it consists of three > semi-independent blocks: > > * #1-2: Compile-time optimization. Split page_pool.h into 2 headers to > not overbloat the consumers not needing complex inline helpers and > then stop including it in skbuff.h at all. The first patch is also > prereq for the whole series. > * #3: Improve cacheline locality for users of the Page Pool frag API. > * #4-6: Use direct cache recycling more aggressively, when it is safe > obviously. In addition, make sure nobody wants to use Page Pool API > with disabled interrupts. > > Patches #1 and #5 are authored by Yunsheng and Jakub respectively, with > small modifications from my side as per ML discussions. > For the perf numbers for #3-6, please see individual commit messages. Our scheming didn't help much, the series also conflicts with the net/xdp.h includes which came in via bpf-next :( -- pw-bot: cr