Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2c123597-e8bd-a0a0-cfb1-2236aa035870@linux.alibaba.com>
Date:   Fri, 4 Aug 2023 09:23:06 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.13.0
Subject: Re: [PATCH] fs: ocfs2: namei: Check return value of ocfs2_add_entry()
Content-Language: en-US
To:     Artem Chernyshev <artem.chernyshev@red-soft.ru>,
        Joel Becker <jlbec@evilplan.org>,
        Mark Fasheh <mark@fasheh.com>, akpm <akpm@linux-foundation.org>
Cc:     Kurt Hackel <kurt.hackel@oracle.com>, ocfs2-devel@lists.linux.dev,
        linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
References: <20230803145417.177649-1-artem.chernyshev@red-soft.ru>
From:   Joseph Qi <joseph.qi@linux.alibaba.com>
In-Reply-To: <20230803145417.177649-1-artem.chernyshev@red-soft.ru>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/3/23 10:54 PM, Artem Chernyshev wrote:
> Process result of ocfs2_add_entry() in case we have an error
> value.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: ccd979bdbce9 ("[PATCH] OCFS2: The Second Oracle Cluster Filesystem")
> Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru>

Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>

> ---
>  fs/ocfs2/namei.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
> index 17c52225b87d..03bccfd183f3 100644
> --- a/fs/ocfs2/namei.c
> +++ b/fs/ocfs2/namei.c
> @@ -1535,6 +1535,10 @@ static int ocfs2_rename(struct mnt_idmap *idmap,
>  		status = ocfs2_add_entry(handle, new_dentry, old_inode,
>  					 OCFS2_I(old_inode)->ip_blkno,
>  					 new_dir_bh, &target_insert);
> +		if (status < 0) {
> +			mlog_errno(status);
> +			goto bail;
> +		}
>  	}
>  
>  	old_inode->i_ctime = current_time(old_inode);