Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a4f3ed1e-2c95-06c4-8698-ed564c2b25b3@huawei.com>
Date:   Fri, 4 Aug 2023 09:14:59 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH v2 -next] misc: hi6421-spmi-pmic: Remove redundant
 dev_err()
Content-Language: en-US
To:     <arnd@arndb.de>, <gregkh@linuxfoundation.org>,
        <linux-kernel@vger.kernel.org>
References: <20230726180707.2486808-1-ruanjinjie@huawei.com>
From:   Ruan Jinjie <ruanjinjie@huawei.com>
In-Reply-To: <20230726180707.2486808-1-ruanjinjie@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Ping.

On 2023/7/27 2:07, Ruan Jinjie wrote:
> There is no need to call the dev_err() function directly to print a custom
> message when handling an error from the platform_get_irq() function as it
> is going to display an appropriate error message in case of a failure.
> 
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
> ---
> v2:
> - fix the coding style errors
> ---
>  drivers/misc/hi6421v600-irq.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/misc/hi6421v600-irq.c b/drivers/misc/hi6421v600-irq.c
> index caa3de37698b..b075d803a2c2 100644
> --- a/drivers/misc/hi6421v600-irq.c
> +++ b/drivers/misc/hi6421v600-irq.c
> @@ -244,10 +244,8 @@ static int hi6421v600_irq_probe(struct platform_device *pdev)
>  	pmic_pdev = container_of(pmic_dev, struct platform_device, dev);
>  
>  	priv->irq = platform_get_irq(pmic_pdev, 0);
> -	if (priv->irq < 0) {
> -		dev_err(dev, "Error %d when getting IRQs\n", priv->irq);
> +	if (priv->irq < 0)
>  		return priv->irq;
> -	}
>  
>  	platform_set_drvdata(pdev, priv);
>