Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp3062222rwo; Thu, 3 Aug 2023 21:27:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHCsGHBeRGfy6Fpf/CnVmnRrGQz3mbGYLaxaQeXiuPPE2fe06/JWP7j9xmINCb+phBKOvEb X-Received: by 2002:a05:6808:2201:b0:398:5d57:3d08 with SMTP id bd1-20020a056808220100b003985d573d08mr843920oib.37.1691123231346; Thu, 03 Aug 2023 21:27:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691123231; cv=none; d=google.com; s=arc-20160816; b=qE5mBCmqaHtn7pfscccXeIODf+Fo0lLNyv8mgvly4LlUK2rObfS4hQ3IReXkN+uI1f 32DSbvIcX9SRM62R9CddTPtPU75/13HoKJikXrvx6Zy95pYneC1d1Rni+ygUTgITMSlR mrK+d8c2LKyP19rUKvkGWOU7KlgctrqmFIK8Q14oq8p/sUQTwl/5hfpqLk7+YsUZ/MHH vjKh700Ed5APgU7uUWOGOCjJdpZPZw1lmD8qMozJajCOS2gEYgKDd1ScmTUNVxhV6ZsJ v2WnXO//nusLXcCE5kbmbsGIMllteOK3E0wMP32Tj4TI60CzMLTEUozpybKdtPfHPJBS o6aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=0lIq1SzvycNo8O70RxSGZGRIZpb7GcgRdLuEXjKlxAE=; fh=dGR0l8QE5Qs3efQ1/7kFtIYyzBmakQHB9U6D4UPeYWU=; b=srEU/HAN/LTDcT3f2P0SxXcroKSLPHl5pc5+BpBp19WIqjEMBR/S6zeOyviVWiwmr5 NpRNUqoCID5872Y9U4I3RIH0EEtOhuDzTEfopNOJ2h3fju3wflW6BpxNYwnsUPYyFnjH P0Qv/PcV0N0ouU6H69BELkiPxAaHWJfBqFTBYthDdYSu9kcJIG6OiuLCK3UVYT2KRmSN DasLSPocVTDuRvgVD/xSSOrYOwuJS2RlCP46g7L2i/TBVyP4/0HMvyHCGgFAZRWSlOgf ezcHFhQfq3BztUThkp5g/3WW32xLF610y5Sx++Usg/VMZC3asD9+r847G8QjuApxhH6S XQuw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t189-20020a6381c6000000b00553b783ad97si1196641pgd.228.2023.08.03.21.26.58; Thu, 03 Aug 2023 21:27:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231277AbjHDDZF (ORCPT + 99 others); Thu, 3 Aug 2023 23:25:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229618AbjHDDZE (ORCPT ); Thu, 3 Aug 2023 23:25:04 -0400 Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3A244210 for ; Thu, 3 Aug 2023 20:25:02 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RHB0q3ftjz4f3kp9 for ; Fri, 4 Aug 2023 11:24:59 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.103.91]) by APP2 (Coremail) with SMTP id Syh0CgAXvuuIb8xk3MnNPQ--.65152S4; Fri, 04 Aug 2023 11:25:00 +0800 (CST) From: yangyingliang@huaweicloud.com To: linux-kernel@vger.kernel.org Cc: tj@kernel.org, jiangshanlai@gmail.com, yangyingliang@huawei.com Subject: [PATCH -next resend] workqueue: use LIST_HEAD to initialize cull_list Date: Fri, 4 Aug 2023 11:22:15 +0800 Message-Id: <20230804032215.1168792-1-yangyingliang@huaweicloud.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: Syh0CgAXvuuIb8xk3MnNPQ--.65152S4 X-Coremail-Antispam: 1UD129KBjvJXoW7WryxKw43AFy8GF1UWFy5XFb_yoW8Jw4kpF 43G3yxGrWrXr4I9a45JFWvkrW7GF1kXa45KFs5Ca1Sgr17JFs5XF4qka43AFWrJrW8Wr1S vFyqgFsFyr4IvFUanT9S1TB71UUUUUDqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUyGb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6r1j6r18M7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUAVWUtwAv7VC2z280aVAFwI0_Gr0_Cr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JM4kE6xkIj40Ew7xC0wCF04k20xvY0x0EwIxG rwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4 vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IY x2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26c xKx2IYs7xG6rWUJVWrZr1UMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7Cj xVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU8xu4UUUUUU== X-CM-SenderInfo: 51dqw5xlqjzxhdqjqx5xdzvxpfor3voofrz/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,MAY_BE_FORGED, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang Use LIST_HEAD() to initialize cull_list instead of open-coding it. Signed-off-by: Yang Yingliang Reviewed-by: Lai Jiangshan --- kernel/workqueue.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 3ddd0d599dab..ae975a7c9f69 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -2307,9 +2307,8 @@ static void idle_worker_timeout(struct timer_list *t) static void idle_cull_fn(struct work_struct *work) { struct worker_pool *pool = container_of(work, struct worker_pool, idle_cull_work); - struct list_head cull_list; + LIST_HEAD(cull_list); - INIT_LIST_HEAD(&cull_list); /* * Grabbing wq_pool_attach_mutex here ensures an already-running worker * cannot proceed beyong worker_detach_from_pool() in its self-destruct @@ -3875,10 +3874,8 @@ static void rcu_free_pool(struct rcu_head *rcu) static void put_unbound_pool(struct worker_pool *pool) { DECLARE_COMPLETION_ONSTACK(detach_completion); - struct list_head cull_list; struct worker *worker; - - INIT_LIST_HEAD(&cull_list); + LIST_HEAD(cull_list); lockdep_assert_held(&wq_pool_mutex); -- 2.25.1