Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp3066963rwo; Thu, 3 Aug 2023 21:34:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHznSUmF+SAQXazeSxOVwJeO7L6rhfZq8ZZL+diBJExyYJ9/NlWMlza/Ujx4963SF7nxqKH X-Received: by 2002:a17:906:77dc:b0:99b:d374:efcb with SMTP id m28-20020a17090677dc00b0099bd374efcbmr648264ejn.26.1691123667106; Thu, 03 Aug 2023 21:34:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691123667; cv=none; d=google.com; s=arc-20160816; b=WEl87gO+UHJYCfMxEOCRvpmb2s54IIZrG+99PjCRJhP3823+6nQ8rL5kjT2Gi7a9JP Uc1JiDzkVacJ2riNHNKjdgGTWdEWfkPH5VjNWJKirEXTm1EiSc/XuGWqJULMN17RThd7 DolmPR2rHkoDztxpw/k36rnTEetedKJqezTobzZnHTPNsX1RJTV7tcd2SYAaazNqbjzM 5o7I2bDLNLRmlLJmJejDzKP95XwRDI/jGZJb3XBqVQLyFIRSN8GtLNqoIt+xQi5ETAZ9 dPPrvavExf1HjzNBCBw83rd0g01x4Y1lb/sTB7X7+WlWQ835UD/BUH+F9oo/sSfTtjNA dg5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:cc:user-agent:mime-version :date:message-id:dkim-signature; bh=V44zY6tTGV7isn6x8hv7Dk3DhRyCNxHpbJhH3wzaTxM=; fh=lUKVdYiTv5UZoEavPARWrYLGgaq0Tzj7zaAZH6YskUw=; b=tYV4Cy4TEQW8SNeMWUDamOXpPVZ1oK7J0O8mqP6zphNULJempYcbdKRu+wkcU3Cbxr AL+1mXiG+0h6NgSuRWMkYaGCzIfONK8A2CWOGBKZ/cQ6xilLs+4OwFbXSNIwaYstcaBu 7g0g5Hl+yaYnvMq42VyLgtiGrJvZVvm4MMnE+z4TVEUjl9SCZnUz5PPRSny3SlMlL6ha 51MQxXj/3RpCAcMB0ZnVo02OYLQhYYtXhbMGXYXwDLs3dd0CbgbQpMyR0cKB0zp6Ks/V QjZODBvkRKQ3yOY4jEqstDzNA0MSp6i5jBz9pT9ejR3aa+RL/L57vlzqTrOvQHSFGbfu CCqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=BHibTff8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bu8-20020a170906a14800b00987d26a0998si997050ejb.455.2023.08.03.21.34.02; Thu, 03 Aug 2023 21:34:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=BHibTff8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230481AbjHDC7c (ORCPT + 99 others); Thu, 3 Aug 2023 22:59:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232716AbjHDC73 (ORCPT ); Thu, 3 Aug 2023 22:59:29 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 631584220; Thu, 3 Aug 2023 19:59:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691117963; x=1722653963; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=YyNSAAHZUlGA/Nj8JDQMCImBLWmGgqOE3kwnXdtnCok=; b=BHibTff8qto2+0u8mV++5eT4kRgyhJJrUVfCWU+/6dE8mA0orlVmIPCq 86DH0lGnkhDgi1EAgCIwxXNH85r3FZ/EYPjwuIjArBRvGCmLt+kHI4no6 TTuXu8ONY2w+JlJ39jYSQ9VaWqw80baKYJg4+5UY65BuNTw43o9Vvluk5 tsT+YHH3mGeNc5oWAOFvn4ifQ5CdV6WIc3y/c2qn+/WexpOaGp4N2SRq3 1r1/7aM67sMOqKgc/uzfmcgDcLwQTIbF83ufhZBBzEYPlwfeoP4tactOr HnCuohL3Zy+a7TXPR0efPrDVrU8k/UJXLlEKp6CHLhRCgT0fvnd5lheVa Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10791"; a="373694109" X-IronPort-AV: E=Sophos;i="6.01,253,1684825200"; d="scan'208";a="373694109" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2023 19:59:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10791"; a="1060543668" X-IronPort-AV: E=Sophos;i="6.01,253,1684825200"; d="scan'208";a="1060543668" Received: from blu2-mobl.ccr.corp.intel.com (HELO [10.254.210.88]) ([10.254.210.88]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2023 19:59:02 -0700 Message-ID: Date: Fri, 4 Aug 2023 10:58:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: baolu.lu@linux.intel.com, "Liu, Yi L" , Jacob Pan , "iommu@lists.linux.dev" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 03/12] iommu: Remove unrecoverable fault data Content-Language: en-US To: "Tian, Kevin" , Joerg Roedel , Will Deacon , Robin Murphy , Jason Gunthorpe , Jean-Philippe Brucker , Nicolin Chen References: <20230727054837.147050-1-baolu.lu@linux.intel.com> <20230727054837.147050-4-baolu.lu@linux.intel.com> From: Baolu Lu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/8/3 15:54, Tian, Kevin wrote: >> From: Lu Baolu >> Sent: Thursday, July 27, 2023 1:48 PM >> >> struct iommu_fault { >> __u32 type; >> - __u32 padding; > this padding should be kept. > To keep above 64-bit aligned, right? I can't think of any other reason to keep it. Best regards, baolu