Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp3139113rwo; Thu, 3 Aug 2023 23:14:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHCNZ4Kj8gM0G6sgiuao/ThZWG6jzx3bdt/c2YmkC7WMFUGNhWkRBhd4kAqvwhhRNLSZcYx X-Received: by 2002:a17:90b:3ec9:b0:268:71e4:ec2a with SMTP id rm9-20020a17090b3ec900b0026871e4ec2amr787070pjb.48.1691129669600; Thu, 03 Aug 2023 23:14:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691129669; cv=none; d=google.com; s=arc-20160816; b=TFpfT4EUTw5rDelgIT2sz2w/tU0Pi/8JSIcQfEDzaaWF68rll+/Z2A/kUA+dPpljPJ 0oPf0CK1n7+y5XCXxkOARoEcVj1UtMGSJGsGcURDfStV1Jb1bpQoz19IS5VUS0+mFN6Y Jj6dVM11kAnW3RklIiEJjeHVh/NYpfbh/wVLl+XjkhWMQ8ZNycwvJIlyqGbh8kOB4BBY wE0Izz2AZwaVgVyWfXVEBHieMU5I+SG5p+xgc1kphv2c9PZyvbwqFBXQ5ja1/mBKUii0 GFOotpPvOvwJLOl9QnE1JZ5tvs2ASMW3ou2w4mIlHgf9tg3FrNxmce04uT7EzlodXdzA 1jqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:cc:user-agent:mime-version :date:message-id:dkim-signature; bh=xo8K6hWKQnrYXhOkSAzdtQ+cd1vAeFIP/6JA+BSZpPk=; fh=lUKVdYiTv5UZoEavPARWrYLGgaq0Tzj7zaAZH6YskUw=; b=jebVQpfncgo32CtkYCDzNTT5cuyK4p5hCX2nwSfC0Idpgvgp/0GumNTbgxlXsPQ1fv 9ZLcep5BXvdyeKkF6mGCEo4ylBaYA1uDYeluBsOgtc7d7mMU29N6Ml+EG8BbFR/XOcT1 h2T83xy+CCZs5ZJHGPFnIJF+9y0xmPy7UShMoys3ADumFAlygSWirfYMymdxZZOpYYR9 N3xlNCD+ZhscuZkoOpL1d1mhrexCbl9b3rlR0WF8teJKVe4k59iQcXpBMQV+v51mlTUn /gNU/YnJQfuG2lC8DlWZSyZErJAUP/nfC1NnxOabJRZrjFESHOt/mMtf2MWCHsFWcr1z uuXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=E4ToAElH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o19-20020a170902e29300b001b22c8d0dc5si1183654plc.437.2023.08.03.23.14.17; Thu, 03 Aug 2023 23:14:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=E4ToAElH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231474AbjHDFgp (ORCPT + 99 others); Fri, 4 Aug 2023 01:36:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232519AbjHDFga (ORCPT ); Fri, 4 Aug 2023 01:36:30 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 317EE2D7B; Thu, 3 Aug 2023 22:36:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691127378; x=1722663378; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=Nr2qXOc8VggqBic2CF/1tIEuRpxuNBYG4z12oSvPugc=; b=E4ToAElHT2FCMhjsmw+Mpv1kUXXcdMdrhiiJfzWZNVSGN2v3ee3wrYcr LRPHlKFPzVpYSdN5eC/oU5IY1OcCfIFDRlvisLyfRE2TpE8kntb8dc+Nl GcOD7feN7pxk/QDW/aGNJk7l72uC+wXrRBXEFucUsLdrVrFVeCNQ+yR36 aOncx/IoAB07uT823MZgW4ndoxgNhHBR4a9BFI2HxmOU762vBoplkajDF 9tecUKsrIiIYGmi8CQybyseqiOdx+vqxwuOBzg9raMc4KMR3Qaqv4/ys+ gtQAs2wCrxXn5eaxN2bPzfaPGRF2LRU4wJowVRCmLVQXZhT+t2a0tVyyy g==; X-IronPort-AV: E=McAfee;i="6600,9927,10791"; a="367533243" X-IronPort-AV: E=Sophos;i="6.01,254,1684825200"; d="scan'208";a="367533243" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2023 22:36:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10791"; a="764958786" X-IronPort-AV: E=Sophos;i="6.01,254,1684825200"; d="scan'208";a="764958786" Received: from allen-box.sh.intel.com (HELO [10.239.159.127]) ([10.239.159.127]) by orsmga001.jf.intel.com with ESMTP; 03 Aug 2023 22:36:14 -0700 Message-ID: Date: Fri, 4 Aug 2023 13:34:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: baolu.lu@linux.intel.com, "Liu, Yi L" , Jacob Pan , "iommu@lists.linux.dev" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 03/12] iommu: Remove unrecoverable fault data Content-Language: en-US To: "Tian, Kevin" , Joerg Roedel , Will Deacon , Robin Murphy , Jason Gunthorpe , Jean-Philippe Brucker , Nicolin Chen References: <20230727054837.147050-1-baolu.lu@linux.intel.com> <20230727054837.147050-4-baolu.lu@linux.intel.com> From: Baolu Lu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/4/23 11:51 AM, Tian, Kevin wrote: >> From: Baolu Lu >> Sent: Friday, August 4, 2023 10:59 AM >> >> On 2023/8/3 15:54, Tian, Kevin wrote: >>>> From: Lu Baolu >>>> Sent: Thursday, July 27, 2023 1:48 PM >>>> >>>> struct iommu_fault { >>>> __u32 type; >>>> - __u32 padding; >>> this padding should be kept. >>> >> >> To keep above 64-bit aligned, right? >> > > yes Okay, thanks! Best regards, baolu