Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp3198143rwo; Fri, 4 Aug 2023 00:30:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHHjLys64H9UdC4BWlEPCZ8rUWPWA0uk85txRXHcuOY9AAN1EQf4xGtZ98HVu/jBGgXIX/2 X-Received: by 2002:aa7:88c1:0:b0:682:537f:2cb8 with SMTP id k1-20020aa788c1000000b00682537f2cb8mr1359389pff.26.1691134252121; Fri, 04 Aug 2023 00:30:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691134252; cv=none; d=google.com; s=arc-20160816; b=KSXk5m33Op4fpAm0P4wlWo3sfVTN+bnOR2uiTMCbq2zjJkfxx7Yxy/KSKn6RcZm82v kqFW3V7q2QJDDFe2gBVjJIAr4ri+btUNGEI6oAu/h1zm4zn0wGYTkb55PYPluri+gtwF TjDPqi5TapFclRqXNWbbXkV96+G1UKKQhJdsDu4T/2/Oa9eBVr97qJ77D8elmgVzbvZ3 qtL0rFselb7ajt5W1eEeq83E4ljZi5JE8rcNlRHfuLFvlsHfsTfguewgRp53pQEOyawe FNF8fv3rL7m0Dn28+OELez86k7ty67kXg3oSm11lm0vnbHrsB7YSyqiL2lQPlYRfkeve fOWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=JG1Q9OauNeebaagBtNK55n2YFn3v8QXuP+2gpmP2Kbs=; fh=6Nf8iSUFIororGuJxj4Ix+FVD9R188YnzMLADH8Si84=; b=kH9ypz62EOVlJgv7hzEsS/b3uk74IqYCSDVsEBpuTwheI23nIrW7jL6VF9yubO9b8j u8h6/0n9qoe+QhtyQoyXrB88vmx13JKaF+/uZCCTQxWQlcOunF45cQSB7RlFRd4VUaoi t3wWx+zJ0l15NoLAcVhmC1sg/nJ3RfzQUzmhXBo4iabs/5ohbQtZQgk4KPsWeIU9ldkq Xx3KKzantcs6fO8B8r2wscQlvV6pKDAk77icThMaZ3G/zvNP37D9TwwLdLggAJ1RLFkm 7lXkrbyf0yfFUy3Lb1Ca2WYlVj0hWSyfH9z+V9fXLAuGWEkj64+vZMyKupjv7q1YHFgg 8VMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XCDa8Na8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n28-20020a634d5c000000b00563de19ff56si1388208pgl.427.2023.08.04.00.30.39; Fri, 04 Aug 2023 00:30:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XCDa8Na8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231951AbjHDGmF (ORCPT + 99 others); Fri, 4 Aug 2023 02:42:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229957AbjHDGmC (ORCPT ); Fri, 4 Aug 2023 02:42:02 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2473DB9; Thu, 3 Aug 2023 23:42:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691131321; x=1722667321; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=4U+QTqNDGYbI6jRbOUJiaCIaXtaMMqtOAzSKPCfKoXM=; b=XCDa8Na8gGmn8URc6jByCGj4M7SiaJYQWAjBEXqUOdYhwklDGwWS3wj1 +9NB6mOGkKlTR0wk5MllhHoOkFTLC5uCOQhPw6ALPaQUXikvD07t3u6iL df7E3mkLba9yxIgJZiJDt5xADg4+i+dvoObXus+Ql3Po+FN9GJDUZCxtl mJ1yF/cNYUKysEbvUgZBnyITH9yG6fsAZABDkohsQ7sbzyOehmQdX/d4j a3glAzJZx4/mGYrVRXkZ9AjNxm/EvIEtS13ftyPVNRO5ctcsdyARWSJKT Yqp+h+WPfPY83+SwnFdrWPursE71CpLhsWpj7zL5/dhoOsMGhzbA+hrZh Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10791"; a="349675780" X-IronPort-AV: E=Sophos;i="6.01,254,1684825200"; d="scan'208";a="349675780" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2023 23:40:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10791"; a="764970022" X-IronPort-AV: E=Sophos;i="6.01,254,1684825200"; d="scan'208";a="764970022" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP; 03 Aug 2023 23:40:50 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qRoUT-00E1B4-0b; Fri, 04 Aug 2023 09:40:49 +0300 Date: Fri, 4 Aug 2023 09:40:48 +0300 From: Andy Shevchenko To: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jiri Kosina , Benjamin Tissoires Subject: Re: [PATCH v1 00/12] HID: cp2112: Cleanups and refactorings Message-ID: References: <20230703185222.50554-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 27, 2023 at 09:43:29PM +0300, Andy Shevchenko wrote: > On Mon, Jul 03, 2023 at 09:52:10PM +0300, Andy Shevchenko wrote: > > After I updated GPIO library for the case Benjamin has with CP2112, > > I have a brief look into the CP2112 driver itself. > > > > From GPIO perspective it has two main (maitenance) issues: > > - usage of ->to_irq() with IRQ chip present; > > - having IRQ chip not immutable. > > > > Besides that there are plenty small cleanups here and there. > > Hence this series. > > Any comments on this? Gentle ping^2 for this... Anything should I do to improve it or is it okay to go as is? -- With Best Regards, Andy Shevchenko