Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6dbf9f37-e4bf-656d-4121-789e2e6cfae2@intel.com>
Date:   Fri, 4 Aug 2023 15:14:53 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH 0/2] don't use mapcount() to check large folio sharing
To:     Andrew Morton <akpm@linux-foundation.org>
CC:     <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
        <stable@vger.kernel.org>, <willy@infradead.org>,
        <vishal.moola@gmail.com>, <wangkefeng.wang@huawei.com>,
        <minchan@kernel.org>, <yuzhao@google.com>, <david@redhat.com>,
        <ryan.roberts@arm.com>, <shy828301@gmail.com>
References: <20230728161356.1784568-1-fengwei.yin@intel.com>
 <20230728102405.7b456eb87fb46042fbce5e4b@linux-foundation.org>
 <29cd58c4-08d3-c03c-7232-15f85878934d@intel.com>
Content-Language: en-US
From:   "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <29cd58c4-08d3-c03c-7232-15f85878934d@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OTJTcDNmcTNNdGZJWTFwMmhvR3J1Wk9OdHpuWTh5dHh4RGJkdVlmTFhsclVw?=
 =?utf-8?B?M2RFZEhZTTc4NGZMZEdCYmc5Q2dhemxucUhCVENrMnhkSVorMHZSNG1La0xk?=
 =?utf-8?B?YmI5bVZqZmRwdk5pcnpzWE11WXFEQXZzUmhmZ0JpMzk4MHVnaUdobWx0WU53?=
 =?utf-8?B?alk2VnJMMGhScnZNNWliZW05Y3M1d255R0x2cCtaZmZrTTdvMVQ1MTlNSlpz?=
 =?utf-8?B?c1hzd3RiaWpqWWxqRGU5M1grekFSSmkwUWlrKzgwQkVzaFh1RlRTYkRHZ2hj?=
 =?utf-8?B?NGFSOHlGZklOWDNzYk9rNkhSWVJ6RmVVL2JIUE1INzBWWTBqMzBiYlB4MnpR?=
 =?utf-8?B?MFJTZFdPTGFLSkFLbTE1S3hZZnBwM1hZYk1tOFpoUHJlNE5QWVdpMFRoTUFS?=
 =?utf-8?B?RzdFVWhDb1Zqc3lFSHJJUVE4SThRUndLVC9kTjUyNW5Dd05XL3dMdlp6Q2FP?=
 =?utf-8?B?K1dFbGlCM3hvRGl3RnU0TENKQVk1NktZNHZ2eGpWR0xvNmxpK1oyZ0x0YkJ6?=
 =?utf-8?B?SXlGeFc1dVdvRFI4SVNrcWpMZW4zWlpnYUZSN3Ura3pURkJjRUpCbVJBUFI5?=
 =?utf-8?B?d1U0ZFpHT01BYW5RMzVMSC9JcU4wMVN4YnZBLzRWc0RrMDhGbk1qNGFrbEtv?=
 =?utf-8?B?ZEpLalZpMHBBYTd2R095bWNyZzlZVWM1RVY0M2tOV2RDN3ZYc1FybmtuU3Iw?=
 =?utf-8?B?T1JucnZwZUlKTnFMRmNpNzZGbTJnVi9uNmRXa3BFRUlDZ0t1M1QwVEgxQ2wy?=
 =?utf-8?B?WUxEM2VMNDQxMTNtc0h2MHIwblFXKzJyMUVtMnhnenFoMkRVeEY4a3NEL0tL?=
 =?utf-8?B?Qzg2T3MxUFhQRUh5bXZTTFZQUVg5LzYzV0FqRHMyZmE4NjhxMTJTYzFRaEhV?=
 =?utf-8?B?bStoa2cvVkQvWTZLdzFTM0o5Uk9hTE9GL3lna1k3K3VycEZXUXVNbEdyZnBP?=
 =?utf-8?B?c0J6ak5kTW9ZazFLTTRvUXVsUFpBR2I1U2V4TzZLM3dGajhZUDBybmg1bysr?=
 =?utf-8?B?bVJvV3g0V1pvd1gyYmxEYmYzKzBVS3E3WWV0T21WWXBmYitRRTNRc0NmWGtE?=
 =?utf-8?B?SWVob3A5eWkzTmo5Zk8vbkRwVFFFdVE5QUh5NDNhOVlEMkxPOE4rbmZXRDFm?=
 =?utf-8?B?TGZQdENwdW52ZTNiM0tPRlNOWFpjOXg0RWhtWHNVK20zTk9QdDRyQ2E1ZVdm?=
 =?utf-8?B?N2x4OWpRZThza01WTVVWOE4wdlR6RUIwMldKbGtaakwrbVkrK0tyb1lCL3Z0?=
 =?utf-8?B?WTh4SERGcXNrZW1WRVpoajRpaCtncXMwNk5pcGt3ZjdqdWxtSW9ZTmw1U1RO?=
 =?utf-8?B?dEk0VDNZdC9oR0xYOU5BcGtQcmhMbFJzOE9pOExiQmgwRnlJdnV6RzZSWFBn?=
 =?utf-8?B?ZkwyMk95a2ZidXR5dUNYU25OV0RUcnFhaHR3aWova2pFa2pNYURHQXRoN1NG?=
 =?utf-8?B?ZlhYWnJ5S1VjWHNjS1kyemVzWVdGbXZubUNETVhOeHJwZjJkczMxcTZ1UGEw?=
 =?utf-8?B?NVpDdElmeE54eDNnZzVuc1dkTUNUT2tZOVNvdWdxMjJsOVRBZk5HZGJkWHdy?=
 =?utf-8?B?bkNmV0lpaHc0anlYTDJINEFpLzFxODdjTnhWSnh3d0hSVXNjSS9oR1U3K1VY?=
 =?utf-8?B?ZHU2RXhWL0FQS3JWbjd5L1g3V3RIeTFqTXJVZHJYcG1DdDNMSXNtenJkVFBN?=
 =?utf-8?B?RkZSVWNLOXNjVXNjMUVwVUM5c3VpbC8xdVlQU1AwSE45UCs5Q3NnWWNlRjU0?=
 =?utf-8?B?YTZjMzFiTC9zWnpFa1VndmRjTXBnN1ZQcHVHdlBVK01OMnloMXNYU2R1VWU3?=
 =?utf-8?B?MjdXNmkxYlhmRFFLZ2pQc3Q5SkNzcDFkeER1N0pzMTBrNEErTmc0bUtBQXUr?=
 =?utf-8?B?K1Q2WkNvcXJKaGtkN3NCNy8vQlZpM0dlMERqKzVjQkkwR2dqMnVJWS9TclNQ?=
 =?utf-8?B?QmpNbk1ONnJZT0hqcFBWT29JdHY5dnFFQklNK3hVbjNiTjZBZXp5UVhDVkRX?=
 =?utf-8?B?TXZsTkUxeTVuM3RGeDgyYmg2N3BGeFpJSkcxVjU5ZTVtTVhTWGpEOFdIanFN?=
 =?utf-8?B?cFYzeTU0RGlobjVGNFBRRVBqdThLTDYxYmYyd1JzbjhsaStwQ3VneXVzVmly?=
 =?utf-8?Q?Q93MwMLBTxv2AH2z9mqe+9Qc2?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b6d75eaa-3808-44c8-6e05-08db94ba872f
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 07:15:05.8819
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8Nsdj86dHZUcicf7j0qU+Njv3VbADgKXFktE7yAE3xKMsgmQliXMju3KG3Y6K3uh8XGGAJRWmZ9wSjENb75mUw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7035
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andrew,

On 8/2/2023 8:39 PM, Yin, Fengwei wrote:
> Hi Andrew,
> 
> On 7/29/2023 1:24 AM, Andrew Morton wrote:
>> On Sat, 29 Jul 2023 00:13:54 +0800 Yin Fengwei <fengwei.yin@intel.com> wrote:
>>
>>> In madvise_cold_or_pageout_pte_range() and madvise_free_pte_range(),
>>> folio_mapcount() is used to check whether the folio is shared. But it's
>>> not correct as folio_mapcount() returns total mapcount of large folio.
>>>
>>> Use folio_estimated_sharers() here as the estimated number is enough.
>>
>> What are the user-visible runtime effects of these changes?
>>
>> (and please try to avoid using the same Subject: for different patches)
>>
> 
> Can you hold on these patches to mm-unstable? I think we need to wait for
> David's work on folio_maybe_mapped_shared() and redo the fix base on that.
> Thanks and sorry for the noise.
Sorry for bothering you again for this patchset.

Let me explain the situation here:
  - The reason to hold on the patches to mm-unstable is that I don't want to
    promote the fix in this patch (using folio_estimated_sharers()). The
    correct way is waiting for folio_maybe_mapped_shared() from David.

    Merging these patches motivate using folio_estimated_sharers() in other
    places. So once folio_maybe_mapped_shared() is ready, we need to replace
    folio_estimated_sharers() with folio_maybe_mapped_shared().

  - For this specific patches, if they are suitable for stable, we may want to
    merge it (special for stable branch. I assume folio_maybe_mapped_shared()
    may not be back ported to stable branch).

So how do we deal with this situation? Thanks in advance.

Regards
Yin, Fengwei

> 
> 
> Regards
> Yin, Fengwei