Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 4 Aug 2023 16:43:12 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     Yang Weijiang <weijiang.yang@intel.com>
CC:     <seanjc@google.com>, <pbonzini@redhat.com>, <peterz@infradead.org>,
        <john.allen@amd.com>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <rick.p.edgecombe@intel.com>,
        <binbin.wu@linux.intel.com>
Subject: Re: [PATCH v5 15/19] KVM:x86: Optimize CET supervisor SSP save/reload
Message-ID: <ZMy6INjzYiVqOKEy@chao-email>
References: <20230803042732.88515-1-weijiang.yang@intel.com>
 <20230803042732.88515-16-weijiang.yang@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230803042732.88515-16-weijiang.yang@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?259gZQhB1Mw0fJe6eVCw6GVFQ6ZuPX0bsHIYkMUGzs1CebFMFE5F84CYbloy?=
 =?us-ascii?Q?wz0z0sSU3PNtB0I6cO2DekhHGcUzX9GcuJhwHD+/X7YYfVhgzKwEviyrQBGn?=
 =?us-ascii?Q?b9aivmwKzRDH/CtBgbq0AVzJzIhT9ZRtbPSl9lpmOODKnYO/m+x+deoaDrwN?=
 =?us-ascii?Q?YxvmQ6eK8UQS9AZHUiOddj/9LitCCcXCDJLN26/pkP57uSSjm+PXttIktZE3?=
 =?us-ascii?Q?4jgBeQSYm3KBXmX4MT0PBo4kNVprxnlsTEcYsO0f4YEkVtCRhdM9Y/7E+1/s?=
 =?us-ascii?Q?roLKnCdxAwEdX/kT4w5TpP7e0iK8C/vq27a/J0qH746VlR8Gww8zx82zONz3?=
 =?us-ascii?Q?Bt3OvjSpnDAcB/PJzKVGP0eRFEzCA4PA+NlA7/jYtLczcWD4Ri3vLmvTnCxe?=
 =?us-ascii?Q?Nar/gtIbSgLc7H5nDjyVa4WJbmV2XWQuDWJ0XxLASHfRDTAIKQt1xER2v+8A?=
 =?us-ascii?Q?Rjkz9PwL2+lrIVxithJ+bwpRWMjaBX0SaORrO8UbWAOUS7+fck4Yy/4g8CAD?=
 =?us-ascii?Q?H9l6jZ07WUHk2gRDeee3UKoq2dm3A8Ak+gyBPoollxysx5Ih/SwiGzcq5oPu?=
 =?us-ascii?Q?CeIkOMy/ijlYw0d7fc/vMjUjhuPeY8egk47mbXWfOQuFYuJhyy/R9W6VPnBP?=
 =?us-ascii?Q?9FZIHz0W7pFE/xAf20we++dhZMcRX/63xf+KCHLQLOekq9imxtw7aoVSmu/A?=
 =?us-ascii?Q?RR696zud87Ci0zoQsh7f3OCOT/j/bpndc666GqOcyZ6o6xM0JXk8Bw+GDaLS?=
 =?us-ascii?Q?82qjaDHE2s6FNxR4bCADkyRRHiLvMxqwhxduNbTEQygR8TnnwBsh2Gngxhn/?=
 =?us-ascii?Q?RJFtLJ/j7XVmMcYby6mGfkQXCkGRRHGnB0YQQxATRYFVHOcDlrtxPYAC9S4m?=
 =?us-ascii?Q?iawNij06nr2f7apzdkXx0Gs1fjj8xiLPyaxwE5LjJowYaLBODNAQTKtrWvvh?=
 =?us-ascii?Q?HaICpC2ne6wp80S40IS3xzz8P+STH1IyxmScPjJ6xjXp2nPRLDW35jl3Y13A?=
 =?us-ascii?Q?viEsTYcCMfRSdFBoFDtMzCpf7tap8fnnXUILNz26CbGqwno4Ir02dlVk4XHr?=
 =?us-ascii?Q?/F2XCHPMYECqWCYV9fucilkTB3+efXSjNjF3aDUhbiILBh0SwdPCdI85os9r?=
 =?us-ascii?Q?UA4xMlU0gBShlw5Wiz666xLN226WXniCC+B1Z0NVVhxR5dAp8TFfCV54lTQ9?=
 =?us-ascii?Q?ys1CnXLt5AcfCbnUv6WFlqWn/V09uX05EpdM/RKP/syjjg5j0GztN8Y8ghkG?=
 =?us-ascii?Q?QtSYamp+NstWSIB+cGyGQnhZaQur/09UQhugWdcIOfCfk3yK5Dtf78XE2FLi?=
 =?us-ascii?Q?/oNGnI+ATk9GXtE+DKEKYIH/5TBbdfOLnSFGSPQe2U4Fr1HTkARR+JT/8PRA?=
 =?us-ascii?Q?6kmsIjSlELueiw5EqhilD3XCG0HYFFKMs8W42N0Agz7PB+US7LK3KqlfcsXE?=
 =?us-ascii?Q?nwT87WKqT6EO9ysBcTihJwdWcC4Pehi64JSD07hjht9BwEGNKrPUlfN/RFcM?=
 =?us-ascii?Q?PD85PHifOyJv4/lMPuY6DZRrDc2yljl63i41PNKHYXjDv94H5AMuqxpll2u5?=
 =?us-ascii?Q?Srxuk+902N9Q30qzpDs1wN1tfCs0R6eHntJfc5yk?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ba4fd198-b800-46d2-0379-08db94c6dbe5
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6780.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 08:43:22.0989
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m8aXUXGGfUXkzpArmp0PvokpvVQchTItziiNoyeWnCQB/ACslJ4jVYAECCkG6xYMGM0f4+Y26b+JHvR4Q6qgyQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4993
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 03, 2023 at 12:27:28AM -0400, Yang Weijiang wrote:
>Make PL{0,1,2}_SSP as write-intercepted to detect whether
>guest is using these MSRs. Disable intercept to the MSRs
>if they're written with non-zero values. KVM does save/
>reload for the MSRs only if they're used by guest.

What would happen if guest tries to use XRSTORS to load S_CET state from a
xsave area without any writes to the PL0-2_SSP (i.e., at that point, writes to
the MSRs are still intercepted)?

>@@ -2420,6 +2432,14 @@ static int vmx_set_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
> 		else
> 			vmx->pt_desc.guest.addr_a[index / 2] = data;
> 		break;
>+	case MSR_IA32_PL0_SSP ... MSR_IA32_PL2_SSP:
>+		if (kvm_set_msr_common(vcpu, msr_info))
>+			return 1;
>+		if (data) {
>+			vmx_disable_write_intercept_sss_msr(vcpu);
>+			wrmsrl(msr_index, data);

Is it necessary to do the wrmsl()?
looks the next kvm_x86_prepare_switch_to_guest() will load PL0-2_SSP from the
caching values.