Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230804030140.21395-1-rdunlap@infradead.org> <ZMyq9e/On2wzSJWj@qwark.sigxcpu.org>
In-Reply-To: <ZMyq9e/On2wzSJWj@qwark.sigxcpu.org>
From:   Aleksandr Nogikh <nogikh@google.com>
Date:   Fri, 4 Aug 2023 11:35:25 +0200
Message-ID: <CANp29Y6AnNeouWgAevBEDZcYcOjzDQwxLDfLxe41Lp3BC=h8bA@mail.gmail.com>
Subject: Re: [PATCH] drm: bridge: for GENERIC_PHY_MIPI_DPHY also select GENERIC_PHY
To:     =?UTF-8?Q?Guido_G=C3=BCnther?= <agx@sigxcpu.org>
Cc:     Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org,
        Adam Ford <aford173@gmail.com>,
        Maxime Ripard <maxime.ripard@bootlin.com>,
        Robert Chiras <robert.chiras@nxp.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Robert Foss <rfoss@kernel.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Thank you for resolving this issue so quickly!

I've applied the patch locally and gone through the reproduction
steps. The kernel builds fine now.

Tested-by: Aleksandr Nogikh <nogikh@google.com>

On Fri, Aug 4, 2023 at 9:38=E2=80=AFAM Guido G=C3=BCnther <agx@sigxcpu.org>=
 wrote:
>
> Hi,
> On Thu, Aug 03, 2023 at 08:01:37PM -0700, Randy Dunlap wrote:
> > Three DRM bridge drivers select GENERIC_PHY_MIPI_DPHY when GENERIC_PHY
> > might not be set.  This causes Kconfig warnings and a build error.
> >
> > WARNING: unmet direct dependencies detected for GENERIC_PHY_MIPI_DPHY
> >   Depends on [n]: GENERIC_PHY [=3Dn]
> >   Selected by [y]:
> >   - DRM_NWL_MIPI_DSI [=3Dy] && DRM_BRIDGE [=3Dy] && DRM [=3Dy] && COMMO=
N_CLK [=3Dy] && OF [=3Dy] && HAS_IOMEM [=3Dy]
> >   - DRM_SAMSUNG_DSIM [=3Dy] && DRM [=3Dy] && DRM_BRIDGE [=3Dy] && COMMO=
N_CLK [=3Dy] && OF [=3Dy] && HAS_IOMEM [=3Dy]
> >
> > (drm/bridge/cadence/Kconfig was found by inspection.)
> >
> > aarch64-linux-ld: drivers/gpu/drm/bridge/samsung-dsim.o: in function `s=
amsung_dsim_set_phy_ctrl':
> > drivers/gpu/drm/bridge/samsung-dsim.c:731: undefined reference to `phy_=
mipi_dphy_get_default_config_for_hsclk'
> >
> > Prevent these warnings and build error by also selecting GENERIC_PHY
> n> whenever selecting GENERIC_PHY_MIPI_DPHY.
> >
> > Fixes: fced5a364dee ("drm/bridge: cdns: Convert to phy framework")
> > Fixes: 44cfc6233447 ("drm/bridge: Add NWL MIPI DSI host controller supp=
ort")
> > Fixes: 171b3b1e0f8b ("drm: bridge: samsung-dsim: Select GENERIC_PHY_MIP=
I_DPHY")
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Reported-by: Aleksandr Nogikh <nogikh@google.com>
> > Link: lore.kernel.org/r/20230803144227.2187749-1-nogikh@google.com
> > Cc: Adam Ford <aford173@gmail.com>
> > Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> > Cc: Guido G=C3=BCnther <agx@sigxcpu.org>
> > Cc: Robert Chiras <robert.chiras@nxp.com>
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> > Cc: Neil Armstrong <neil.armstrong@linaro.org>
> > Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> > Cc: Robert Foss <rfoss@kernel.org>
> > Cc: David Airlie <airlied@gmail.com>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: dri-devel@lists.freedesktop.org
> > ---
> >  drivers/gpu/drm/bridge/Kconfig         |    2 ++
> >  drivers/gpu/drm/bridge/cadence/Kconfig |    1 +
> >  2 files changed, 3 insertions(+)
> >
> > diff -- a/drivers/gpu/drm/bridge/cadence/Kconfig b/drivers/gpu/drm/brid=
ge/cadence/Kconfig
> > --- a/drivers/gpu/drm/bridge/cadence/Kconfig
> > +++ b/drivers/gpu/drm/bridge/cadence/Kconfig
> > @@ -4,6 +4,7 @@ config DRM_CDNS_DSI
> >       select DRM_KMS_HELPER
> >       select DRM_MIPI_DSI
> >       select DRM_PANEL_BRIDGE
> > +     select GENERIC_PHY
> >       select GENERIC_PHY_MIPI_DPHY
> >       depends on OF
> >       help
> > diff -- a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconf=
ig
> > --- a/drivers/gpu/drm/bridge/Kconfig
> > +++ b/drivers/gpu/drm/bridge/Kconfig
> > @@ -181,6 +181,7 @@ config DRM_NWL_MIPI_DSI
> >       select DRM_KMS_HELPER
> >       select DRM_MIPI_DSI
> >       select DRM_PANEL_BRIDGE
> > +     select GENERIC_PHY
> >       select GENERIC_PHY_MIPI_DPHY
> >       select MFD_SYSCON
> >       select MULTIPLEXER
> > @@ -227,6 +228,7 @@ config DRM_SAMSUNG_DSIM
> >       select DRM_KMS_HELPER
> >       select DRM_MIPI_DSI
> >       select DRM_PANEL_BRIDGE
> > +     select GENERIC_PHY
> >       select GENERIC_PHY_MIPI_DPHY
> >       help
> >         The Samsung MIPI DSIM bridge controller driver.
> >
>
> For NWL:
>
> Reviewed-by: Guido G=C3=BCnther <agx@sigxcpu.org>
>
> Cheers,
>   -- Guido