Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp3355373rwo; Fri, 4 Aug 2023 03:45:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHx7UW4LqrT/ofd6PYjQz6BcPBdDljSXdxxEu4hgfLgHRbUC5LxuZ7qeGNeN7sDaXiDBPII X-Received: by 2002:a17:906:519c:b0:99c:a23b:b4f4 with SMTP id y28-20020a170906519c00b0099ca23bb4f4mr993060ejk.2.1691145946650; Fri, 04 Aug 2023 03:45:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691145946; cv=none; d=google.com; s=arc-20160816; b=A8OU7WGiXCrT6p7Y0EsIvmEfd8xoUXWn+uNqPddGEBG+xoAJtriP5Ng44UeFo9q1bn A5DIJRxnk6v7BvJv4cR56oG0VNoKYsW74Kt9Y7AUiKAE2cAr7RxphbjUtG4s67CiIIHA hA8tdeSnb8Wnuf7RErDvZyRzCuvQoEjI3867SaJsbn4BNbk29xPSAp4axfcqewsiiuJW KvoSG2gunFOjElDMFBhppsITTRZeFuTZ3NnwET6YNiycIL8NzHM1fBlJu0Sv9NoomjMF g55xmv/WxV78ubHsrV1rG1+CXoqKQ4jCK2Zd/k/V8P4ZMc/XQEHgS1GR8mibRZARUkQ5 WSNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:cc:user-agent:mime-version :date:message-id:dkim-signature; bh=j3OR/7vEr8y1ObqaMdbWPmWiWmoOPdx7NSDdlfclzJA=; fh=zMA804cxif9uNZB0Lqy0RQ6dp29AMP2DLA7xm++tpZA=; b=oj0IluQt1dCQXRi38MbUKWssMLNg2iW24K3LcR/PFMXxkxgWTwcTBWnDYiUpT2UumY +PwhHKMP6Z5tzqk/yhc9u8sP+o4cafR3pzzkHEgIZWPt153eBpzGvjSQ2f9tRvx2NoiQ Q/PX3zvkQd/8MyuCzfrWSGZ0gUtR3rFek5aoTqc7V1QTTIJycAxlRKZ+ddv8hBUcyvDL LCNCVOywh2hPVj5RNeofOP6+vGtIgiyAYQx8qjRRVfvk1c2oPcHOyR+w2Mxq145maF15 hgc0DUxDjDNeRHwge8r7XWnBZzwf/DM33CnKwHDOnsN+Z8Z+wkVIo6P87cMEU7ZZqLez BrJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="HlF/5mCQ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qh12-20020a170906ecac00b0099318060d50si1365429ejb.463.2023.08.04.03.45.19; Fri, 04 Aug 2023 03:45:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="HlF/5mCQ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231219AbjHDKbA (ORCPT + 99 others); Fri, 4 Aug 2023 06:31:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230086AbjHDKa7 (ORCPT ); Fri, 4 Aug 2023 06:30:59 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FFCA2118 for ; Fri, 4 Aug 2023 03:30:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 99D4C61F91 for ; Fri, 4 Aug 2023 10:30:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50467C433C8; Fri, 4 Aug 2023 10:30:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691145057; bh=LisFYqrHrFx436SkEAziF8A92P7uY+qSA0OgMAPh/Bk=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=HlF/5mCQOEUrJx14dljhhBCHpirfYCLy6M1w9mj7gncmtLrJMYh0vwf244TKRZ/Gq zg6N/uEGVqdVBMSk0A/GsF+n8MlwudcVTwpvddOyOTUSeObVPquDd7cA5Q2QMuocoU Ly1J9cw/xJkm9wQGDkl5yTC6FsXOC4AD1CY91C7LE8/dYn9/+hpygf0tAUEDSfqfQg ozBRkyYXD4xPyCAIgaVHojJ+NyZ9QJwvnVgScvDp+L1cNo0d5T8WbWDQtUANXxzDuH qkMp/zBzq5KMl2puFlB//tIEVKF+C2bkIMsd11AeN43zF312M32FHnu7RHeHQI06hN z5fVyS/iZQ0Cg== Message-ID: Date: Fri, 4 Aug 2023 12:30:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: Maciej Fijalkowski , Larysa Zaremba , Yunsheng Lin , Alexander Duyck , Jesper Dangaard Brouer , Ilias Apalodimas , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3 5/6] page_pool: add a lockdep check for recycling in hardirq Content-Language: en-US To: Alexander Lobakin , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni References: <20230803182038.2646541-1-aleksander.lobakin@intel.com> <20230803182038.2646541-6-aleksander.lobakin@intel.com> From: Jesper Dangaard Brouer In-Reply-To: <20230803182038.2646541-6-aleksander.lobakin@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/08/2023 20.20, Alexander Lobakin wrote: > From: Jakub Kicinski > > Page pool use in hardirq is prohibited, add debug checks > to catch misuses. IIRC we previously discussed using > DEBUG_NET_WARN_ON_ONCE() for this, but there were concerns > that people will have DEBUG_NET enabled in perf testing. > I don't think anyone enables lockdep in perf testing, > so use lockdep to avoid pushback and arguing :) > > Signed-off-by: Jakub Kicinski > Signed-off-by: Alexander Lobakin I like this. Acked-by: Jesper Dangaard Brouer