Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Chao Yu <chao@kernel.org>
CC:     "jaegeuk@kernel.org" <jaegeuk@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-f2fs-devel@lists.sourceforge.net" 
        <linux-f2fs-devel@lists.sourceforge.net>,
        Damien Le Moal <Damien.LeMoal@wdc.com>
Subject: Re: [f2fs-dev] [PATCH] f2fs: clean up w/ sbi->log_sectors_per_block
Thread-Topic: [f2fs-dev] [PATCH] f2fs: clean up w/ sbi->log_sectors_per_block
Thread-Index: AQHZxrgf6qH53kn8JkyhsDXhIB6WQw==
Date:   Fri, 4 Aug 2023 09:43:29 +0000
Message-ID: <fafcfeosil5yqwn2wcdx33im2mq4xkejw6bx7h2in3ay5h6znj@facx4rrg4p65>
References: <20230523123521.67656-1-chao@kernel.org>
In-Reply-To: <20230523123521.67656-1-chao@kernel.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?djvawz61gVFzjEnnXl6JQ+8FTftpY3KIBtYOiJkDq4A9cBcI/fi4t/qgq7Dd?=
 =?us-ascii?Q?XlBkBdns7rexfAFLmY/Nv4KNsrU38cp8IjZXqiU59x8VgezJJ92BTL8hyYJu?=
 =?us-ascii?Q?P8w2w4mccLHXJK/cWTJ4dP+xlu71mZSeMzi94A8Lxg+v8f66diirtunbeIMg?=
 =?us-ascii?Q?wIZDzzjZUqdZEg7WM4SD2XMV1/rEuTSPHev5VLeo1iO+Gcqwkyk9vauW4/wh?=
 =?us-ascii?Q?bzfh9C1UZrOChp6ykP1Qv6GKCnqeHn2Kv/QFMGTB6cNb3EovtIYKrZKs8+i5?=
 =?us-ascii?Q?Qccz5zUu931vRh3aFYJ/XjZ+UlTHFmrS8Mpa3h+lbNnbDZUebYCA/ZK0wnKS?=
 =?us-ascii?Q?JLoTU/QsYZ6GuFCG8Is6YgbVejvO3reCyS20VKt78pQkmhc/pFKuPF9Bo6QF?=
 =?us-ascii?Q?2i0Kj2B2pfAdo19TvlUywMsixjCELNqCjUlatz+9gURBBYGhkFbgz8JWdvmx?=
 =?us-ascii?Q?olKv1YYdgDZG04Z2YRg980d28ftbbna7wONOuXAdSzGwLWKwacamEV8ws8+P?=
 =?us-ascii?Q?UDvaH5khOpmWvJjkowNX1Ok2e5IEr3BRdp84JIiP0nLXsObv9xCJ7nIp0hW9?=
 =?us-ascii?Q?0fTvYiu7W6By0+ZjteWJcnXx+znxMWEEhrBfW6VdH+sxJDNXCFf0uzWPcTE8?=
 =?us-ascii?Q?AyX/MxD5xGEEVPmXxZ5I5mKk/2z7b/BNhaFgQZ8lR5SMz4nL7lrCytIitmiB?=
 =?us-ascii?Q?012Zl6sxh7SVBD7vwQwXAI0LdDLFCfuME861kdTZEmPiPZYPXQpU1HuVqLcO?=
 =?us-ascii?Q?mjjAlaWko5Ok22wmgdKnG8w1wA6IBkBsOSHvjqeQPcP58G2tIELJibj4AWXk?=
 =?us-ascii?Q?e+JYGvkiJAwSsBpP1+krBp9bWVv7fhWk1UBQkrZ1zlzuCLzIZKk5aPWnbo6O?=
 =?us-ascii?Q?XbAdsM8FrLsQHVb/ywCQwgW0Q08pX6+B1HxUcq5UVuSXDbfW2t32TY1h0OD5?=
 =?us-ascii?Q?B4eOvf6S+f1tKEzBW8y0uiKPJfHnGN4dsS7cMu1Y0GB4dwD8Ymp1RgT+JxyB?=
 =?us-ascii?Q?lNXaruObXHzLNASUfMsfvpxvIfQOJSU9RTuFv5/0hEq5ltCu9flVzP1EPCsn?=
 =?us-ascii?Q?Tk0wl/kDtmOfV464h+g97q+yaINaDPoFiguTZGji3oNiZxhJGvoTpp+Fw+X8?=
 =?us-ascii?Q?Xa5UFcZfANwW1AcV1GBQLl5oZx06O/WWyEbhkRHs/93IqAy0+ehcBzGXShVb?=
 =?us-ascii?Q?YKfJOlgkMHCE25SzUhP0mBDx8Q8+45SHjqh/80De66bqEFzRnew0nqSyqPA9?=
 =?us-ascii?Q?lejF6enKJp2Y7IjH7SPRXQZNViRGo7Zhsg1aNwFgYEQNA4oED0cy/7ZvWvn6?=
 =?us-ascii?Q?jeHni3zh4c9JSOiBNylDnQkr63DvE+8Dml6oAyxspLZB5ogNLBDYk9lr99EC?=
 =?us-ascii?Q?wbBRZVk10dMbBVSagiEeWtOgEBQR2zuBISNsMDp/XtxaTlOM7sjcCTT0puZQ?=
 =?us-ascii?Q?v/yy7TeahXbaytyfyrSoghtlcODC457M+Mhs7VBnp8uG/s1ooeaq2+t/xR9+?=
 =?us-ascii?Q?mOkEnqlOZiYbHMvwLPLnj+/eNeOtIYUWnQSlivri8cL/fbMQX9TG0m/lUfwS?=
 =?us-ascii?Q?nctM+nzcZqsXvVXKNCC2mdv77Vbn7Xb8li33NMn+dzg/C67OtCg7RFUhhp9A?=
 =?us-ascii?Q?6blUv3O5Bs4ey2XSA0l4N1A=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <10056D781578164BBEDC84B92D0631DA@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 9EiGAfTzZaHV59PVS8ThxCCF4C8WHn/TPXZQGgalTX1wszYmLZebZV0Jll9mN6p53SsxmY47P1eBKJ2KoYw4YWyA3HzfrnSPOlL4FSzae1pMsH14F1BcZfDjeeSZgV8wABVYJftAQE8E8we//5JXT+h+YfZFyltQiGsemPyzlhVkxa/wYIfTNqqtg7zf+iyYKRTnlqVMlkX8O/uGdEtYeGACA/3WLHgFUZrNXs2zxNuhFeyqlX8J4TiUmKy4ItJ2ipq/JeWqVAOr211GF87auu5yL34wLX8W2RZZi5clYhB4dFin0vXrqA4jsh7TV4Uz+lMNl8a14olathJiQvkraWxxVODW700sLzLWyuKxFkc0HEpmYcLrLFtbwUtp2yUpJE2+tE+mksF8OD5G2sXLoxlUbw0M/iEXTH+el9AKjbsKa9E4D5q3izeeihqDCSSE5ZecIuFJZGPrdGSs5CIaqWb4Yz8WsGuP7lNeZWHO/vQ70elWhQk+YMOBWoURn0Hg/H/kY0pnHSfUM+fBt3GHFtOQxzatV4fdA0KSMmSeNQZOD5F2hc34gjDq1yt0WHjCtLfjtt/AqTv8+7UvHd2f7zYHLmKDCRbnHXaXVc+/jAoGInuQO1/feqQWyGUACcPqkq6jd6EOcY36VDpSBOPPi6vXpsLk5S7TgKtWmvcMl3Jort0VazI8yOJIYenaqnKHRE8eNf3emy0+C8JkxW7Zsn2KzaQl6th482Q6WHZ23OcmP2TdcxCMEjOfDHdT3avTc9WjCf+BgzrqCy4zNGAWEN71qeYoNY9pwU+u8aBad+6n1/QcF4KcXurVsjF5geUIbJooGQLHCulNjdIZN2t4WeblIUcmyxKzAYzFIN+Nk78=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 42a68433-86f4-4c63-e86a-08db94cf4287
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Aug 2023 09:43:29.8320
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: J14OrSV7rG0u5+7JM46BQCTqLAAZFsvMtCqCiehg8v6xGYI6m97TBhKMytDy4B4NPuor0hs3iGT4b518TiZsAwSy9BYiVYCmvxRkRacI4DU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR04MB7407
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        SPF_HELO_PASS,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On May 23, 2023 / 20:35, Chao Yu wrote:
> Use sbi->log_sectors_per_block to clean up below calculated one:
>=20
> unsigned int log_sectors_per_block =3D sbi->log_blocksize - SECTOR_SHIFT;

Hello Chao,

When I ran workloads on f2fs using v6.5-rcX with fixes [1][2] and a zoned b=
lock
devices with 4kb logical block size, I observe mount failure as follows. Wh=
en
I revert this commit, the failure goes away.

[  167.781975][ T1555] F2FS-fs (dm-0): IO Block Size:        4 KB
[  167.890728][ T1555] F2FS-fs (dm-0): Found nat_bits in checkpoint
[  171.482588][ T1555] F2FS-fs (dm-0): Zone without valid block has non-zer=
o write pointer. Reset the write pointer: wp[0x1300,0x8]
[  171.496000][ T1555] F2FS-fs (dm-0): (0) : Unaligned zone reset attempted=
 (block 280000 + 80000)
[  171.505037][ T1555] F2FS-fs (dm-0): Discard zone failed:  (errno=3D-5)

The patch replaced "sbi->log_blocksize - SECTOR_SHIFT" with
"sbi->log_sectors_per_block". However, I think these two are not equal when=
 the
device has 4k logical block size. The former uses Linux kernel sector size =
512
byte. The latter use 512b sector size or 4kb sector size depending on the
device. mkfs.f2fs obtains logical block size via BLKSSZGET ioctl from the d=
evice
and reflects it to the value sbi->log_sector_size_per_block. This causes
unexpected write pointer calculations in check_zone_write_pointer(). This
resulted in unexpected zone reset and the mount failure.

I think this patch needs revert. What do you think?

[1] https://lkml.kernel.org/linux-f2fs-devel/20230711050101.GA19128@lst.de/
[2] https://lore.kernel.org/linux-f2fs-devel/20230804091556.2372567-1-shini=
chiro.kawasaki@wdc.com/=