Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d173e4fd-29e2-281e-9c43-6f6b81cc62e3@wolfvision.net>
Date:   Fri, 4 Aug 2023 11:45:26 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 3/4] drm/panel: sitronix-st7789v: add support for partial
 mode
To:     neil.armstrong@linaro.org, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Sam Ravnborg <sam@ravnborg.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Maxime Ripard <mripard@kernel.org>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Sebastian Reichel <sre@kernel.org>,
        Gerald Loacker <gerald.loacker@wolfvision.net>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org
References: <20230718-feature-lcd-panel-v1-0-e9a85d5374fd@wolfvision.net>
 <20230718-feature-lcd-panel-v1-3-e9a85d5374fd@wolfvision.net>
 <422faa68-a741-0cf0-6a90-a9b46424e201@linaro.org>
Content-Language: en-US
From:   Michael Riesch <michael.riesch@wolfvision.net>
In-Reply-To: <422faa68-a741-0cf0-6a90-a9b46424e201@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VDB1a0thT2lNaXNRczhZQlA5T1lveldqMi9lS1dXa1VRcTdIcXVVQUwrVGp1?=
 =?utf-8?B?M3JCc08ycVpML29ITnFnOFpraEVQZTJNRGVaSDVYdC9lTGZwMm01aTI0MUpj?=
 =?utf-8?B?d2I5Q2xxY05uN2JDTlVMUXV2MXFnaWVpSDc2Ylc5S2Jvb3E4Z20ybngrckVB?=
 =?utf-8?B?Sy9uY0ovR256ZGV4VTA1ZVhyRGVjemgrNWdqUWltV2ltMVMralcwa3F6L3E0?=
 =?utf-8?B?eGZUd2N0M2o1c2tNVGo4S28wa05VbUt3ZERjS2owL2NEeE9jMWI1ZnUxVVd6?=
 =?utf-8?B?NTFoSFlTMk5nZ2RPeHJTNmU4ZyttWGpOeGdLQ1o2bFA3b01ENDZqdWZLQVpq?=
 =?utf-8?B?ZUQzcUZBZUxDRldYRWY3cVBPV1hDYzYxZGFhUURRQ1pMT2Npakt5bDZPaXYx?=
 =?utf-8?B?K2NCSFlXYkM0N0E5TVFscnlQM2N1V1N4OGNLeURha0tjdENBYnliakpmOE9P?=
 =?utf-8?B?SGVRRlhBN1FFY012VzdWUWo1UWxOR3FMd28zZTdnUlJqZnVnZ0prbk9wbExB?=
 =?utf-8?B?ZklyU0Q4RDZubjVYbHJocEgzZS9BdEhFVFc0cHBsTlkrdWFDNkZvRjlIZE5T?=
 =?utf-8?B?RjNYK1JWTTBvUlBvV1loaWtmcS9hcStXMDNEL2VldlpQUVdITHdpU3hsS2xm?=
 =?utf-8?B?VVVvT2F5dm5YTjFXZ0UzbllOakpaUmdvcGJaMnlUd3ZMWG9jTy9wY212NzZB?=
 =?utf-8?B?bERCUWFXUExCUHoxaUc4UUZQcXdVOTdlbksxWkR1SEp6NHpPejBxWVR0UEZp?=
 =?utf-8?B?UTgrSHpkTlRJNXcyNGdmci9MWHpZaWZjZFZtbTZLaExLSlNCQUhxUXZlK2xj?=
 =?utf-8?B?RlpJM2tjL3FLdk5GOGtLQkc1WnR3SjVUbnFLelV2RFhpeFZnRks2bjQzODhq?=
 =?utf-8?B?SUpObEpYWmlJQm5LVGRGRktGMmdkYXAxZWgxMU0zamZ0dXd2NjZDTEtIaWw5?=
 =?utf-8?B?VjRBRXdwT3BiNXpGUEo1TFU5b2JBNW1oL2o1bkxUc0RVUWIrbW9mZmZsWXZu?=
 =?utf-8?B?YWZ4NGlKdUtUSG8wTnhVUk45OE5MZnBvTEpQN2Rqc01ZaldUMHVHbnVGTkw3?=
 =?utf-8?B?V3VxSlFkZlZkMVVzVnllL0lLQmlVNW01Zm5UdytGcWZOZE5qT3UyNWxhOGs4?=
 =?utf-8?B?Y1FGdlZVQVdVdmo2dkYrdHk0RWNGaEM2bTd1SFR1RjBrdkdQenpvWTN0TjhL?=
 =?utf-8?B?WGRXNkpZWjRUcGFUeUhWdm9nMW9LeUhsbnhCZ2hZVzJFdnRxR3dBeWhKWDNx?=
 =?utf-8?B?TkRXVnpKVTBTVHI0NGZLbWYvTkFLK3RkZ21ZNjBaMzhBdk5lUUVOM3pzQmNh?=
 =?utf-8?B?blhheE1NN2FHdjZQSVVhdUVyckZyTklrWjdFcTdGMnpISHZzaWt2VGRNRzFG?=
 =?utf-8?B?WWNMWWRmeDNUb2FhYUpMQ1RaRnI0bHp0TFNrMnBpaW9seUs4bGtpa0FNR3pq?=
 =?utf-8?B?ak8wMUJ4alM4Wk81OE8rM1pTdktwRVZrRDVQTENJVVgyRFlqeGlKdWp0NERo?=
 =?utf-8?B?Uzd5eCtDTmZ4NjVpdWVTcThBRm9aZVNsWUxadnlSVXpwNFZYKzJkWTErMDNX?=
 =?utf-8?B?ZllzU1BGTjlQT1llYUw1T202cmFKM3dvYUdZK2E1USt0VE9jZUNTczJzUTJC?=
 =?utf-8?B?NFVaenFTNGpxTkF1L0FFU0dieGZBdC9qcFNaN1ZRRzZMMlpuTmx2cTAxem0r?=
 =?utf-8?B?QndUc2RkTFp4eWhCTXY0WmlYMEQ3SnpiN0dOa0FoeWx0eXBPZWJJdHVuNFRa?=
 =?utf-8?B?TGcyNUhMTGhEK1lqZy9LWkd6RS92VEhRaE5CRmROSU0yL01ZQ1FxTU41ZmVM?=
 =?utf-8?B?Z3NWWElEck5WcUJBenozWmVnMFQxcXo1S1YyRnJpYzFwd3NuV2pSTEdBR0Rs?=
 =?utf-8?B?ZitBVDFBbk9rM0NkbGNFWFBhemkraVZHWGtpeklNVmlWcTYwaXBybFJROVUz?=
 =?utf-8?B?Y3V0Sk5ydlAxMVE4eHdEUzNCdXFqUWRORWp6Y1hSTTB0WUZSdm9sOHdnV1ll?=
 =?utf-8?B?ZFZMclFlbDB3cVBSd21Oc2xZRnB1NmVUaE4ydTZTM2hKWW9uUUlCREwwVDl1?=
 =?utf-8?B?TjRDSVVDaTEraElmNkNhc0RqeXNXSjRtQTVpZkpXMjJQcmNXejlKRmxTOU1j?=
 =?utf-8?B?cHlhOXliS1ZYS3YydWhlTCtzcGRnbVl5WXFzYzRHVlFlOStvVy9aTS9SRk03?=
 =?utf-8?B?Tm9wa29ybk1aUitNdW9jZlVZOS9pN050WW5GQUN4Mnh2cE1JZGw4UVJ4b212?=
 =?utf-8?B?V1BaZTFnajRMSkNhQVZmZDd4TlF3PT0=?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: e7b3e35b-f6da-42b0-039d-08db94cf89b2
X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB9155.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 09:45:29.3765
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QmT76U0O87KqkxMoM4fWJaYGKS/ZdHX8vV1OveBWhZitEMYJLgqDaGKZ5MujKshnSSBDseRbELDouWFdjdW2Ou+gNnH+G/GlDgY6YL1C14Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5335
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Neil,

On 8/4/23 10:41, Neil Armstrong wrote:
> Hi Michael,
> 
> On 18/07/2023 17:31, Michael Riesch wrote:
>> The ST7789V controller features support for the partial mode. Here,
>> the area to be displayed can be restricted in one direction (by default,
>> in vertical direction). This is useful for panels that are partial >
>> occluded by design. Add support for the partial mode.
> 
> Could you send a v2 with a comment in the code as Maxime suggests ?

Sure thing! I must admit that I do not understand his concerns exactly,
though.

@Maxime: I can prepare a suggestion but feel free to tell me the exact
wording at the preferred position.

Best regards,
Michael

> 
> Thanks,
> Neil
> 
>>
>> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
>> ---
>>   drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 38
>> ++++++++++++++++++++++++--
>>   1 file changed, 36 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
>> b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
>> index d16d17f21d92..729d8d7dbf7f 100644
>> --- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
>> +++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
>> @@ -118,6 +118,9 @@ struct st7789_panel_info {
>>       u32 bus_format;
>>       u32 bus_flags;
>>       bool invert_mode;
>> +    bool partial_mode;
>> +    u16 partial_start;
>> +    u16 partial_end;
>>   };
>>     struct st7789v {
>> @@ -330,9 +333,14 @@ static int st7789v_get_modes(struct drm_panel
>> *panel,
>>   static int st7789v_prepare(struct drm_panel *panel)
>>   {
>>       struct st7789v *ctx = panel_to_st7789v(panel);
>> -    u8 pixel_fmt, polarity;
>> +    u8 mode, pixel_fmt, polarity;
>>       int ret;
>>   +    if (!ctx->info->partial_mode)
>> +        mode = ST7789V_RGBCTRL_WO;
>> +    else
>> +        mode = 0;
>> +
>>       switch (ctx->info->bus_format) {
>>       case MEDIA_BUS_FMT_RGB666_1X18:
>>           pixel_fmt = MIPI_DCS_PIXEL_FMT_18BIT;
>> @@ -472,6 +480,32 @@ static int st7789v_prepare(struct drm_panel *panel)
>>                           MIPI_DCS_EXIT_INVERT_MODE));
>>       }
>>   +    if (ctx->info->partial_mode) {
>> +        u8 area_data[4] = {
>> +            (ctx->info->partial_start >> 8) & 0xff,
>> +            (ctx->info->partial_start >> 0) & 0xff,
>> +            ((ctx->info->partial_end - 1) >> 8) & 0xff,
>> +            ((ctx->info->partial_end - 1) >> 0) & 0xff,
>> +        };
>> +
>> +        ST7789V_TEST(ret, st7789v_write_command(
>> +                      ctx, MIPI_DCS_ENTER_PARTIAL_MODE));
>> +
>> +        ST7789V_TEST(ret, st7789v_write_command(
>> +                      ctx, MIPI_DCS_SET_PAGE_ADDRESS));
>> +        ST7789V_TEST(ret, st7789v_write_data(ctx, area_data[0]));
>> +        ST7789V_TEST(ret, st7789v_write_data(ctx, area_data[1]));
>> +        ST7789V_TEST(ret, st7789v_write_data(ctx, area_data[2]));
>> +        ST7789V_TEST(ret, st7789v_write_data(ctx, area_data[3]));
>> +
>> +        ST7789V_TEST(ret, st7789v_write_command(
>> +                      ctx, MIPI_DCS_SET_PARTIAL_ROWS));
>> +        ST7789V_TEST(ret, st7789v_write_data(ctx, area_data[0]));
>> +        ST7789V_TEST(ret, st7789v_write_data(ctx, area_data[1]));
>> +        ST7789V_TEST(ret, st7789v_write_data(ctx, area_data[2]));
>> +        ST7789V_TEST(ret, st7789v_write_data(ctx, area_data[3]));
>> +    }
>> +
>>       ST7789V_TEST(ret, st7789v_write_command(ctx, ST7789V_RAMCTRL_CMD));
>>       ST7789V_TEST(ret, st7789v_write_data(ctx, ST7789V_RAMCTRL_DM_RGB |
>>                            ST7789V_RAMCTRL_RM_RGB));
>> @@ -479,7 +513,7 @@ static int st7789v_prepare(struct drm_panel *panel)
>>                            ST7789V_RAMCTRL_MAGIC));
>>         ST7789V_TEST(ret, st7789v_write_command(ctx,
>> ST7789V_RGBCTRL_CMD));
>> -    ST7789V_TEST(ret, st7789v_write_data(ctx, ST7789V_RGBCTRL_WO |
>> +    ST7789V_TEST(ret, st7789v_write_data(ctx, mode |
>>                            ST7789V_RGBCTRL_RCM(2) |
>>                            polarity));
>>       ST7789V_TEST(ret, st7789v_write_data(ctx, ST7789V_RGBCTRL_VBP(8)));
>>
>