Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 4 Aug 2023 14:14:31 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Victor Nogueira <victor@mojatatu.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
        Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>,
        Peilin Ye <yepeilin.cs@gmail.com>,
        Pedro Tammela <pctammela@mojatatu.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Zhengchao Shao <shaozhengchao@huawei.com>,
        Maxim Georgiev <glipus@gmail.com>
Subject: Re: [PATCH v3 net-next 09/10] selftests/tc-testing: test that taprio
 can only be attached as root
Message-ID: <20230804111431.cjtj3kbcwhk5wcaf@skbuf>
References: <20230801182421.1997560-1-vladimir.oltean@nxp.com>
 <20230801182421.1997560-10-vladimir.oltean@nxp.com>
 <918bf9fc-1c8f-a006-560e-b437581c6ec2@mojatatu.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <918bf9fc-1c8f-a006-560e-b437581c6ec2@mojatatu.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6YQnOHAED9Wm1UfeiQtUg1AeE9Lgb9QnSWWe0zBd7U1P2driYqbGqciJ7+SP?=
 =?us-ascii?Q?9QDsHvJ4Pf4bA9JccNYm97n2jq1mf+IDvk9QIgjOj9sXoF7MDqMVaFcxUM7U?=
 =?us-ascii?Q?AP4lJdCoRGA3Ek1TVS9pgJgns5vY8RnXVIp5Zzsb5NJbGdwYvoL8vPeQRC2n?=
 =?us-ascii?Q?YNCXhfKGHJsVio9n5SXjntDU4Aejyn5Sar9f7YsqSQ9hViwIksKFVerwx43b?=
 =?us-ascii?Q?aegwFSNOXhs1ukblWZyrWdM6SrywVMtEC/gbkwdRGKFWMT91W/ei958WuPqw?=
 =?us-ascii?Q?oX8USRPp1qUKX7EP7ceGJhBfEhlYOcGjfsLHx3h2yV9YJcIOVpp8Ikyw38eM?=
 =?us-ascii?Q?eb64t3wdJezipN9vCLkXfcuqQlO5us6COW7FSOxo9HksxqsXco1mt0jeRfzu?=
 =?us-ascii?Q?6wrzbFvBKxDxZonxl47o2D0j/j/198npqsKoA9enrlQpiz1E+R9Hg5ClXEQD?=
 =?us-ascii?Q?UBzRFj9ABqG0XgiC13EiVRGapzGYyNhHzDeoRK2J//qGXxPsNBrPZPeMhzkk?=
 =?us-ascii?Q?fqyCA40nZ3qxwmXNFrYBRiu3SoWz58kt/JzYwa3ALONFD313/QKn/pFJ8qsg?=
 =?us-ascii?Q?boF2uDgQ8sUHhdzBSZh4zl8dzZ3+JmL9Mo3rQX4fb4oOg3UF8uSLYUjyR/pG?=
 =?us-ascii?Q?mQ/eoXSrXARr9KT+VyI1zefwmwIaajNF4IIYu2D8U+oCMEmtvnmEQ+8fVFE0?=
 =?us-ascii?Q?Z/FhA2j6h1BVbrri5thX6gMmPOJ2ii35IaoYtAh4ADun8XJ23lvQWiqGAhwc?=
 =?us-ascii?Q?rjiOkctChg8zKGzLwYLSIijHmkydSHOBNUtPZzR/St2S9zUOntEcmSJocnKt?=
 =?us-ascii?Q?6LD6NljDVC+eAa8a9c2Eg8RExEPn8QaELtgY2pwP849M32XkWnL9GEXMMdXN?=
 =?us-ascii?Q?OH3jQO8MHiNNsJudDpcjI3Y2ZLILIOZExuolc1zOepy2QF+/DD08UsjhLpSZ?=
 =?us-ascii?Q?8S/V+nu4YzXSNj/iTLyglM1F9Hhz8I0/b2D5ISZwa3aZaunCMDSer5+bjN+M?=
 =?us-ascii?Q?tN4Gz+UpaiBVrLOrkUsJ3ZAWny683RG4qCjLAVxEyJJwfKb6LUmIUuPnFt6K?=
 =?us-ascii?Q?UkOeo5mLQLXQV0SF9zm89pLyfEnR/FwD3ZXSU6FMxUIXWg2JaUDt/zXSCYpO?=
 =?us-ascii?Q?q2OZT5rFt0+MZf7Phq7BcpTpNF0ko3tJRK6eYCsE3BZUdpgZSsaFPOWq7hcw?=
 =?us-ascii?Q?eEBD1GyoJv6mZMvEJJcXlPeEfX7KSB+PLtFap0e6OrzmZIZ5KMrCFkhKmdwm?=
 =?us-ascii?Q?p777Y2rJnFCjyHzSjMWqzb54me4XyEazZ4+Ni6mpspZ2zuHTXDiGVwFLUy7M?=
 =?us-ascii?Q?05AuDw8S8dJHMDAoqUQe5TlgZmTPaIp8hMleSwTVwM51ABTJGjtrpyqmAt4f?=
 =?us-ascii?Q?I1JE0F/GBrmec2P+86CAtAonChO8NhCPA4Fmjs8QE6cNIwDJXCtatUfPPUEG?=
 =?us-ascii?Q?hymsQHwVG3R3A6h8m9RyEEpAU8QssXc/TJOBZWRTiNZSu3Nb8cv8pOXfCbsj?=
 =?us-ascii?Q?pA4tzMzoQdlMkgexinQ51xcHMrIScAoxfIr//PcFLd2HWxdpsZXRJXZYmwV8?=
 =?us-ascii?Q?rpk3aYYZClf3GB5V2hbpcuecu9WrgL2i1hFUgzh/pinKWhUqSWIjcvesKChh?=
 =?us-ascii?Q?mQ=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e31edb2-cc0d-42e3-2f5e-08db94dbfc38
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 11:14:35.4652
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xgioAPEe6Yws8W73jK98IYnfoqIaDrVQUNzQEIP7OCnoMi0bxQwNOQtBcaB6A5gNd2MLCkYNrSrhIfYD+Vtwlw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9357
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 03, 2023 at 02:21:07PM -0300, Victor Nogueira wrote:
> On 01/08/2023 15:24, Vladimir Oltean wrote:
> > Check that the "Can only be attached as root qdisc" error message from
> > taprio is effective by attempting to attach it to a class of another
> > taprio qdisc. That operation should fail.
> > 
> > In the bug that was squashed by change "net/sched: taprio: try again to
> > report q->qdiscs[] to qdisc_leaf()", grafting a child taprio to a root
> > software taprio would be misinterpreted as a change() to the root
> > taprio. Catch this by looking at whether the base-time of the root
> > taprio has changed to follow the base-time of the child taprio,
> > something which should have absolutely never happened assuming correct
> > semantics.
> > 
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> > Reviewed-by: Pedro Tammela <pctammela@mojatatu.com>
> If I understood correctly, these tests depend on CONFIG_PTP_1588_CLOCK_MOCK.
> If that is the case, you should add it to the tdc
> config file (tools/testing/selftests/tc-testing/config).

Thanks, will do.