Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 4 Aug 2023 13:10:13 +0100
From:   Mark Brown <broonie@kernel.org>
To:     James Clark <james.clark@arm.com>
Cc:     coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        James Morse <james.morse@arm.com>,
        Kristina Martsenko <kristina.martsenko@arm.com>,
        Anshuman Khandual <anshuman.khandual@arm.com>,
        Rob Herring <robh@kernel.org>,
        Jintack Lim <jintack.lim@linaro.org>,
        Joey Gouly <joey.gouly@arm.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64/sysreg: Move TRFCR definitions to sysreg
Message-ID: <143152c8-61b8-4a71-9090-7203342b661c@sirena.org.uk>
References: <20230804085219.260790-1-james.clark@arm.com>
 <20230804085219.260790-2-james.clark@arm.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="3kbZh3r3C1unpocv"
Content-Disposition: inline
In-Reply-To: <20230804085219.260790-2-james.clark@arm.com>
Precedence: bulk


--3kbZh3r3C1unpocv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Aug 04, 2023 at 09:52:16AM +0100, James Clark wrote:

> TRFCR_EL2_CX needs to become TRFCR_ELx_CX to avoid unnecessary
> duplication and make the SysregFields block re-usable.

That field is only present in the EL2 version.  I would tend to leave
the registers split for that reason, there's some minor potential for
confusion if people refer to the sysreg file rather than the docs, or
potentially confuse some future automation.  However that's not a super
strongly held opinion.

Otherwise this checks out against DDI0601 2023-06:

Reviewed-by: Mark Brown <broonie@kernel.org>

--3kbZh3r3C1unpocv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmTM6qQACgkQJNaLcl1U
h9BU8wgAg9t9M9QcYBy9wf/UQDBywT7WO5cKpIRHeKsshoqoXQNBEbQhfLb9Mase
qLQbJUQtLQMOD0fNaVKOZX13tVV8m3cDigvN91VdGfhpgGZLUX6qyDxWW92RRlxn
ObB44WMyxj2QI+ab6Fn3YZ24cfAWRr8ChhR/eWdmcRTdA4unl6ooONkK1xzxMcTf
Q1NHuQLw8BjzegrQBicDLHl2UHRddCEo12tgRK/JWnE0Axy1j2J+wovkUHBKf9X5
8PfQAoGwPwLJAmKII4v7AVuCbBlmk6JdRP7mSpfa/lFYFTxiBaEr6l9Rypo5TfDQ
N2DXbHp2baCffYJP6U0kfw/xk26teQ==
=1wa2
-----END PGP SIGNATURE-----

--3kbZh3r3C1unpocv--