Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f71a8729-57a8-f45f-7db2-41ab543405de@wolfvision.net>
Date:   Fri, 4 Aug 2023 13:24:46 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v2 2/3] drm/panel: sitronix-st7789v: add panel orientation
 support
Content-Language: en-US
To:     neil.armstrong@linaro.org, Sam Ravnborg <sam@ravnborg.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Maxime Ripard <mripard@kernel.org>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Sebastian Reichel <sre@kernel.org>,
        Gerald Loacker <gerald.loacker@wolfvision.net>
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
References: <20230718-feature-st7789v-v2-0-207cb1baea0f@wolfvision.net>
 <20230718-feature-st7789v-v2-2-207cb1baea0f@wolfvision.net>
 <b2407b1d-23fb-3284-c4bb-b3a952d361dd@linaro.org>
From:   Michael Riesch <michael.riesch@wolfvision.net>
In-Reply-To: <b2407b1d-23fb-3284-c4bb-b3a952d361dd@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aVlSMDlNem9CazRnZWppUkVSY1lLeFUrTXZ4U1RBNGYxOWdDaEZpRHlKTXhF?=
 =?utf-8?B?bmdYWGpJR1hPY2FnSWluNnJjSTRGYmdNRks2bGR5TUwxSlpWUnN3YjNVTS9Y?=
 =?utf-8?B?QXhEYkVBMSt1UWRzS1JWYWxRVlZteXlQWlBzb3NVakZmK29Hd1c1T2p6NTRv?=
 =?utf-8?B?bjBGSGNZTGZFS2VWS1hYbVFVUU9JcXZDeU0zNklEcVB0b0ZQOGFOc1pOUktK?=
 =?utf-8?B?MUYvMTJGa25YTkxQVHRVbjlHOU1qNDJDYXhJaTdvbEhmSFZHaG0wcENOMStr?=
 =?utf-8?B?a1VMOUtjQU4rTHdFWG1vQWZVRVZjenZ3N2pWQWJPQWg3M2hiei9CRmFvTGpj?=
 =?utf-8?B?N0VhemxZU2NQeE9vcnZoekhWV0xvNS9wM3BSTjRTK1lxOVU4bnNMUXBTSUdS?=
 =?utf-8?B?K0hFTHQwUmU0UHA1VEF2Yk5FTXVtTFBDSGdCZXM5SnBLQlk0V2x6dlM3OVpl?=
 =?utf-8?B?RGFDNXllQklOdnlQaU5GRmd1N2FvcVFaTEJRa2Y0RCsvajFGd3ZMOFVtU1R0?=
 =?utf-8?B?L1lnSFFaeHNjU2hkQktsMDY0K2hGZmJ4Q2dWaXNLZjhYS05MQWtIcE5wcU01?=
 =?utf-8?B?clZpcHVkQ2VkbjdtSXVTNy83SkU0OThnR0V5K0YveHFWdWFsWHl6MFI3SkFu?=
 =?utf-8?B?K3VxWjdTYXp3UmZoVmNaYWkwQ24xOTVWMkRCOTRjbVR5TWhCL2dpUEEzdFdr?=
 =?utf-8?B?SWIvMEYzSFFQbEtZN01Xc1U1RU5mZW9mM3ZmMmpCcnRyUkxPN1ZRWnV6OVM2?=
 =?utf-8?B?RDFRczh5VWl0TVAzZ1pmdURKd3NaS08xMXhjUmxlUURTbVBNK2owTnRXQmhj?=
 =?utf-8?B?QytjYXhvNURrM3JtdFJ6dFlOSStEdUEybTFSdXNNenlDcC9qTjJXbUdIaGds?=
 =?utf-8?B?WG9VZFhLcHpybE5CY2dCYWk4Z0F6UDJuelkwaHRTczZkWWt2SHFDU28wQWgr?=
 =?utf-8?B?Vk9rNHIxQWZrNHlvbHNNNG5idnM0T3Q0U0RIUFpRTVVQblFSQXNGK25qeVJt?=
 =?utf-8?B?ZzBQbmMzd1A1Q0ZTdkJGcktZZDJmVzlCaU4zakxsY25HWm1kbzUrR3VKT041?=
 =?utf-8?B?emZCVTFmbUxlOWNsVnZQYzNvRjVMMUpVeHI5KzVBQWZZVjRBc1JsRlNXNlJL?=
 =?utf-8?B?OXZYeVBMYitTYkxoU3pKSGRLQkFUNURzZC91bHZMZ3ZES2V4cGRZVWVON1Nr?=
 =?utf-8?B?Z1oxcVh3Z1ViNlRhenFVeUFvemFJcldtZEROTVIvRGRORXhlYkhCOGE0S0xz?=
 =?utf-8?B?Q2NKYmdkYzZqSVgzSEdMZkdOZlJ0Z3ZHS0RjMk8rM080UGZDem9YcDNnRVhr?=
 =?utf-8?B?dnlHczdkZHpEblloK0NiL2tvUEM4aU1nWTRYVzFiaEhTNERONlY0VWwydzUw?=
 =?utf-8?B?ZFp2YlVZWmIrY3lyZUliTXZCeW95TWU4bldhdDVpclpYRnJ6S09Hdkpva2h4?=
 =?utf-8?B?MVZOT0VVOCtPbkpDK2lrbWJza1VCQkhyYWJ6TWV4MGtJanEvQ1ZwYWFqMzhy?=
 =?utf-8?B?eGlqZ055WDNHMVo2eENyTEJXUkdXZ1NMWmlsTWVhMWI0QklIY0h4TXpjVVJF?=
 =?utf-8?B?NW5WL2NHNnJLOTN3K0RJN0prTFQwTVdxU1o2YXNiVE9oZ2NzNUZ4Nk5PT1hq?=
 =?utf-8?B?bkE0RVdXSVNQNC9PamJmUU1vNUgxa1hwa0tTRXBiZFQ0ZXZmR0tkREppa2k0?=
 =?utf-8?B?YkFmeUQxdy9BbXQ5cW53U0x6US9CVVBndWtLNjFiVHlhaVpsZHE0OTVMV3ZW?=
 =?utf-8?B?MCtTMUhQMG1HSXBQSCtYQytCRXdDS3pQZFNKK3pQc3RlUXNxcmpuem9mRG9P?=
 =?utf-8?B?a3pnRDdXM0YveTdsMWRPNllOWld6Y3ppeVhLSGFwd0pOemN6OHpYOGVZTWIx?=
 =?utf-8?B?S0hpWW1oL3p5TWdJWEZ2THhsTmhnTHZIZzNLN1Nsc29mRGVTNWNJbHpURkxP?=
 =?utf-8?B?bUh3Mkh0Q2pBU0xzY2JXb0I2Slk5dU5ER2RCbTBRZFM2OFFnVlJpRjhDc0t6?=
 =?utf-8?B?K25tMEdleFlSNktOMEUrOUE5ekFDbG1TSE04TkQzWEhoYlN5TUZ6NnV0MDBn?=
 =?utf-8?B?V3JwdEp3NEhaWGU2V3VxYmdGRllwQlR3VmpUNEpmT0hieUxPVHJXRE9EUU9D?=
 =?utf-8?B?a2x4enNBNzZXYzE2cUdUbHcwakhzZmMzaVkva2crNW52VjNiWjdGMFBPSVg1?=
 =?utf-8?B?UTlyMG82WUVCY2JjNTBQdmxobWVBdm11REgyUk1LdXRkdkNpWkR4dDdEMnpJ?=
 =?utf-8?B?ODY5YVFhUEE2YXZkTTVQOGYxMVVBPT0=?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 1748d296-a217-4039-af4b-08db94dd748e
X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB9155.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 11:25:06.8829
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9srQwKQVGkopVEaRSu1duR7GJWicnCvhM4nG71tpxzbZSs6X52JTwXbVLIZ0DL1U1LVMzEfDSW9NC7hKoq71mFISwri4sxuzHz+L2KyjcbU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB10214
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Neil,

On 8/4/23 10:40, Neil Armstrong wrote:
> Hi,
> 
> On 03/08/2023 22:13, Michael Riesch wrote:
>> Determine the orientation of the display based on the device tree and
>> propagate it.
>>
>> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
>> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
>> ---
>>   drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 18 ++++++++++++++++++
>>   1 file changed, 18 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
>> b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
>> index c7cbfe6ca82c..6575f07d49e3 100644
>> --- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
>> +++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
>> @@ -116,6 +116,7 @@ struct st7789v {
>>       struct spi_device *spi;
>>       struct gpio_desc *reset;
>>       struct regulator *power;
>> +    enum drm_panel_orientation orientation;
>>   };
>>     enum st7789v_prefix {
>> @@ -170,6 +171,7 @@ static const struct drm_display_mode default_mode = {
>>   static int st7789v_get_modes(struct drm_panel *panel,
>>                    struct drm_connector *connector)
>>   {
>> +    struct st7789v *ctx = panel_to_st7789v(panel);
>>       struct drm_display_mode *mode;
>>         mode = drm_mode_duplicate(connector->dev, &default_mode);
>> @@ -188,9 +190,22 @@ static int st7789v_get_modes(struct drm_panel
>> *panel,
>>       connector->display_info.width_mm = 61;
>>       connector->display_info.height_mm = 103;
>>   +    /*
>> +     * TODO: Remove once all drm drivers call
>> +     * drm_connector_set_orientation_from_panel()
>> +     */
>> +    drm_connector_set_panel_orientation(connector, ctx->orientation);
>> +
>>       return 1;
>>   }
>>   +static enum drm_panel_orientation st7789v_get_orientation(struct
>> drm_panel *p)
>> +{
>> +    struct st7789v *ctx = panel_to_st7789v(p);
>> +
>> +    return ctx->orientation;
>> +}
>> +
>>   static int st7789v_prepare(struct drm_panel *panel)
>>   {
>>       struct st7789v *ctx = panel_to_st7789v(panel);
>> @@ -349,6 +364,7 @@ static const struct drm_panel_funcs
>> st7789v_drm_funcs = {
>>       .disable = st7789v_disable,
>>       .enable    = st7789v_enable,
>>       .get_modes = st7789v_get_modes,
>> +    .get_orientation = st7789v_get_orientation,
>>       .prepare = st7789v_prepare,
>>       .unprepare = st7789v_unprepare,
>>   };
>> @@ -382,6 +398,8 @@ static int st7789v_probe(struct spi_device *spi)
>>       if (ret)
>>           return ret;
>>   +    of_drm_get_panel_orientation(spi->dev.of_node, &ctx->orientation);
>> +
>>       drm_panel_add(&ctx->panel);
>>         return 0;
>>
> 
> This patch doesn't apply clean on drm-misc-next, could you rebase and
> resend ?

Sure! v3 is out.

Best regards,
Michael

> 
> Thanks,
> Neil