Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b1db4846-9da1-9af4-4b3f-53ebf2e527a2@amd.com>
Date:   Fri, 4 Aug 2023 07:59:39 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v8 2/2] PCI/ACPI: Use device constraints instead of dates
 to opt devices into D3
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>
Cc:     "Rafael J . Wysocki" <rafael@kernel.org>,
        Bjorn Helgaas <helgaas@kernel.org>, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
        Iain Lane <iain@orangesquash.org.uk>,
        Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@linux.intel.com>
References: <20230802201013.910-1-mario.limonciello@amd.com>
 <20230802201013.910-3-mario.limonciello@amd.com>
 <20230803050118.GV14638@black.fi.intel.com>
 <06cf76ba-de5f-caaa-d1c4-9d34adf15a52@amd.com>
 <20230803151454.GZ14638@black.fi.intel.com>
 <208afe43-2539-156b-971f-89233598b687@amd.com>
 <20230804060743.GA14638@black.fi.intel.com>
 <ZMyWt4JD1TjoLk8w@smile.fi.intel.com>
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <ZMyWt4JD1TjoLk8w@smile.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WFlRSlZFMk1tZHVGOGtKV0t0YmZDbWVFV1BUTi9FUnVIeUxIRlpEcnFjUyt0?=
 =?utf-8?B?UkVnS2JrZGxMUC9aaDJsSkpNbGJFZTkvZ3dJNUwrTk5wSndGZEVyb05lYWdD?=
 =?utf-8?B?NytVVWZ1Qyt2Nldwb1BLTFR1NWFveHBXR2VlQmt1a05SdkZISkliajZOK242?=
 =?utf-8?B?N2phVk5wUVBFV1hhWTg1TnYxMkl0TFlYM0xrdVZIQ3BiaEpiYmpWYndvdWI1?=
 =?utf-8?B?T29WU1NURVY1RkRZeWZGRHcxNHVxUkJ6dHhKWEIra09mc0h3M1NYMFM4TzZ1?=
 =?utf-8?B?c1VYay9xNkZpSzk3M3QvMHQxS2c1NmhsaS9RaG1ub3M5RkNYblVMR1lRQ1Zn?=
 =?utf-8?B?cnVsd2VDOHJ3b2NmaUY4L3p0bTFBTThiQWo1T1pSaE1vellUam95UnB2UnRM?=
 =?utf-8?B?eXdXTHd2T20wU09EQ2kvUEMvUyszdThtTFkwT1NucjgwQkV4VVp3WHBUcHI3?=
 =?utf-8?B?VlhuSXgyeHIwbEpiZ2JnSWM2RzJpdXRIR3RLOE5tOGNrakNxTytoZXR0SWNZ?=
 =?utf-8?B?ZWNPSTNwclRFZVZGQmtCKzd4SGJCWFRvN3dTN0x1cUV3SjlPM0IyT0ZDNklp?=
 =?utf-8?B?eUtvT2lsZ3o3SjhkZHU1NTFmVUV4YlZFU2MyR0M5THRtMnNEQUJ3bkd6aXZ4?=
 =?utf-8?B?YmhVL1pHdktCUERxWVA3VkpGd1ovWDRGQTJyemRKb0NQQ0pDUlo4UVRLQk1E?=
 =?utf-8?B?eUpOenU3c2VscTFlZTdSSDVad2Q5YllzTTl6NGszN2RoZWszWE9iRG1EYTVS?=
 =?utf-8?B?T25uSkprcmhLT3EweU5RM1EzWHlkZVpUOGNocFBzdDZlVmpPY0FKVlVzL1NY?=
 =?utf-8?B?b1d1K1lycmFGRW5BNHJFZGU2bU5TRUpCUGJOUU1rSFd4RjBENm1LeFJYa2hz?=
 =?utf-8?B?SUFtMXEvUFg1aitVbnZseGp6TDJBK2o5TW1mNGFlZXVsSWRGeE1RaUYvMjFa?=
 =?utf-8?B?T0dyeExQeXV4OG9lSXpRQnRXTXBTeEphV2hMckZaWFJKbXlKL1dhbWZmVDBH?=
 =?utf-8?B?MTdwYnZxdHo3SnB1NjU3MlhzemVvbXgweGJFZk9nMVM5NHh3Wlppckg5WldD?=
 =?utf-8?B?UjBJR2NVaFNpdHN5ajU5TWc3WlNCZ1ZQTlhuNUtsRmtUNkZWRFNQLzZLaW41?=
 =?utf-8?B?R0daVjI1ZW80dmFnVmhqSFNNT1plKzVsTmw5SU9vVDRJZyswZ0ZtTGNMaWVH?=
 =?utf-8?B?azJlTDlKeDY1NWNBdzlwTkkzSHRXT1ZTVzBBYVQ1bklCWUNyUzZHZ2ZxZ1h4?=
 =?utf-8?B?cTAxUHRzR0Jlb3ZPUFdXdjFBSi8rakE4MDhpVUI1ZnkyWTFoOExIM1VXYUlo?=
 =?utf-8?B?UFFIZjhoODhSVENjYjZOOWh3di9yOWdacG9KUnRMRy9wWDlFcXJCVVA2Q3Ny?=
 =?utf-8?B?emZ1TmdrMkMwZEtDQVQ5WTBwREVCdU9wakJ3SEtocTVud1E2U1c5N2JWcTlv?=
 =?utf-8?B?NGY0TmQxWk82VG9IVEN0Q2pxaVhsbVcwRUthVFVTKzNjcnhZRVNUcmtSQ3Jo?=
 =?utf-8?B?SDg1Rm5aa0VaTWVjZ1RRd1U0YVprWkROTkJrbkZnZGMrZHJ3c1NVSEpqYkdB?=
 =?utf-8?B?SUxtdGZ4aUFPbUtQRGdmaEI2MjY0UzNuaUYzZUtjUUN6QlJpVElFdXRUOStl?=
 =?utf-8?B?cklnbkJWTmdXZWM5c2tZMENOYkZYMWhBRlRGOGNPdGJRM0ZTcjdidk9kNlBj?=
 =?utf-8?B?N1dKMytaTEJyL2NLV1NvV3plNGZadlgzcWZaRXBjdDFFUVdhZVN6RFRhMHFt?=
 =?utf-8?B?TXBUbWFRWHlhSlVsZWZMTlhHRVZvb0RKbFZkV3JqSTU4QUdyZlpCY1FTc0Vt?=
 =?utf-8?B?aE5Ebk55eU5rNEVhYVJsRHMvV1J3clJIS2pFL0FRYWlTSDdOUkpuN1k0alo4?=
 =?utf-8?B?R1FMQ3AySU5WSkMxMjlwWGlaVzNMMkMwZkFsME1yVk8yMzJGWm1sT0ZSTjNM?=
 =?utf-8?B?bFhIc1N1YWwzajZXNGRjUGVrYU0rV1g3dzViZEprKzVkTnB5Y1kzY3VtTmR1?=
 =?utf-8?B?OERzR0RjSllsMUV6dndoT2piSkFLclZvQ1J4OUR3OEk1bjVaV3cwYUxiVC9i?=
 =?utf-8?B?VUxFcWo4N0pkTDdwODJuTkdJamZJY2N0UnRuTmlEVndpa052Tm1kMjdDeEFB?=
 =?utf-8?Q?6aVh2ZgPfraa7yKYKbR06sCjM?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f37f83d6-0456-45a5-8acf-08db94eaabed
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 12:59:43.2487
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GjfwjDU4ViGBAlo3MF4m4c2c7sxqAB5idmmTrNZaxOPq6xRCs/Yt57usYPSdevAlPKS4Anv5wnm7RkMnl2DlzQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5108
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/4/23 01:12, Andy Shevchenko wrote:
> On Fri, Aug 04, 2023 at 09:07:43AM +0300, Mika Westerberg wrote:
>> On Thu, Aug 03, 2023 at 10:18:07AM -0500, Mario Limonciello wrote:
> 
> ...
> 
>> Some of them, at least the Apollo Lake ones were used in IVI systems
>> that did not run Windows IIRC.
> 
> And if it matters, they even don't have EFI complaint BIOS.
> 

Thanks.  I agree then; to avoid causing regressions or building a 
monster list we should at least try to work in the confines of improving 
the situation with an extra optional check that doesn't fail if not present.

Hopefully the approach from my v9 series works for this.