Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 4 Aug 2023 14:38:35 +0200
From:   "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To:     Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc:     Surong Pang <surong.pang@unisoc.com>,
        "felipe.balbi@linux.intel.com" <felipe.balbi@linux.intel.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Orson.Zhai@unisoc.com" <Orson.Zhai@unisoc.com>,
        "Chunyan.Zhang@unisoc.com" <Chunyan.Zhang@unisoc.com>,
        "Zhiyong.liu@unisoc.com" <Zhiyong.liu@unisoc.com>,
        "Surong.Pang@gmail.com" <Surong.Pang@gmail.com>
Subject: Re: [PATCH] usb: dwc3: gadget: Let pm runtime get/put paired
Message-ID: <2023080419-fog-charger-abf6@gregkh>
References: <20230731023323.16046-1-surong.pang@unisoc.com>
 <20230801004923.mcmkgoliy2qlwtah@synopsys.com>
 <2023080139-treason-emboss-75be@gregkh>
 <20230801235616.i2k4rq4xroesuwbf@synopsys.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230801235616.i2k4rq4xroesuwbf@synopsys.com>
Precedence: bulk

On Tue, Aug 01, 2023 at 11:56:26PM +0000, Thinh Nguyen wrote:
> On Tue, Aug 01, 2023, gregkh@linuxfoundation.org wrote:
> > On Tue, Aug 01, 2023 at 12:49:24AM +0000, Thinh Nguyen wrote:
> > > Hi,
> > > 
> > > On Mon, Jul 31, 2023, Surong Pang wrote:
> > > > Pm_runtime_get is called when setting pending_events to true.
> > > > Pm_runtime_put is needed for pairing with pm_runtime_get.
> > > > 
> > > > Fixes: fc8bb91bc83ef ("usb: dwc3: implement runtime PM")
> > > 
> > > Please fix your Fixes tag. Run checkpatch.pl before submit.
> > 
> > I don't see what's wrong with it, one extra character is just fine.
> > 
> 
> This inconsistency bugs me a bit. :)
> 
> It's noted in the kernel documentation that it should be tagged with the
> first 12 char of the commit id, and the checkpatch also complaints when
> it's not.

Fair enough, consistency is good.

greg k-h