Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [syzbot] [bpf?] UBSAN: array-index-out-of-bounds in
 bpf_mprog_detach
To:     Martin KaFai Lau <martin.lau@linux.dev>,
        syzbot <syzbot+0c06ba0f831fe07a8f27@syzkaller.appspotmail.com>,
        syzkaller-bugs@googlegroups.com, bpf@vger.kernel.org
Cc:     andrii@kernel.org, ast@kernel.org, haoluo@google.com,
        john.fastabend@gmail.com, jolsa@kernel.org, kpsingh@kernel.org,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        sdf@google.com, song@kernel.org, yhs@fb.com
References: <0000000000007095cd0601a9ad91@google.com>
 <5c9c4b8c-9f9a-7677-3c3f-6c0faf77397d@linux.dev>
From:   Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <2bea40de-81e5-10a8-8422-efd79a2fa3a5@iogearbox.net>
Date:   Fri, 4 Aug 2023 15:15:06 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <5c9c4b8c-9f9a-7677-3c3f-6c0faf77397d@linux.dev>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 8/4/23 1:39 AM, Martin KaFai Lau wrote:
> On 7/29/23 5:48 PM, syzbot wrote:
>> syzbot found the following issue on:
>>
>> HEAD commit:    ec87f05402f5 octeontx2-af: Install TC filter rules in hard..
>> git tree:       net-next
>> console output:https://syzkaller.appspot.com/x/log.txt?x=12a76df1a80000
>> kernel config:https://syzkaller.appspot.com/x/.config?x=8acaeb93ad7c6aaa
>> dashboard link:https://syzkaller.appspot.com/bug?extid=0c06ba0f831fe07a8f27
>> compiler:       gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
>>
>> Unfortunately, I don't have any reproducer for this issue yet.
>>
>> Downloadable assets:
>> disk image:https://storage.googleapis.com/syzbot-assets/0fc53904fc08/disk-ec87f054.raw.xz
>> vmlinux:https://storage.googleapis.com/syzbot-assets/aee64718ea5c/vmlinux-ec87f054.xz
>> kernel image:https://storage.googleapis.com/syzbot-assets/d3b6d3f4cfbc/bzImage-ec87f054.xz
>>
>> IMPORTANT: if you fix the issue, please add the following tag to the commit:
>> Reported-by:syzbot+0c06ba0f831fe07a8f27@syzkaller.appspotmail.com
>>
>> ================================================================================
>> UBSAN: array-index-out-of-bounds in ./include/linux/bpf_mprog.h:292:24
>> index 4294967295 is out of range for type 'bpf_mprog_fp [64]'
>> CPU: 1 PID: 13232 Comm: syz-executor.1 Not tainted 6.5.0-rc2-syzkaller-00573-gec87f05402f5 #0
>> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2023
>> Call Trace:
>>   <TASK>
>>   __dump_stack lib/dump_stack.c:88 [inline]
>>   dump_stack_lvl+0x125/0x1b0 lib/dump_stack.c:106
>>   ubsan_epilogue lib/ubsan.c:217 [inline]
>>   __ubsan_handle_out_of_bounds+0x111/0x150 lib/ubsan.c:348
>>   bpf_mprog_read include/linux/bpf_mprog.h:292 [inline]
>>   bpf_mprog_fetch kernel/bpf/mprog.c:307 [inline]
>>   bpf_mprog_detach+0xcd7/0xd50 kernel/bpf/mprog.c:381
>>   tcx_prog_detach+0x258/0x950 kernel/bpf/tcx.c:78
>>   bpf_prog_detach kernel/bpf/syscall.c:3877 [inline]
>>   __sys_bpf+0x36ee/0x4ec0 kernel/bpf/syscall.c:5357

Was able to repro, fix + selftest is here:
https://lore.kernel.org/bpf/20230804131112.11012-1-daniel@iogearbox.net/

Thanks,
Daniel