Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp3545885rwo; Fri, 4 Aug 2023 06:36:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG2Z7vPSChdpKjT9aBhYN3TTPQdONFPskE01HmjLFrA/83Svll3aoapzhaY1U3phW8EUqx+ X-Received: by 2002:a05:6a20:158e:b0:13f:83a3:828a with SMTP id h14-20020a056a20158e00b0013f83a3828amr2240995pzj.33.1691156193184; Fri, 04 Aug 2023 06:36:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691156193; cv=none; d=google.com; s=arc-20160816; b=YS3Uf22K8xBRVnJ7ba4d7YQ7FXMyIjLOG8E17l0EEwCN3/LJvZDpfVonmccTMQ456O QkwW4QzADwadTpXQKeJUs/yVx12YQ749JRRHck3KY6ME6uEBc5rnPFBTa3miOiRjK1M/ eoBD/05u32QcWjcXouxPc57u2BI/K9thZAoBpK+9ZsNs01SPVqXqS0rAWeDB3pFtd5nY C413v1qEoG+iEw27PGzl81STguobcSNDz1lmKkt7Tsm/0PIrBO7lOPMmkYuig4Nz1gAs oRdrKFGaZtJ28CjItdp6p8eXuNrtCV/PM1hTnKIr2qegA/XH4p8yvQQ3sr9Jnq2TErl5 DHYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=lL9KNV6Nlao75bh/qHHdg8Ac/fLA4dQMcsyJJ5Bs680=; fh=DTjBfGlDDMu4eHtePKaPs55kWT5jrJuPaRHp4wZ0zuk=; b=isDG2a48mVInDOTOQtAiNOpokLmgNvSPprtVMJJc6tR8+k4iYfst2BklF6kPBT2bT0 YWhEqF7KPvuDeMCILmzxz28CDpDLs/jhur47Dr3BYR9G/KbsCyJlER3CcMCGt/XN1AeZ HFWx3+7axI08i0xBPvz19o61O8aaaPrZ/1a2XLFDZgbCmi6mRVjmO1rahvtDdh7eMlEj serm3Bph/PKZDHe3autEVn55VtO86Rmr+oOhMtDWLXGknxsCMb96JVHYEwRqcMqhn729 8Dq+FRazG2yIi60GjCxG5TiLYBe8XcWRt0KFFXZNjJsis/jLs+R2rG63PsgxOYlT6s8A KruQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="D1Ep/aX1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f10-20020a63de0a000000b0055b82bb0bbdsi1809558pgg.879.2023.08.04.06.36.20; Fri, 04 Aug 2023 06:36:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="D1Ep/aX1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230229AbjHDNFq (ORCPT + 99 others); Fri, 4 Aug 2023 09:05:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229941AbjHDNFo (ORCPT ); Fri, 4 Aug 2023 09:05:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65F8546BD; Fri, 4 Aug 2023 06:05:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ED21F61FE5; Fri, 4 Aug 2023 13:05:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D31FCC433C8; Fri, 4 Aug 2023 13:05:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691154336; bh=CMmrQBOMwR0aByOYeSTrPYxAkxl+tK2+Yy4ucbFVepY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D1Ep/aX1YfrLsVLG16EHNKOMgzJDmwOS7a3oXTfVP4t5UZ98vesrovc3AqG/nV+ua zkRweltGyiyd5druyJ+Cydf/yV+EcdLmBC6exbz0mqYMM5OGXGBwCgiADB1WA88qtm fucdckWGxZF46V/XbPfI42XaT5T1/9q/XTwinVI8= Date: Fri, 4 Aug 2023 15:05:33 +0200 From: Greg Kroah-Hartman To: Valentin Caron Cc: Jiri Slaby , Alexandre Torgue , Amelie Delaunay , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 6/6] serial: stm32: synchronize RX DMA channel in shutdown Message-ID: <2023080414-props-senior-c40a@gregkh> References: <20230803130134.155355-1-valentin.caron@foss.st.com> <20230803130134.155355-7-valentin.caron@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230803130134.155355-7-valentin.caron@foss.st.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 03, 2023 at 03:01:34PM +0200, Valentin Caron wrote: > From: Amelie Delaunay > > In shutdown, RX DMA channel is terminated. If the DMA RX callback is > scheduled but not yet executed, while a new RX DMA transfer is started, the > callback can be executed, and then disturb the ongoing RX DMA transfer. > To avoid such a case, call dmaengine_synchronize in shutdown, after the > DMA RX channel is terminated. > > Signed-off-by: Amelie Delaunay > --- You can't forward on a patch from someone else and not sign-off on it yourself :( Please fix up and resend the series. thanks, greg k-h