Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230804132800.2270896-1-arnd@kernel.org> <20230804132800.2270896-2-arnd@kernel.org>
In-Reply-To: <20230804132800.2270896-2-arnd@kernel.org>
From:   Doug Anderson <dianders@chromium.org>
Date:   Fri, 4 Aug 2023 07:06:26 -0700
Message-ID: <CAD=FV=Wn20c3=TjNnqOvt2n61q8d3AaJHFGboGfog2rq7UYARg@mail.gmail.com>
Subject: Re: [PATCH 2/2] watchdog/hardlockup: simplify Kconfig selection
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Petr Mladek <pmladek@suse.com>, Arnd Bergmann <arnd@arndb.de>,
        Kees Cook <keescook@chromium.org>,
        David Gow <davidgow@google.com>,
        "Liam R. Howlett" <Liam.Howlett@oracle.com>,
        Miguel Ojeda <ojeda@kernel.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Zhaoyang Huang <zhaoyang.huang@unisoc.com>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Fri, Aug 4, 2023 at 6:28=E2=80=AFAM Arnd Bergmann <arnd@kernel.org> wrot=
e:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The use of the 'imply' keyword tends to be a bad idea, as it's at best
> confusing to the reader but often actually doesn't do what the author
> intended.
>
> In this case, it seems to be used correctly, but doing the same thing
> using 'default' statements as we have elsewhere in the kernel is simpler
> and would be easier to understand by readers that are unfamiliar with
> the special semantics of 'imply'.
>
> Fixes: 1356d0b966e7e ("watchdog/hardlockup: make the config checks more s=
traightforward")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> I got confused by the 'imply' here myself and thought this had caused
> a build failure that turned out to be unrelated, but it might help
> to apply this anyway to save the next person the confusion.
> ---
>  lib/Kconfig.debug | 14 ++++----------
>  1 file changed, 4 insertions(+), 10 deletions(-)

Seems reasonable to me.

Reviewed-by: Douglas Anderson <dianders@chromium.org>