Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fcb8f03e-bad1-966c-d454-b7ef7cb62454@amd.com>
Date:   Fri, 4 Aug 2023 19:38:36 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: Regression apparently caused by commit
 088a40980efbc2c449b72f0f2c7ebd82f71d08e2 "ASoC: amd: acp: add pm ops support
 for acp pci driver"
Content-Language: en-US
To:     Marian Postevca <posteuca@mutex.one>
Cc:     broonie@kernel.org, alsa-devel@alsa-project.org,
        Vijendar.Mukunda@amd.com, Basavaraj.Hiregoudar@amd.com,
        Sunil-kumar.Dommati@amd.com, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Yang Yingliang <yangyingliang@huawei.com>,
        Venkata Prasad Potturu <venkataprasad.potturu@amd.com>,
        V sujith kumar Reddy <Vsujithkumar.Reddy@amd.com>,
        ye xingchen <ye.xingchen@zte.com.cn>,
        linux-kernel@vger.kernel.org
References: <87a5v8szhc.fsf@mutex.one>
From:   syed saba kareem <ssabakar@amd.com>
In-Reply-To: <87a5v8szhc.fsf@mutex.one>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?czJGV0wwRENoQS8xMWhZY0hhYXZIcGtYODloTHA0aUcvSlNrVUtydE43V2M2?=
 =?utf-8?B?RzhQbGswbHdtcFhtZkhodXFBQkNldnU0clYrRjhSMWh2bGZJRDBDa2tPd3Bs?=
 =?utf-8?B?WW9LVnEyaFhDREtRbFd4Y1M5NkRYdmUzNEJUUTEvb1VvaHRKUGoxT1k2ek45?=
 =?utf-8?B?cG9KYmZad1ZmdVNYamJ2RGVYbWRJMXZERDRFc3ZmMkh0Q09rd0xUNkJlNFZN?=
 =?utf-8?B?cUlOZ2c1SFR0RGx6ckxLZldFU3dEOXBpRkRZeUVHZ1RUMDdReGUzbFpWRFVp?=
 =?utf-8?B?Wkh4T01pcWpQRy9UMlJ1L0ZKU09VL0w2WWxaL2lHZkZzQmhTN095clRqdjRP?=
 =?utf-8?B?UlN6ZlpSVDJxb0xwZEVFTEFldHFnamsrL2pzcWRwbG1YcXBDZVZJYUpXVlpv?=
 =?utf-8?B?ZUdaSk9ieDZMcDdLamhMdDJvcVNiaHVWUjNsOTF6dVdMbmFNU3ZIdVpHbUhG?=
 =?utf-8?B?MmJUMTVsUysyMXlNVDR0RWNIY01OTGNiK3ZKWS9ReXREY1k5SWVXQlFmNHBI?=
 =?utf-8?B?L3BxMUxyY1ZMU2R2Q3ZUZG1OQnhqTldaeGdqMEExMkRzcEtKaXpEbUhudjRk?=
 =?utf-8?B?bThyd0JJSnQydVdkM1pGZ2ZNN0xFM1M3VHM3cDQ1NFdRSnB0Z0dxRVpmTGlr?=
 =?utf-8?B?TURsSzZFSUhtOGk0MTF4YnZXY1NCWWNoZWxtYjh3ak9OZDNGWC93YlQzVUsw?=
 =?utf-8?B?SlJzQzFpekZLc0l5UmtuUUNoUmwrYWpEczhtRFRVK2lnbkJtVGt1d1NSSmNB?=
 =?utf-8?B?cUx6N3JWOTlzVGhMSEsrRkt5bXhSekp3TnZQekJBQXpqZ0tqYTB5RHAzZ21N?=
 =?utf-8?B?ZmZjWVljL3lqQTZ1OEVCZXg5LzJiU3YrRU5YQTlNU0gwQ3FsdjR2RExRL1o1?=
 =?utf-8?B?Z0kyaWxLUXhCVldXM0RIcnZpQml6c3RCdVZieFdOZmloaStkbUVWQmtVRkpm?=
 =?utf-8?B?QmdVVWo2Vmt0QlU4WEEveFNFKzkrS3BYSEg0Y3dXakNTWnNiNFJ4V2FKM3ZL?=
 =?utf-8?B?Zlp2KzJtWG9reFFZMitiQUZPNm5mSG5CbmhlZGhCNndQeHk4Wnd1V2Iwc0lj?=
 =?utf-8?B?RVRTSmoyVUZCcXlJRmhmdDBqUzZ5SFlaZ01pcTNRd0U0QUhmYkFXOWFvWFU1?=
 =?utf-8?B?ZVJCL3Z0c3R3eU1MVFhaaXEvU2hJNnNuUUZ5TytORURoZys0dFVhQjNTcllv?=
 =?utf-8?B?eE00MjZZNHlqaTZ6NXpsdkNoT0pjckJBY3VCZ0loSTZCbk8vWGNRb25teTVo?=
 =?utf-8?B?OWFqTFdpbmJvTWhoQy9lbVEyR0pJcEhYVkFybGpEN2hFdC9HNkpuMTk5aGpt?=
 =?utf-8?B?Z3JidFR5Nm5uUVE5bTVieHVISXZrQ085NThxUVYrbUdhTXFjcVg5NkQvd2lG?=
 =?utf-8?B?ZUMyVG5qeUhZcGcrR2lUa2UwR0NKbUtERkVuSFcyZ1VDaWlyY25uSnFxVHM0?=
 =?utf-8?B?dWltVy9mKzg1bzl2a25veFkrQ3ZKc3BpeGVtVmxLcXQyQkNsNXl1b0RWNVlN?=
 =?utf-8?B?Sm9xazM2cyt2R0Q1cUROWEZXR01WWExQU3U2VFZiVUErcjdSNVExa1crSElj?=
 =?utf-8?B?WS9oOXYzZ3BDSURlZE1mUnR4K0NvcWcxYXRyRXB6TW1tYzNNNTdYbkZEd05t?=
 =?utf-8?B?SVdNcThFc1JHTUk3dklVNVBEZ3g4UjlHUUlQNndJQU1Hdk5sUUFtUjdHV2tP?=
 =?utf-8?B?bHdTU2pyY2FIcjN2ZUhPMWhvaTFvNGJCM2pGN3RKRFRjakEzTVhPWGxOTG1B?=
 =?utf-8?B?OFBJMGdJeEF6THdjd2t2dTF6NVNwNkIwQzdCQnQ3Um1Gem5LZVVDQ0tML3Jl?=
 =?utf-8?B?eGZFZ2R6T2JmT3BJWGFFUE53QklKZG1pQjdIVmtGM01mS2F3OUxSOU5FSm5W?=
 =?utf-8?B?Sm5DdzIyWndUcXhSVU83Mk0wM2xWeFhxWXdYTzRTVmlXS01QZGNUZk5ZY1JG?=
 =?utf-8?B?MVpCalc3VFdlbUpZR3d0eEhFSHJrQ0kxM0lkTU1teHNxUmtkMEJPaFY3YmxT?=
 =?utf-8?B?ZzZKaTJKWHVlaUtLOGlOMnpLWWE2cEIycXNCT2pwdWVhN0tZaGJDNzFNUm4w?=
 =?utf-8?B?aUtkUHZYWUIzNUMvU1NhTDFBQnFoYVJJdmxGN3YrK2pNY1M3bDB6RlBWK1pF?=
 =?utf-8?Q?Vt773FjGO4+mwZTcSFG0Xz1po?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 94a3e681-f220-4aed-f13a-08db94f453be
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3661.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 14:08:50.5628
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HjzXeur0YnAI77EIpfDaM/HNSRrcaoWUCBvPNZfoaMw7FNOi3vXyoHOX9GNdrFSUkxsvcJkZ5dSpAbAine266Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7737
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/4/23 00:52, Marian Postevca wrote:
> I'm trying to develop a sound machine driver based on the acp legacy driver.
> The first version of the driver was sent for review on the alsa mailing list this
> spring: https://lore.kernel.org/all/20230320203519.20137-1-posteuca@mutex.one
>
> I'm trying to fix some of the issues that were brought up during the review back then,
> but when I ported the patches to the latest commit on the for-next
> branch, I noticed a regression where I couldn't hear any sound at all.
>
> So I started a bisect session and found that the first bad commit is:
> ASoC: amd: acp: add pm ops support for acp pci driver
> commit 088a40980efbc2c449b72f0f2c7ebd82f71d08e2
> https://lore.kernel.org/lkml/20230622152406.3709231-11-Syed.SabaKareem@amd.com
>
> If I revert this commit sound works as expected. So I started tinkering a little bit
> with it and I believe that what happens is that the acp pci driver
> enters the autosuspend state and never leaves this state at all.
> I noticed this because if I increase the autosuspend delay to a much
> larger value, then the sound works until that delay passes.
> I added traces and I can see that when the delay expires the suspend callback snd_acp_suspend()
> gets called, but the resume callback snd_acp_resume() never gets called.
>
> I'm no expert in runtime power management (though I did read a bit on it), so I don't understand
> all the things that happen underneath, but one thing that is not clear to me is who's supposed
> to mark activity on this device and keep it from entering autosuspend if the user wants to play
> some sound? Shouldn't there be some counterpart that calls pm_runtime_mark_last_busy() ?
> I looked through the code and can't find who's calling pm_runtime_mark_last_busy().
>
> Some help here would be welcome. Is there something missing in my machine driver code, or
> is the runtime pm handling in acp pci driver wrong?

We haven't up streamed pm ops for Renoir platform.

That is the cause for the issue.

Will upstream them in a week.