Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp3651790rwo; Fri, 4 Aug 2023 07:59:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHaBLPqUeG6s/yryFla0BbKbj7xyvq2FXY3g05FbyrSZWNHmqAoAuhCy0CnSCeRE6X9VXZ/ X-Received: by 2002:a17:906:8a4e:b0:992:ef60:ab0d with SMTP id gx14-20020a1709068a4e00b00992ef60ab0dmr1621901ejc.69.1691161171540; Fri, 04 Aug 2023 07:59:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691161171; cv=none; d=google.com; s=arc-20160816; b=pVNhE5BEpFm0+qVOFLQ3RF1VdCtMEAr+P+wtC9CVEcdiQRX9mp3VmkFM2In6ZrrE+s +TEeJIBiNFYlOnOWClOp7W/Z8PjNfHQVJwRjkInX+8PzzWNTodJPDdmBxSo3t5MzHd4z ye7Pmotk37fTDfD5bLvFe3bIKGvStCWzJXk+OXwGJhr+EftIqBJma18DFZ67yXFyvojs Mtj1iK8HqJqmio+9xEXAz7bEE/O53QptMoDZ7/CpALilI7/T44YN3CBswl9hw9nOUWmT OGKUBlxjW5w6YOsMudkoIFHf1BjxcUZm4khXTj5Iyc8bU42FuGl+5n2Tvy/A3RMMc3Xy yhFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=IhTlRbp2//7s3DolX7VO9KgMBgCGD0vXsW/sKLyveZ0=; fh=1j0RggkCOC09vfdatd6V6VH//dVkrbIpnjoH3HzIunI=; b=JnwcUocG61+xBmW+tKpTHmxekgGtIdjEwWJjqBAaMuKkjRATe60HvIcxHv/VAFn5sy fdxzAwoKqz2jWKl9VQbhLVCijDSbyOuZDjDtfwDIGFNR1WNsouPOBKGpQIVBjkWor73C lBKMUFbw9hv5iNxqJWnCBG4Eu5xTTv5tTaPWNDZAhXWBao5pZIJv9P5s90T2n3FNGvnY e5E9S7AY1yx48K3R7Sds08ggecMEYDbaOs9AXrGRD7t48ykzQSgLKVlti+IUNgmjlh20 rVM7q8F8FB9ocxgQly+6crVp4zrsdOj4JVFGHYx01rT8+vmIPJnwVcLCJUqOUavTByqq oRtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RuYw7+Dx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l15-20020a1709060e0f00b009938cb10849si1423592eji.111.2023.08.04.07.59.05; Fri, 04 Aug 2023 07:59:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RuYw7+Dx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230142AbjHDNYO (ORCPT + 99 others); Fri, 4 Aug 2023 09:24:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231698AbjHDNXo (ORCPT ); Fri, 4 Aug 2023 09:23:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27F7649E1 for ; Fri, 4 Aug 2023 06:22:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C1EF161FE4 for ; Fri, 4 Aug 2023 13:21:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D19B9C433C8; Fri, 4 Aug 2023 13:21:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691155310; bh=XJa6I1bwCmmRMLQnibGWH5nBJOa4fCDitx42YrwLs6c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RuYw7+DxRUXTtjN3QZHHKDWP09+eOl016mq7VtsNUeVUceV+jZsFz4vWhYuPie4tp 82lVzCc92yEWbUuUm5mhdOTFYABEAiyx0qPX7kXIGolMbTjDG273UzmWv6YdXf2607 UuzJQNt4lzelNrmcqNfxtxCn9Y7VnvPt2O/M7XRk= Date: Fri, 4 Aug 2023 15:21:47 +0200 From: Greg Kroah-Hartman To: Pavan Bobba Cc: Forest Bond , Michael Straube , Philipp Hortmann , outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: vt6655: replace camel case by snake case Message-ID: <2023080431-rethink-smog-c029@gregkh> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 04, 2023 at 05:52:25PM +0530, Pavan Bobba wrote: > Replace array name of camel case by snake case. Issue found > by checkpatch > > Signed-off-by: Pavan Bobba > --- > drivers/staging/vt6655/baseband.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c > index 0e135af8316b..8b913c64845c 100644 > --- a/drivers/staging/vt6655/baseband.c > +++ b/drivers/staging/vt6655/baseband.c > @@ -499,7 +499,7 @@ static const unsigned char by_vt3253_init_tab_rfmd[CB_VT3253_INIT_FOR_RFMD][2] = > }; > > #define CB_VT3253B0_INIT_FOR_RFMD 256 > -static const unsigned char byVT3253B0_RFMD[CB_VT3253B0_INIT_FOR_RFMD][2] = { > +static const unsigned char byvt3253b0_rfmd[CB_VT3253B0_INIT_FOR_RFMD][2] = { > {0x00, 0x31}, > {0x01, 0x00}, > {0x02, 0x00}, > @@ -2005,8 +2005,8 @@ bool bb_vt3253_init(struct vnt_private *priv) > } else { > for (ii = 0; ii < CB_VT3253B0_INIT_FOR_RFMD; ii++) > result &= bb_write_embedded(priv, > - byVT3253B0_RFMD[ii][0], > - byVT3253B0_RFMD[ii][1]); > + byvt3253b0_rfmd[ii][0], > + byvt3253b0_rfmd[ii][1]); > > for (ii = 0; ii < CB_VT3253B0_AGC_FOR_RFMD2959; ii++) > result &= bb_write_embedded(priv, > -- > 2.34.1 > > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot