Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230804132800.2270896-1-arnd@kernel.org>
In-Reply-To: <20230804132800.2270896-1-arnd@kernel.org>
From:   Doug Anderson <dianders@chromium.org>
Date:   Fri, 4 Aug 2023 07:03:04 -0700
Message-ID: <CAD=FV=WL5JjwbZ86De1GY_0-_j4C0emP652z0ZanDfv-qikeaw@mail.gmail.com>
Subject: Re: [PATCH 1/2] watchdog/hardlockup: avoid unused-function warning
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Petr Mladek <pmladek@suse.com>, Arnd Bergmann <arnd@arndb.de>,
        Pingfan Liu <kernelfans@gmail.com>,
        Lecopzer Chen <lecopzer.chen@mediatek.com>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Fri, Aug 4, 2023 at 6:28=E2=80=AFAM Arnd Bergmann <arnd@kernel.org> wrot=
e:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The newly added hardlockup_all_cpu_backtrace_proc_handler() function is d=
efined
> in some configurations that don't actually call it:
>
> kernel/watchdog.c:112:12: error: 'hardlockup_all_cpu_backtrace_proc_handl=
er' defined but not used [-Werror=3Dunused-function]
>   112 | static int hardlockup_all_cpu_backtrace_proc_handler(struct ctl_t=
able *table, int write,
>       |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Hide the definition when either CONFIG_SMP or CONFIG_SYSCTL are disabled =
and
> the function is not actually needed.
>
> Fixes: 838b3b76220d5 ("watchdog/hardlockup: avoid large stack frames in w=
atchdog_hardlockup_check()")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  kernel/watchdog.c | 2 ++
>  1 file changed, 2 insertions(+)

Thanks for the fix. In this case I'll assume that Andrew will drop the
v2 of my patch and replace it with v4 [1], which shouldn't have this
issue.

[4] https://lore.kernel.org/r/20230804065935.v4.2.I501ab68cb926ee33a7c87e06=
3d207abf09b9943c@changeid