Received: by 2002:ac8:71d8:0:b0:40f:fb00:664b with SMTP id i24csp202380qtp; Fri, 4 Aug 2023 08:29:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGDLhp7ng93RnvDDws+GyxhTwy1AE6xOUIoHjxID+Nq13wbEQBCtFyJ8AMSrSaxVBsy+A2F X-Received: by 2002:a2e:998c:0:b0:2b9:ebbd:be72 with SMTP id w12-20020a2e998c000000b002b9ebbdbe72mr1849184lji.13.1691162948678; Fri, 04 Aug 2023 08:29:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691162948; cv=none; d=google.com; s=arc-20160816; b=EvFgk3ewnFGh/wIdl2faKHT1Dtx4MvLoeBYLsqgwG7clAb6C/ES/jdI+kI0n8ffnN9 VyF0DodohIu06EH+8wgRp+VT4y23JvDusce29ggHjs4SBMrp3xv7P2o/RXunW2LFyP7V pXG1+c+6vKFJAGmgzgGqGQlnOTupmk5dfi1Y3D1BEphs9kwqXtsz9LtiqRabHF1DhLBg CQEWI/fY5wMeECgpgipEA8edCfwtXpIlY7M0W9+r9CvrvVKWC89cse4CENUlZg32HPYB oh88Gm92idF3OT6/DwkwPMcsw6FemLRG4pzuQtDCIvLIzVO1W0gLs6/vSTdJsxzB7eYE GySA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=pmti4NNUS1ApwuYq96D8Bd0UZfIiM3Ql7dHgirNSqxk=; fh=b3XA6M+6AkBI21oNq+LLEsMu5OYx5n2imhLY3o241lc=; b=wH5+arnLxDo5E4AhTvYL6EcSbP2o0u8XnKFD++d96YrJvxnjuoyKiRThCJX9bQQBmo Oymb83opZFnYP9KCLcWDnzsN8gbWC2kYBSgkk2zK9cNazBgek+4Przhof8BhIxfxqrMp LnrY15FRhn8HOTu07zqNp/g/+haViSZvNlbEW1IWBMeZITPSMrJb8V/YLc2NGNe2xNFG B2Ad/gs3Le2EuSo5zjYO4qez/EjCc5hIscc/CBZ6ZZxzxNVH+0BC9gXpy0nmq9E+YSbw TKgKpCNN3IepPBWhc340asy/kkQOviJqOa83voM9XCVLodjVzltEF6tUsa6jeFupun/D QQBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=L9tjcmRT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j19-20020a170906255300b00991ece4c966si1882662ejb.101.2023.08.04.08.28.17; Fri, 04 Aug 2023 08:29:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=L9tjcmRT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230136AbjHDO46 (ORCPT + 99 others); Fri, 4 Aug 2023 10:56:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229848AbjHDO45 (ORCPT ); Fri, 4 Aug 2023 10:56:57 -0400 Received: from pandora.armlinux.org.uk (unknown [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE2F446B2; Fri, 4 Aug 2023 07:56:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=pmti4NNUS1ApwuYq96D8Bd0UZfIiM3Ql7dHgirNSqxk=; b=L9tjcmRToHJFGAcWP5RNR9Qfbr 98p7RiUW2tXYzTpja3e+G3DH+x4o9RKcZpSQ29M7UwNV1bzKL5uzEr+M2TlDaZXrglHk9hmzimPpn GvpjQ4LoQH1eo16iBaSgiJDqxjcxwAQKllqRI44MctmIaa1HpIY+vSkN5aSTWKACFLIWpPvsO7l76 AW0bkOll2I4PE4T29AYkhYIoAz3aka8PGM16Zozi2DWuyUDL+jmwdiP5oPkL2sPvl62v+cEeahpxm MFPq/w15wNwp/VQbABw4ysosIpydvcPFLDIJ75Jvo7OsTVG+5RlZ4QCU3HA7UHwSjmlx93BbDFV5o O4sSf8cQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56838) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qRwE5-0000LY-0e; Fri, 04 Aug 2023 15:56:25 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qRwDz-00044X-52; Fri, 04 Aug 2023 15:56:19 +0100 Date: Fri, 4 Aug 2023 15:56:19 +0100 From: "Russell King (Oracle)" To: Shenwei Wang Cc: Marc Kleine-Budde , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Shawn Guo , Sascha Hauer , Neil Armstrong , Kevin Hilman , Vinod Koul , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Jerome Brunet , Martin Blumenstingl , Bhupesh Sharma , Nobuhiro Iwamatsu , Simon Horman , Andrew Halaney , Bartosz Golaszewski , Wong Vee Khee , Revanth Kumar Uppala , Jochen Henneberg , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, imx@lists.linux.dev, Frank Li Subject: Re: [PATCH v4 net-next 2/2] net: stmmac: dwmac-imx: pause the TXC clock in fixed-link Message-ID: References: <20230804144629.358455-1-shenwei.wang@nxp.com> <20230804144629.358455-3-shenwei.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230804144629.358455-3-shenwei.wang@nxp.com> Sender: Russell King (Oracle) X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,RDNS_NONE, SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 04, 2023 at 09:46:29AM -0500, Shenwei Wang wrote: > + if (dwmac->ops->fix_soc_reset) > + plat_dat->fix_mac_speed = dwmac->ops->fix_mac_speed; The if() condition looks like a typo to me. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!