Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 4 Aug 2023 16:28:28 +0100
From:   Conor Dooley <conor@kernel.org>
To:     marius.cristea@microchip.com
Cc:     jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] Adding support for Microchip MCP3564 ADC family
Message-ID: <20230804-doze-confining-edf4f50d736d@spud>
References: <20230804142820.89593-1-marius.cristea@microchip.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="69mBrM4Ph1nZWzIB"
Content-Disposition: inline
In-Reply-To: <20230804142820.89593-1-marius.cristea@microchip.com>
Precedence: bulk


--69mBrM4Ph1nZWzIB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Aug 04, 2023 at 05:28:18PM +0300, marius.cristea@microchip.com wrot=
e:
> From: Marius Cristea <marius.cristea@microchip.com>
>=20
> Adding support for Microchip family of 153.6 ksps, Low-Noise 16/24-Bit
> Delta-Sigma ADCs with an SPI interface. This driver covers the following =
part
> numbers:
>  - MCP3561, MCP3562, MCP3564, MCP3561R, MCP3562R, MCP3564R,
>  - MCP3461, MCP3462, MCP3464, MCP3461R, MCP3462R and MCP3464R.
>=20
> Differences related to previous patch:
> v3:
> - fix review comments:
>   - fix and update the device tree bindings
>   - enable "auto_zeroing_ref_enable" attribute only
>     when internal reference is used
>   - remove unused headers
>   - fix comments (kernel-docs)
>   - remove scan_type
>   - replace "extend_name" with read_label
>   - print label for each channel (label could be added into the dt)
>   - add comment to explain the maximum channels numbers
>   - add protection around critical region

>   - fallback compatible in device tree to deal with some newer part number

The compatibles are all still in an enum in the binding with no
fallbacks. Did you forget to commit this?

Thanks,
Conor.

>  =20
> - Open questions:
>   - whether or not to add a spi-mux type of thing to deal with the part n=
umber
>     address in case there are multiple devices connected to the same chip
>     select.
>   - discussion related to the "custom property". Last time around a conse=
nsus
>     wasn't reached.=20

--69mBrM4Ph1nZWzIB
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZM0ZHAAKCRB4tDGHoIJi
0mUTAP46a8eRFu3rukoDmNmwgNsOmobBPRGPtSnMPkJ2r8SheAD/W9l5IqLR9bCU
8r04SbrY9ic7HyKnNjjRj6HQTQXQfwc=
=sF9v
-----END PGP SIGNATURE-----

--69mBrM4Ph1nZWzIB--