Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 4 Aug 2023 16:48:35 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Naresh Solanki <naresh.solanki@9elements.com>
Cc:     Guenter Roeck <linux@roeck-us.net>,
        krzysztof.kozlowski+dt@linaro.org,
        Jean Delvare <jdelvare@suse.com>,
        Rob Herring <robh+dt@kernel.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Marcello Sylvester Bauer <sylv@sylv.io>,
        linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: hwmon: Add MAX6639
Message-ID: <20230804-tamper-numbness-0117bb53a921@spud>
References: <20230803144401.1151065-1-Naresh.Solanki@9elements.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="sN8NPFS9+3FUypYE"
Content-Disposition: inline
In-Reply-To: <20230803144401.1151065-1-Naresh.Solanki@9elements.com>
Precedence: bulk


--sN8NPFS9+3FUypYE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Aug 03, 2023 at 04:43:59PM +0200, Naresh Solanki wrote:
> From: Marcello Sylvester Bauer <sylv@sylv.io>
>=20
> Add binding documentation for Maxim MAX6639 fan-speed controller.
>=20
> Signed-off-by: Marcello Sylvester Bauer <sylv@sylv.io>
> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
> ---
> Changes in V3:
> - Update title
> - Add pulses-per-revolution, supplies & interrupts
> Changes in V2:
> - Update subject
> - Drop blank lines
> ---
>  .../bindings/hwmon/maxim,max6639.yaml         | 60 +++++++++++++++++++
>  1 file changed, 60 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639=
=2Eyaml
>=20
> diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml b=
/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml
> new file mode 100644
> index 000000000000..b3292061ca58
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml
> @@ -0,0 +1,60 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/maxim,max6639.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim MAX6639 Fan Controller
> +
> +maintainers:
> +  - Naresh Solanki <Naresh.Solanki@9elements.com>
> +
> +description: |
> +  The MAX6639 is a 2-channel temperature monitor with dual, automatic, P=
WM
> +  fan-speed controller.  It monitors its own temperature and one external
> +  diode-connected transistor or the temperatures of two external diode-c=
onnected
> +  transistors, typically available in CPUs, FPGAs, or GPUs.

> +  fan-supply:
> +    description: Phandle to the regulator that provides power to the fan.

> +  pulses-per-revolution:
> +    description:
> +      Define the number of pulses per fan revolution for each tachometer
> +      input as an integer.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [1, 2, 3, 4]
> +    default: 2

Apologies if I am digging up old wounds here, since there was quite a
bit of back and forth on the last version, but these two newly added
properties look to be common with the "pwm-fan" and with
"adi,axi-fan-control". At what point should these live in a common
schema instead?

Otherwise, this looks okay to me, although I'll leave things to
Krzysztof since he had a lot to say about the previous version.

Thanks,
Conor.

--sN8NPFS9+3FUypYE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZM0d0wAKCRB4tDGHoIJi
0mH7AQDBInAjsrZfZac0XzETGrZ+PttnYaYh09UYHDLHd39geQD9GnXkAmCktfbd
YjgvCATLL8jElmPIYkCiFurNDe/w1w8=
=Aesl
-----END PGP SIGNATURE-----

--sN8NPFS9+3FUypYE--