Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 4 Aug 2023 17:28:39 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Mihai Sain <mihai.sain@microchip.com>
Cc:     claudiu.beznea@tuxon.dev, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        nicolas.ferre@microchip.com, cristian.birsan@microchip.com,
        alexandre.belloni@bootlin.com, andre.przywara@arm.com,
        jerry.ray@microchip.com, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        andrei.simion@microchip.com
Subject: Re: [PATCH] ARM: dts: at91: sama5d29_curiosity: Add device tree for
 sama5d29_curiosity board
Message-ID: <20230804-starlet-facebook-051f59b7eac8@spud>
References: <20230804101043.4063-1-mihai.sain@microchip.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="3cETkHcmawoyHVtG"
Content-Disposition: inline
In-Reply-To: <20230804101043.4063-1-mihai.sain@microchip.com>
Precedence: bulk


--3cETkHcmawoyHVtG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey,

Firstly, $subject is missing a "v2" inside the []s.

On Fri, Aug 04, 2023 at 01:10:43PM +0300, Mihai Sain wrote:
> Add initial device tree file for sama5d29_curiosity board.
>=20

> Changes in v2:
> * drop dt-bindings patch
> * remove vdd_1v8 regulator
> * fix flx4 node to use 1 spi node and pinctrl
> * add i2s0 node and pinctrl
> * remove macb0 node and pinctrl
> * remove unused pinctrl
> * sort in alphabetical order all nodes and pinctrl
> * replace "_" with "-" in node names

This needs to go under the --- line, not in the commit message.
Perhaps Claudiu would be willing to fix it, but certainly for future
versions this needs fixing.

Thanks,
Conor.

>=20
> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
> ---

--3cETkHcmawoyHVtG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZM0nNwAKCRB4tDGHoIJi
0qpFAP0dvR3rR5cvo1cZf8PSoYD6jjtkTE83eX9MDV/YBcP/rgD9HX0MuOQvUCoE
7pxqltI/1So3HdQ5Yol2t12Ph4t3Zgk=
=/m9X
-----END PGP SIGNATURE-----

--3cETkHcmawoyHVtG--