Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1606f9f9-5d5a-788d-b058-ec218fb73712@amd.com>
Date:   Fri, 4 Aug 2023 11:03:04 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 3/3] EDAC/amd64: Add support for AMD Family 1Ah Models
 00h-1Fh and 40h-4Fh
Content-Language: en-US
To:     Yazen Ghannam <yazen.ghannam@amd.com>,
        Avadhut Naik <avadhut.naik@amd.com>, bp@alien8.de,
        linux@roeck-us.net, x86@kernel.org, linux-hwmon@vger.kernel.org,
        linux-edac@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, avadnaik@amd.com
References: <20230706171323.3722900-1-avadhut.naik@amd.com>
 <20230706171323.3722900-4-avadhut.naik@amd.com>
 <e5b0063a-ae41-41ab-b3a7-2084dfa7f816@amd.com>
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <e5b0063a-ae41-41ab-b3a7-2084dfa7f816@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Wmc1NzNhMWhwV1JUY2xwMklEeVM5Sis5ejdYYUZ5ZmlHWVNPUWxBTW9YVEdF?=
 =?utf-8?B?MXZXdllXTDF2TXZManJ6RnBRa0FsWmlGZWhRMHE2TzFKQkhzaE5GZFNPeHg0?=
 =?utf-8?B?OVJQM3FZMTBLQ0V1dGJlbkdHVHpYa1FOQjkwdmxrZXRkbVppSkZXUEZrL0VX?=
 =?utf-8?B?OGhTZTlOVTlwNzdDRTdpRXZ4bk8zaE5VVTFsallYUzlkeXR6SGthVmlScUZo?=
 =?utf-8?B?bFVuMmkxck1MRTlDYmlJQlVSMTRHTWlxZXJTUW1IRm9CeU5yTS9lUkd3TVF0?=
 =?utf-8?B?dGlLQXpOYVorVmd0Z2o4dXFCVDI0VC9UTXM3ZTlzalFkOVdCVm1Hazh4cE4x?=
 =?utf-8?B?SmhMaHkrZHQ0RzJzcGxaZ3I2UndBQXA3QjlDOXpvUHlRaFczajYyYm5DSXRn?=
 =?utf-8?B?MTF3cElLaU5qa0VINnhDcVdkS0VDWFh4ZlFvbTltVVlUL1JaNFJQZVRHM3dD?=
 =?utf-8?B?R05GUGtyQlU4cXp3UnJXaC8zMUZSdGtqQkNMNTh5cHFDaFZzUXAra0VxME91?=
 =?utf-8?B?ZHQzMURCcmc3K1dGd0s4Z1pMb091eTJlRHk1QjVGMXBrODVlZUdaQTk1cDU1?=
 =?utf-8?B?djQzeFh4TndnM0lqVWNuQ3NaeWZiK2hXQzJKczJrdFZUU013eVNYMVhieVRK?=
 =?utf-8?B?MVV0S2FFbGdtMHJMdG9LUkVWdVRQc2lIMEhVOW9YYTNOWGo3TnlOZGtQWWhk?=
 =?utf-8?B?c1lSekFZZDRoNjZiOXVBZnRsR0RBaFd6TE9DRm5HUGJ3blF0b3NkQ2NMU0lJ?=
 =?utf-8?B?a205MHZ6c2NFT1Y0ejR3dkJrbnlHN3NJR2hBaUswWHhmZEUvaEQxYTlETHZ6?=
 =?utf-8?B?NHhaNisrWGF4ODd1cE5zZkEvVmtEd04yZVpWNzdsbTBLcENrbjdYcU81SUFq?=
 =?utf-8?B?eEtQejFIeVBIaWNxc0tmMDFneUxrWjltMG45ZWxwdHFlZFBtVkx2OHJucERl?=
 =?utf-8?B?ZXh2Ync1S0NUTDIvdloyLys2NFkxaWJGdmxEWG9BNnQzNlJYRWlMMVRydS94?=
 =?utf-8?B?REZsQXJ1UUtrRDlXV2tEMFZsNEd6bFk3ZVNtODg3SjQ3WTVyNXFJWjBSZGVh?=
 =?utf-8?B?SHplN1RFSVV0cXI2MWFVeFlFSlRnbW51WGVtUUN0RnROM1FQZW9vRVA0TXdu?=
 =?utf-8?B?dDVNZEpSdUhKUEpjVnMza2VaUmFIdVB5UlYvTnBZS2tpU29IY2EyNDR0VURJ?=
 =?utf-8?B?YWQ0R1FwR2Y2MEV1NFRydyt6V0Y0MXMvYUg1NHJJNlRTRWRTWkNzNkR3MmhS?=
 =?utf-8?B?Mlo1T3ZVMWUyU3kzS0QxUVF4eE1LSnFQRy9NbXpkaHEvbXlsb0UwTCtDUGt4?=
 =?utf-8?B?SGlreUVQR0p4VDZlL1oxZ05WQmZBU1JPOWZWbjZlYXJ3YjJjZnE0Wm5ib2VB?=
 =?utf-8?B?emFtR1dzU2pYeldvT2tvMm8vbnVrYW15UDY0c1UrYmF6bHdKa2FkU2pGOHpL?=
 =?utf-8?B?UUQyNld5bkVSVzQvaDdydVlEVDZadFdaUWVEcVJiTVRUS3cvV3FyMGhudTFw?=
 =?utf-8?B?czFITXF5RVVSV0xXSGh0K1BTRTMxSEdMeEFBaHR0OFpjejVFRUpaSnJlUmtV?=
 =?utf-8?B?R09NVHVBNVVBWG5Sejh0VUJVS0d3MnFyTmlYRVZmRlVvZS9pd29iS0hESkF6?=
 =?utf-8?B?clFpdGtKV0ozbTBjc1VsdzJ6VmNUUnJ1UnpEZTN2bG1jVG41RXpSRWcyMEJ2?=
 =?utf-8?B?Mm5iY0U3SmtidUwrRGQxWGZWU0NVUDRXTDdENXBHWTI1QkNwMjVGRmVIQ1My?=
 =?utf-8?B?bkR4dlNTV3ZyUjZTZC9yN2gzTi9ocFV1V3pvNy9yU2xPQ3VYRG9vQ3g0R25P?=
 =?utf-8?B?enBpa0VMOEJvdngwZDFQNFBFaE1aTnhEZzI4UXRaTUJDS0ZJYkNiTlh5cHFx?=
 =?utf-8?B?eHhEWk53ODl1ZFo1MHlkQVFKdDlDWjNyczlLQnJyaGx0R3lPOExEZzF4SFE5?=
 =?utf-8?B?Z2NSbTdtRk5BdURrQ2pOMWJqUElLZDdDNi9UeFJGSTFFTll5NC9sbkhBZ0ZB?=
 =?utf-8?B?NjV3VWJSRHV0aHRyMUdIdzJHSVlXM2ZXVEV3UkxtNkJkNmxnZ0FNOVVjSFY2?=
 =?utf-8?B?bkFJVEdpN05FNm0vSVE5NFFGNjRjYXNsTCsrLzBxaHpmbzJ6WjVybWJ4Smxo?=
 =?utf-8?Q?6gQ1WEzF7WEn3ab9VVlidMMJH?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ed8f2f5-37cb-4f47-b0a0-08db95044b6c
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 16:03:08.2622
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kg3fFYqKjYdXAoEj5bbR33WM68GV5Os02KRMkmPh46wHoeVAj+z1a5ysJPodSoIjpyZGIYiXGc2vYcpUcJmbpA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4155
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,SPF_HELO_PASS,
        SPF_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/3/2023 7:25 PM, Yazen Ghannam wrote:
> On 7/6/2023 1:13 PM, Avadhut Naik wrote:
>> From: Avadhut Naik <Avadhut.Naik@amd.com>
>>
>> Add the necessary support in the module for AMD's new Family 1Ah-based
>> models 00h-1Fh and 40h-4Fh.
>>
> 
> The first patch in this set adds PCI IDs for models starting at 20h. And 
> this patch adds support for models 40h-4Fh.
> 
> Can you please elaborate on the discrepancy?
> 
> Thanks,
> Yazen
> 

Model 40h-4fh shares some of the same design as some other platforms.

The root port ID PCI_DEVICE_ID_AMD_19H_M60H_ROOT and DF_F3 ID 
PCI_DEVICE_ID_AMD_19H_M60H_DF_F3 covers it.