Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp253333rwb; Fri, 4 Aug 2023 12:07:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE1oJUq5kNxviy+MBcuQsQuXu8/hc+zNCUY95uDunpOVT5rq4S0tEGTBHe5mBK5m7Vz5e3h X-Received: by 2002:a17:90b:4b52:b0:268:323e:99a2 with SMTP id mi18-20020a17090b4b5200b00268323e99a2mr2252541pjb.4.1691176060741; Fri, 04 Aug 2023 12:07:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691176060; cv=none; d=google.com; s=arc-20160816; b=hOQiHy82Wmnvr3l+a+EO3jUfaxBUQFJxiHMzCa/Hf+La9OqWx78X7fIRwOT9JfMwhL QlJbGpAq0BHZg6qgkjeZSx3WIlowrnHQIID5C/KEWSArDGusVqP1nlnFSdoaBIuiwbqi 6RBYpnjTjDF6Cm9PUXV1zWpyTSmJUjXXDhl+0OupjdA72GPKZ2QJttMNTT0uBKSn1WtG YQLnBh8LC7DBwYo9vdihSMdpJKNx0BdvqNfcH4+RziKWZPhd6dnYq8Ggz8VJWbdFDUw6 rcOmOfWGcRL02hHkXGfx8B+7iS7fIZdOlH3eJl2iIAucQIvtYCP9uEagvskdzaCPyikv MNUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=0qQmF/aDPN/Nd1iFTYAKf0iaoJAfdocEV/pAQRYwbqs=; fh=g7zOYI+vdAnCj3JwPrZoCfLr1GEch5HgmxCgnUnkpuI=; b=wukdNp4FNnk/lTyAqoRVGCWUS1b+JRskFoiKjA4P+7fFWa+ckj2fI3b5yeT065mH40 +B3hsPaXIKu4DQXNah6kROJR7JFtnsfxVDabKIGbiWvDsriU7XC3odE/k8dSwjpj82QJ YH/psSGV+syAu/VJWPlnvFYdiguoBE1ozTdZEmqvvPVUzKcVdEN1adQtyX0L57B7rmtX AFwKabSb0wruVGa995L9mrAO40ubg2fTaR3LqEfwadrTKrfFNZsqw+04Pk2Jad/zWfgo 8qBtmcCo4Q5PdBS0cIwfYIzlP4yjBgCafBrTMYK5UUQGhtHZhCYR0cD90/Y2SS7+bOT7 SzIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=Ok9lyphi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t7-20020a6549c7000000b0055798b90375si2206159pgs.709.2023.08.04.12.07.21; Fri, 04 Aug 2023 12:07:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=Ok9lyphi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231142AbjHDRb7 (ORCPT + 99 others); Fri, 4 Aug 2023 13:31:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232144AbjHDRb6 (ORCPT ); Fri, 4 Aug 2023 13:31:58 -0400 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA7C749E5 for ; Fri, 4 Aug 2023 10:31:56 -0700 (PDT) Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1bba9539a23so4472175ad.1 for ; Fri, 04 Aug 2023 10:31:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1691170316; x=1691775116; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0qQmF/aDPN/Nd1iFTYAKf0iaoJAfdocEV/pAQRYwbqs=; b=Ok9lyphivxgObFBlVcatBdf9FmrWhag5FrhV0znfPx7b0uGvx81YG9TIoMjLRNS7b/ ts0mtR1Y9E0+QBeAk/a0+IlNVPt+PxsQChz4M88beydb3Mpsg7rhIdCllLO6JQb6IBTV Y4Ku4AtHVmGXtReS5HYAymdGGt4hwG6JyKtnjSbpeF7/eoxKNvLxy0f0PbDgukuFafYp zgiXrx2mpc+A684TIxjc2aQBX5g7EVb4AiL+aX8VXtRaB71gh5dh0d2MzDsHgoigdu9u vQd6ZSCf++eWeBf7rkJ/u0bayfu60/INm38m5w3FLO/qPHjtZRa54bcrOKhB9ga/smdb U+qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691170316; x=1691775116; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0qQmF/aDPN/Nd1iFTYAKf0iaoJAfdocEV/pAQRYwbqs=; b=Yf7iQwOdmeQ7Cvy0hhKAvsjoPeyYP3kribnS5z6jGibuY8JSKt7zLxZlx6pTWOJViH lTw00eXwEshi7y1sXMskbOtC4EeFnjaHSlUFtZJ3t7I988l5/2+kF2IqO2vtzoKO1xMQ 2bqZCVGQ7c0LJ7o3uJvolCeH1NR7LKU0wkMlhq+ILI49PXyWxhqihjuIXzV5Gp1c9k00 Vu6KAInS88mEoT7T0OeWzlsvhdMAvaDI3uMIrU2HEKbYPNaqVt2JV9+vPuplbKx4y1m7 nABiAhsa5LOYraDYSpYRTKhAStdQ3aLV4U0CXbwZOXsu51yErLofbLhxEsdVwXBqY7Eh SbyQ== X-Gm-Message-State: ABy/qLZBKSweqzjhQm93j1zKFIetznaYXuqyKZP8ctIa8IL3/U5KXOCJ 1geJQqfBBbN0SHIU/d4dqu2trA== X-Received: by 2002:a17:903:244f:b0:1b3:ec39:f42c with SMTP id l15-20020a170903244f00b001b3ec39f42cmr24213518pls.5.1691170316247; Fri, 04 Aug 2023 10:31:56 -0700 (PDT) Received: from [172.20.1.218] (071-095-160-189.biz.spectrum.com. [71.95.160.189]) by smtp.gmail.com with ESMTPSA id ju2-20020a170903428200b001bbcf43e120sm2024602plb.95.2023.08.04.10.31.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Aug 2023 10:31:54 -0700 (PDT) Message-ID: <32b8aef9-061a-bf4b-e3a4-c72a4ecbe27f@kernel.dk> Date: Fri, 4 Aug 2023 11:31:51 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH] romfs: only select BUFFER_HEAD for the block based path Content-Language: en-US To: Christoph Hellwig Cc: lizetao1@huawei.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig References: <20230804102648.78683-1-hch@infradead.org> From: Jens Axboe In-Reply-To: <20230804102648.78683-1-hch@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/4/23 4:26?AM, Christoph Hellwig wrote: > selecting BUFFER_HEAD unconditionally does not work as romfs can also > be built with only the MTD backend and thus without CONFIG_BLOCK. I folded this in with the other one and made a note about that. -- Jens Axboe