Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <caeddb66-6bac-3621-6a92-dbeca16261c3@wolfvision.net>
Date:   Fri, 4 Aug 2023 20:45:41 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [RFC PATCH 0/2] media: v4l2: map UVC_CT_ROLL_ABSOLUTE_CONTROL
Content-Language: en-US
To:     =?UTF-8?B?R2VyZ8WRIEvDtnRlbGVz?= <soyer@irl.hu>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1691096157.git.soyer@irl.hu>
From:   Michael Riesch <michael.riesch@wolfvision.net>
In-Reply-To: <cover.1691096157.git.soyer@irl.hu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3ZvVFpRdGtqVEhya25YOWJ5Q2tHcURWTnFSaWI3UDNkSWFIMkZSS1gwOGdY?=
 =?utf-8?B?RXMxdmdQSUcwZHhmOVRUcDFyUlgvMUk0QVc0eTRFRVdBQ1ZaQWhqNnNiRXBY?=
 =?utf-8?B?cVVnTzBHTWp3dDlTdUMwWGF4dFhoQ1ZHZWtTOHc1NnpJL2VwMkRaTEljaVgy?=
 =?utf-8?B?ZmlLWjlBNVNCY2VlYUNYRUthcFFvY0RNQi9CZnlYbVBHZWt1clhkZGFrVWFK?=
 =?utf-8?B?Nmw1cTFoK0tpYjJHajVsa3lsNmg2QkhwdEFjUVRLK3MrbXIwODZaWkE0THEx?=
 =?utf-8?B?Z2Y2QUdYM2pCb0xZR3dxS1lkUzJ3MVlSdXkyWTZsWm12UEVqbkhJYWFLa1NR?=
 =?utf-8?B?Q281Yk1UWnNCR3pvVGpFdlBGbGJUVWtBSUdmNU14ZEhsczJkWmhwREFNb0Y4?=
 =?utf-8?B?M2NCaFRhc04wbGp6blJDbDFkTnZJWTZBeXVLZHNPSXJGM21zNmFnTzhwTnZo?=
 =?utf-8?B?SFRZckttR3FWU05VRDVvSnVvZFNRSHhqcnZNWjRvejN5Z2UxcFd0UkxOSjg4?=
 =?utf-8?B?WDloNVJTVXdnOEpkWlY3c1VPODB0bkdaWFlreUF4T2FsdWdjdi9uZ0pkWjhY?=
 =?utf-8?B?MlJteVR1YitZSjhLR3N6SEphZEpDaWZZaE1GL2RQVG1kcUl6ZnpKT3Iyekc0?=
 =?utf-8?B?Zk9ncFFzVFEvR2NTdkozODl5S1YwYTZMa0xhSlFHbXEzQUwzT3dNZGNvSnRl?=
 =?utf-8?B?K3ViVEhGMkdTWGI1MmEyaWJUN05mdTVPanpnRlpjaDFFR29EZksvak9uNlBO?=
 =?utf-8?B?ZTVJV2F0Mnd5b2p0MmIwQThPL3dBR3dya0lEZmVZMGhRZk80WHVOS29xL3pZ?=
 =?utf-8?B?TDcxNjAyS01uOThnM1F6VFFqeTZ0Tm00Y1pPMzl6azhOaW9tTHdIOEs0emk2?=
 =?utf-8?B?Ujl6OEZhOGtpNmYxMk1uVTNWYWxJKzFidS8zNzBRWGIvUGl2Zm1FZnFrNGYz?=
 =?utf-8?B?V3RPK01xLzVncERKb010SkJKQVM0OEtnWmVxQVhPbVBBU0MwMjdEeGdraFhn?=
 =?utf-8?B?QnBjQ3VzNkJYN1JYY0pCanp6MnUrNi9pR2Z0RDJVcWlpYkR5bzhiaE9Gckhi?=
 =?utf-8?B?T09ZaGZoUmhHU2RLWjc5L0VrUHE5ejE2VDZwYXgxTk45SW8zTXk4eVlMQ0Nn?=
 =?utf-8?B?VWorWnpFYW56ZWN3UGdDcHFhRXErY2lNNGlPWUdBUXprcEttUFJKTG9UNEc0?=
 =?utf-8?B?QVZoZUZXV0xCNE5HMGVCRFdDNTE5dlVtUU1IQkhCUzUwdzF1TFVBV1FFcnM0?=
 =?utf-8?B?bVNlUTF3cXBwRmh1MVdZWnNRNVRiMEtKZmlCdmx5K0dEQUlKbllONjVaM3p3?=
 =?utf-8?B?NC9laEZ2eDdxbTBQODc4N0hCd2s0NXh5UExJYWlnd0s0WENrMzg0Z0o5NTQ3?=
 =?utf-8?B?NHRPUGxWZ2lRNVZpVG4ySVIrdytPbmNRMS9zWk5GQ0lwaGNzdzdLVzhrK1pS?=
 =?utf-8?B?cWlHdk9LWCszU0dMNGF0NWN4OENhUHFFS1dQODRCWkZvTC8zTWdxcmRBYVV4?=
 =?utf-8?B?Y0xzUWdqcWZ3ZFFKOTF5emI5cndBMlRXUWxTVmNEdmc1ZzV0MzQ5cXdPaUpC?=
 =?utf-8?B?T3ZoSWo1aXVaY294OWlmQ3JIaGRDSTkwK0ZIQldyaldrSlVIQnhFRmdyN3Jy?=
 =?utf-8?B?akNVVUVHS2NjWU1ScHpZdXZyM0UyaDVUcmFZU1ZnYVFjVU5IbWxvaElXUlY1?=
 =?utf-8?B?eVFxSGN3UzRNYzBKN25IVVQ4RE82Q2Q3Z2FNZU1qWHhKY2FXT3RBR0Q2V1lP?=
 =?utf-8?B?UzJVTVUzdDIyNlBTR054V1ZUbkl2NytHeW1EZS9QR1FONWw5ZHFoZk90aEoy?=
 =?utf-8?B?UUN2L3Y1bzg5TmdUSy9LdCsxWDhiZmhTa09tMmlqZjhNVm9ucXBMNjNlZzQr?=
 =?utf-8?B?SFFiVTU5UDQxR0dLSTNXV1F0OWVUTDBRaWpXaTJRblVUZVNhVlozK1VxRjdC?=
 =?utf-8?B?MEVtYkYxWU16VTJHL21lL0h5dk01a1ZPeDlDbE9hcS9FbUg2UXk5ZlJRUlYz?=
 =?utf-8?B?L3VZTUhBdkwzVEEzaVliamZ6R0xUV0IrWmpCZXBGeTRKUUMrSHFFcGx5WU40?=
 =?utf-8?B?cVkwU0hybFFrRnNiVi8zNm9DUmtvcTdWeU5uSU9QOGw0RGtDSjZyQnkyVGV0?=
 =?utf-8?B?Y3NrUGtkaHN4ME11VXFoR3F6SmVYZ25aclBKNENPZTZHVmtpaDA3NlVtdjNQ?=
 =?utf-8?B?a0JoYWdBUkYvazEvQmhvc3VUakFqYkRaN2ZBdHAwNHF5T1hzVENmZjNKYS9s?=
 =?utf-8?Q?FxcHoJojb5v6bcaxVbTilWJytzeZEun5WF8MEwX6xU=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: bbf2a5fe-7ab2-49f0-211d-08db951b01de
X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB9155.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 18:45:43.2896
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vreCLgL7dDglaP8HVUCxmcrSGtjPEfgG5q3fc29lF8iKetsXIAdWALhweRF9qmE82T0wpBwLvnhZfLKgbMZgbt3V2IJoClAz2SAJ/04OPsg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6086
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Gergő,

Interesting work! I would guess that there are a lot of cameras with an
accelerometer or gyroscope that could report the rotation.

On 8/3/23 23:28, Gergő Köteles wrote:
> Hi,
> 
> Logitech Streamcam can be mounted in 'portrait mode' as well.
> It reports the current roll (-90, 0, 90, 180) with
> UVC_CT_ROLL_ABSOLUTE_CONTROL.
> 
> This RFC defines V4L2_CID_ROLL_ABSOLUTE, and maps
> UVC_CT_ROLL_ABSOLUTE_CONTROL to make it available to
> userspace.
> Then, the userspace can rotate the stream based on the roll.

Should we also discuss pitch and yaw while we are at it?

As far as I know there are controls to set pan and tilt of a PTZ camera,
but there are no controls that report those angles.

> Is it better to use V4L2_CID_CAMERA_SENSOR_ROTATION for this?

IMHO that would make sense.

Best regards,
Michael

> The value set matches that control.
> If yes, is it worth mapping UVC_CT_ROLL_ABSOLUTE_CONTROL to
> V4L2_CID_CAMERA_SENSOR_ROTATION for this camera only?
> 
> Any feedback is greately appreciated.
> 
> 
> Gergő Köteles (2):
>   media: v4l2: ctrls: Add ROLL_ABSOLUTE control
>   media: v4l2: map UVC_CT_ROLL_ABSOLUTE_CONTROL
> 
>  .../userspace-api/media/v4l/ext-ctrls-camera.rst         | 5 +++++
>  drivers/media/usb/uvc/uvc_ctrl.c                         | 9 +++++++++
>  drivers/media/v4l2-core/v4l2-ctrls-defs.c                | 1 +
>  include/uapi/linux/v4l2-controls.h                       | 2 ++
>  4 files changed, 17 insertions(+)
> 
> 
> base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5