Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kees Cook <keescook@chromium.org>
To:     tony.luck@intel.com, gpiccoli@igalia.com, joel@joelfernandes.org,
        enlin.mu@unisoc.com, Yunlong Xing <yunlong.xing@unisoc.com>
Cc:     Kees Cook <keescook@chromium.org>, linux-hardening@vger.kernel.org,
        linux-kernel@vger.kernel.org, enlinmu@gmail.com,
        yunlong.xing23@gmail.com
Subject: Re: [PATCH 1/1] pstore/ram: Check member of buffers during the initialization phase of the pstore
Date:   Fri,  4 Aug 2023 10:04:14 -0700
Message-Id: <169116865197.3054577.11464864173886707392.b4-ty@chromium.org>
In-Reply-To: <20230801060432.1307717-1-yunlong.xing@unisoc.com>
References: <20230801060432.1307717-1-yunlong.xing@unisoc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Tue, 01 Aug 2023 14:04:32 +0800, Yunlong Xing wrote:
> The commit 30696378f68a("pstore/ram: Do not treat empty buffers as valid")
> would introduce the following issue:
> 
> When finding the buffer_size is zero, it would return directly.However, at
> the same time, if the buffer's start is a illegal value, the others would
> panic if access the buffer.
> 
> [...]

Applied to for-next/pstore, thanks!

[1/1] pstore/ram: Check member of buffers during the initialization phase of the pstore
      https://git.kernel.org/kees/c/fe8c3623ab06

Take care,

-- 
Kees Cook