Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2e163fb1-492e-8a1f-9df1-270c652e9799@intel.com>
Date:   Fri, 4 Aug 2023 11:07:14 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH net-next 0/3] virtchnl: fix fake 1-elem arrays
Content-Language: en-US
To:     Alexander Lobakin <aleksander.lobakin@intel.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Larysa Zaremba <larysa.zaremba@intel.com>,
        "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Kees Cook <keescook@chromium.org>, <netdev@vger.kernel.org>,
        <linux-hardening@vger.kernel.org>,
        <intel-wired-lan@lists.osuosl.org>, <linux-kernel@vger.kernel.org>
References: <20230728155207.10042-1-aleksander.lobakin@intel.com>
 <88dce445-180c-72d9-c7a5-f0a18a18c747@intel.com>
From:   Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <88dce445-180c-72d9-c7a5-f0a18a18c747@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M2t0RUlvM0lBRDhZZUFlV1hPenJpelhUTURLWFZjZ0ZpMWVTSy9ZTjRZRkcv?=
 =?utf-8?B?dDlFQ3JFTmo4enJWNGpLd0I1b0hVaENKZGQ0d2htVzE4NjhSb3BHU3FQbits?=
 =?utf-8?B?cE50SmVvd3JScnB6a1JTUUgxQkFWUXFZeUt0UTBqZWxyd0dYZ0lTZUlrNGFM?=
 =?utf-8?B?TEZkaERSZkRxeWtqVERTd2FEN3B5UkFTaDh5V0xqbC9xRG12UXdrSUxYZU9q?=
 =?utf-8?B?aEEweis3ZFZnay95ME9TOVBGVEF3Z3V0M2crRk5NUS9YcGtVZXYrV3FacVhk?=
 =?utf-8?B?bTQ1eWJvdDhIVkhwdXByTHU5Y2c5TWIwVU5KWG55K0NWK1ZxQnRpZzUyYmV4?=
 =?utf-8?B?ZElONE9uS1hRMmxVUGdudmkwcFZiS05nV3JRTGJkbDVYby8xbllJcW1XVjNC?=
 =?utf-8?B?T3NpeTRMVzdLVHhCR2dsbktLUDA1bTEzcy9abkU3Tkt3RGNWRFlUam9ZbjNB?=
 =?utf-8?B?RndKbEs3TUhYVThkd2QydVFrTC9nSzIvZkZWTEtmcnVuYWF0ZDdSRWltamgx?=
 =?utf-8?B?MlpZZW5rNXJLNG1mN240R0VocTFRUkt0ZVVta3A4QXhrS1BBNnpiMUdJUXVU?=
 =?utf-8?B?VjdHRDRSK2dwQVEvWmpKZTJRRDF0TFd6cTBHdXhyelJZd21DVHNwMFNvNDU0?=
 =?utf-8?B?ajFIYmtpM3pQa0V6akluVndvUUNCUG4wWmNlbFlERkc5TmZMTVgyWEo0RmE2?=
 =?utf-8?B?ZFI4Mm1ST3RxdlNYQzU2L3A5VVBFemdoVHo5TjBJU2xHOWRmU0FsNy9ieDFv?=
 =?utf-8?B?YTJlcXdmcXoyZHE0OUx1SUI2d3RmL3BieG5IVDJBSFpCdW9QSGhyMlI1QnAy?=
 =?utf-8?B?SUJSNkV3dFZxcjlBNkJlVUtnTUs1bFVHUU8vVWVVVkdPQ0hLckNqSFFrNGJ5?=
 =?utf-8?B?MG9xT0ptWnJBcEdVM3JHb25SbG1zVWR4aEUrdU4zYTc2RHpWeDZ1OVhSTFFr?=
 =?utf-8?B?UjRYcURKTUNuaDVoK0lXanZ2VTYxY3dCYlR2WVVwSW1OSkhLQXZiT05WQTRE?=
 =?utf-8?B?eFErWkhtNXY3cVN0cTVVbUZpdTRKdURPaTZUQkxwcFdDQnIvVkFyTTZHU21G?=
 =?utf-8?B?T2UxZmo3YTZ2OXkxUTM3TmVYVlhLQmdWZTlFRlU4bjZzMTEra3BIVTZKakpH?=
 =?utf-8?B?bUF3QklKSTBRR1VDdU5CSnNDUlV1eUhEQkpjREtHYy9MN2V4ODh0V2RudUxi?=
 =?utf-8?B?VGNxVEh3TjJkRm8rV3Y0bFY5Mmt6elEvNUYvNE1wSzN6ckdiU3p1c2pDa0Nm?=
 =?utf-8?B?ejNkMkU2aEU0OE9xTWJnUGtWLzJoMGdDTVJKMWlpM1J1NWI2YXAxbmRQa0JB?=
 =?utf-8?B?c2gydldhbS8rOVUzUkUyZXlIS01oK1cwUzljQ0VvWk9rS2hXeTJxeVVTQUN4?=
 =?utf-8?B?bzR1NzgwZW1DNTNHdHk3aXNqT2VBTVp2ODJqQ2phTEdiaURnd2hvOVJsR3Vh?=
 =?utf-8?B?c2ZtMkgyUERLSmRLMWJhWDk2MXAyTTF5Z2VjQnVJTkVleVNiZ2kvQ2Ywc3Zm?=
 =?utf-8?B?WWFZL25pRHVGZFU2TWErMUZCSnQwcURGU2FFR2VFdXpiSjZUekRLMXJTNWV5?=
 =?utf-8?B?QnZDVktiNk5tSTNJVmdsNTJMMFExMEFMS0RGUmdyOEZVSGFkQ3NMOFY1THZ4?=
 =?utf-8?B?b0pUZjhnVVZNL0UwT0d3OCtXbDFKbEdvK3JEUE5NODVBbGRIMWZsVEpobU8z?=
 =?utf-8?B?SUViQUdrckhlenZNWmN1OWtDNnUrcTcvLzRraFJGR3B0Q1BpRnJhOEhxK2Jq?=
 =?utf-8?B?REtKZ09YRmhjYUhyd1RTaVg5YjA0bk0vdDhEMkJZMGdCVGNJdW50VXpSeDhK?=
 =?utf-8?B?eGFHVmxvMVRlcC94bG40T2k3SmhpSTZ4M2FHRGV4VnREQmlrK2k0dWVyU1kr?=
 =?utf-8?B?NldUREdpYS9NNk5QVHluOURHS2dKT1kzL2JMdkZxblI4QytRZ3hQdzdzd1B6?=
 =?utf-8?B?UmxjMXZEQjNvTUloU2Y2SVVjaGRkbERDalQ4U05JZ056dGMySTd2ejJTcnpM?=
 =?utf-8?B?aEVKc05jeUpqWnhxVlRLQW40SWw0Q09ieFN1cGRvZzBVUWVGYkdQcmlheHFE?=
 =?utf-8?B?QzZDVUQ0R2Q5Ny82eW9EdlpFT1NhMjEvV3ZYb1ZZT091cE90S2FocUY4dXBN?=
 =?utf-8?B?dEFoVkNOQ3BleHpVa2dObmJQMnIvbm9DNG1lM1hhL3YyUUgyY2xod2drK3lh?=
 =?utf-8?B?Nmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1bf6e07b-fbb2-47e1-648d-08db9515a423
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3229.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 18:07:18.5349
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MJqM0mt9L9h1Kzga9bFa/Yae1ZoM6+1EVTmoRNbrcnwGBtU+az1etIKWqnjyqj84pk0JQP/cAJSEVDw5Ri7oQb+etgd9dlxfB6UFvkts4Hs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7678
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/4/2023 9:38 AM, Alexander Lobakin wrote:
> From: Alexander Lobakin <aleksander.lobakin@intel.com>
> Date: Fri, 28 Jul 2023 17:52:04 +0200
> 
>> 6.5-rc1 started spitting warning splats when composing virtchnl
>> messages, precisely on virtchnl_rss_key and virtchnl_lut:
>>
>> [   84.167709] memcpy: detected field-spanning write (size 52) of single
>> field "vrk->key" at drivers/net/ethernet/intel/iavf/iavf_virtchnl.c:1095
>> (size 1)
>> [   84.169915] WARNING: CPU: 3 PID: 11 at drivers/net/ethernet/intel/
>> iavf/iavf_virtchnl.c:1095 iavf_set_rss_key+0x123/0x140 [iavf]
> 
> [...]
> 
>>   .../ethernet/intel/i40e/i40e_virtchnl_pf.c    |   9 +-
>>   drivers/net/ethernet/intel/iavf/iavf.h        |   6 +-
>>   drivers/net/ethernet/intel/iavf/iavf_client.c |   4 +-
>>   drivers/net/ethernet/intel/iavf/iavf_client.h |   2 +-
>>   .../net/ethernet/intel/iavf/iavf_virtchnl.c   |  75 +++++------
>>   drivers/net/ethernet/intel/ice/ice_virtchnl.c |   2 +-
>>   include/linux/avf/virtchnl.h                  | 127 +++++++++++-------
>>   7 files changed, 124 insertions(+), 101 deletions(-)
>>
> 
> Tony, could you please take it via your next tree? I'd like the
> validation to make sure more different host <-> guest pairs work.
> 
> (with Kees' tags, assuming he reviewed and approved the whole series, I
>   asked about #2 already)
> 
> Thanks,
> Olek

Ok, will apply it today. For the future if you want it through IWL, can 
you tag it with the iwl-* target (and have IWL in the To)? Since this 
had 'net-next' and was 'To' netdev maintainers, I took it that you 
wanted it taken through netdev.

Thanks,
Tony