Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp344073rwb; Fri, 4 Aug 2023 13:46:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHQomeUv3bDGOb9zBoD6daypCL0yKS8lJDKxw0GB2D+0qHYFNd/38DSR7aAdM7/+mokS+95 X-Received: by 2002:a17:90b:4f45:b0:268:105b:ca1c with SMTP id pj5-20020a17090b4f4500b00268105bca1cmr2596923pjb.32.1691182009285; Fri, 04 Aug 2023 13:46:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691182009; cv=none; d=google.com; s=arc-20160816; b=wNQwP6bIk6mbu/v6/d5dCAOIMfAhpcCiGVgxnnajmn5U7YP7YTFamvJhFpcPMBjUkJ mQI9FhNUj6qfE7ollMi2PtU3Ij0drmeDa5v1P6X4YOwQSJLh8HLS2fM5j1ejAZaQ/ftv zq2Axl/tbwEjeIWOnyuqZ4PIOrmFUx4eVsrTyL10CSYhpguASxnjrd7metDfI2HbwD/8 gQN1wsrlwy6m9hs7kkQduF3fukO2Bjs98/4mC1tibjamr0ZRXQbo4SxkGiDzyBJUtNAR 7r+YRiDlK1j6YnY7JWLTints2rSfgxFgSxWN1DWR6trPP5m97qVmiQa/Hu2lQJiCxt3G RsDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=m/NvlNegVf2WCOswFyJP5KabwXIwKvotprr9kX+EqCs=; fh=hdmhi4x76LcVtpVk9L+EQqktIzFjtdVGrNzp8RieNwM=; b=Ecsaj8CtKJxnuyVd3OcNw4X2K6zYLQN3fiqdH82yhMUtWOinKf4WaouzcxIYl57H1/ RrpnKTz+h7RMAMcPXmtFZB3mm14UmSim+JTGDpgyLw7+Gp0chJkS8JU3NFkH/k0J49da g2PHOdxYL4G8mrZJ9ru2xe/3CE73+xQmzwyAnvRexFFGLHmZ2eLc7/6OlD2/yAsdLYPH 6nWKgNMel3xnu7hsJ0S0k+CXi8tIQL9uTI14cxMhoTvdUdKV6bCSJE1f+OCWhyXty+hv Afzp7Fs44/TAX7hRALs0qCDARyZX9gl0ENOr6RtgGIP8+y0136L5T1vCv+zlH9BQaiGy eWwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=Z0eePU9N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i24-20020a17090ad35800b00263638bb354si5495717pjx.93.2023.08.04.13.46.36; Fri, 04 Aug 2023 13:46:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=Z0eePU9N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229888AbjHDTOU (ORCPT + 99 others); Fri, 4 Aug 2023 15:14:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229488AbjHDTOT (ORCPT ); Fri, 4 Aug 2023 15:14:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D566CB9; Fri, 4 Aug 2023 12:14:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 735E562101; Fri, 4 Aug 2023 19:14:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18C65C433C8; Fri, 4 Aug 2023 19:14:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1691176457; bh=KjLfStABFwUIAtuSAKNcnmOi2LteNNPlPp20ShgMzp4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Z0eePU9NC4Pz6n6vXCNvjXjwlqXDzzzr5i3qU2pMQKHmkgb5AhlUyg9FUUtR84vnj Zhk+jFYTAa/8XPVFoOiFEMxePF2hfUOKoJRQWf4aPeUTeLUzOv9oQhLUykgZa02sUW i8K5cksG4rlxLiAtQeTF7k4fI/GPmi0vCP1n8tWY= Date: Fri, 4 Aug 2023 12:14:16 -0700 From: Andrew Morton To: Suren Baghdasaryan Cc: torvalds@linux-foundation.org, jannh@google.com, willy@infradead.org, liam.howlett@oracle.com, david@redhat.com, peterx@redhat.com, ldufour@linux.ibm.com, vbabka@suse.cz, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, hannes@cmpxchg.org, dave@stgolabs.net, hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org, kernel-team@android.com, Linus Torvalds Subject: Re: [PATCH v4 1/6] mm: enable page walking API to lock vmas during the walk Message-Id: <20230804121416.533bb81336ded8f170da097e@linux-foundation.org> In-Reply-To: <20230804152724.3090321-2-surenb@google.com> References: <20230804152724.3090321-1-surenb@google.com> <20230804152724.3090321-2-surenb@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 4 Aug 2023 08:27:19 -0700 Suren Baghdasaryan wrote: > walk_page_range() and friends often operate under write-locked mmap_lock. > With introduction of vma locks, the vmas have to be locked as well > during such walks to prevent concurrent page faults in these areas. > Add an additional member to mm_walk_ops to indicate locking requirements > for the walk. > > ... > > 18 files changed, 100 insertions(+), 20 deletions(-) > That's a big patch for a -stable backport. Presumably the various -stable maintainers will be wondering why we're doing this. But, as is so often the case, the changelog fails to describe any user-visible effects of the change. Please send this info and I'll add it to the changelog.