Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <68d6d4a4-80e4-2aa5-409f-0e2744c20e88@intel.com>
Date:   Fri, 4 Aug 2023 13:42:49 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH v6 7/8] x86/resctrl: Introduce "-o debug" mount option
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <168980872063.1619861.420806535295905172.stgit@bmoger-ubuntu>
 <168980893967.1619861.7249871216790436466.stgit@bmoger-ubuntu>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <168980893967.1619861.7249871216790436466.stgit@bmoger-ubuntu>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?emdmQzlQRE5qT2laSVIwNWJJUmd1M1FNSjdwQVREbjNuTkdNMXYyczgrdnhw?=
 =?utf-8?B?NmFCZ0UvT0xCVmg2c1dmRTdFcE9TMFBtWm52S3NHQWU0UFJkMGJjVlVscVpP?=
 =?utf-8?B?emhJTVlJYVBrOUxuR1B2allHaHpBUVRVZFFIV0tuQkY1bDkrVkN4aVRPNHdy?=
 =?utf-8?B?cnZZL1N0bXpXZEp5dDhhd2tCMGFwRjlrVXBYemdiTGZJbVF6YzNSSnNnWjJD?=
 =?utf-8?B?WDh3VnZ0V0NWMGc3YmZVanBIQnN1RElVUlRCMkhIVGY2dEJYbzZnWk5ZMGw3?=
 =?utf-8?B?c3prU1JqUlgyS01UYUlNMW9mWFQ3Wi9LSzlvWDNJeVJNNEZUSnF6UStFRFZn?=
 =?utf-8?B?M3RZVUZKNjVxZUwzTFJJaTBDZGFtQ2hKT2pNZHhZSU1SZHVkNjdwaXBSN1lP?=
 =?utf-8?B?NU9VWVo2VnFpVjI4Tk5MMjVYaXZXb0JpUDZkTHpkcnd2VDZ2eHVTTlZRZVF3?=
 =?utf-8?B?Q2UzRUFGbTIwWmsxUytDT3ZzVlpDMm1xVSt6QTJqOFYyNWY5ZTFFdTRTd28v?=
 =?utf-8?B?T0NsRXR5TGxTbDJldzVFV040T0ZCS1VUOTdaZnh3VTJDOVQ0amx4aTBFUDZp?=
 =?utf-8?B?c05KOTZNaXdyZ2g1YSt0UC9TVmJnTFlIcTFlOUlBV1V5TjU5Qm55WWc3NjFp?=
 =?utf-8?B?eW5ndVpyYnR5eXZ1dE5OQ3grand4YjJHdjBvNzVMem5admJCSy83QXF4R0pa?=
 =?utf-8?B?dDFSTUp1Q2l4dndIRFg3T0ZSSEhJeUs0QVN5QStHUEZVNUdzeFhwOXZVSXVS?=
 =?utf-8?B?WHNMNVk2SnFxMTFLOWY4VDF1aThDS1lBRVg2YTM1ZENtQ1plY1BpRmt1WmRT?=
 =?utf-8?B?UjNaNk9CK2w4WWY1ajBWTFNWcmJCejFDcmo0NVlSV0VreFFXbDBoS1F3ay9M?=
 =?utf-8?B?Y2c0NTZOeU9WT3hHczlkc3Q0N0xBd3FYMEZmVWk1T0N5QWo1cVR4SFhHUVAz?=
 =?utf-8?B?UGs2SEhuNC91czJMYSs0ZWRoNnVBNUI1WkFZcklUdHhkRnpuc1JHa2tjTmxR?=
 =?utf-8?B?UTBuYngrdGE1Q0NSRHI0bE5oK2pMaWRteUhPekRZZ1dEcFZjTnZKQldoTU1C?=
 =?utf-8?B?VEpLNElmcmg0TFFMS3gxVC9jT3pYMHFkbjVvZnd3NkVQcWNqbHVLa1lQWnVL?=
 =?utf-8?B?Tk5oZDZVTnFWeEk5MU5ja1dFWXRvNTBXNzFPc2tiVS9oQVJRTG9Wc2V5M2Fa?=
 =?utf-8?B?cGlWSmJLQ2lvUThCMTZrWUFrSjI3anZ0SUNzVjNwL1Z5T00vWFgvYWRBdHE5?=
 =?utf-8?B?Qmx0WjZPQlNqaVJqZ0thbjczbVl5YjF4am9BTmdXQk9lYkhVV2JHcWgyL0dp?=
 =?utf-8?B?aTZ4UlJvdWNjWm5UdGlJV202TDdkMUdqcWord1M1N3BaMUZkUUtHSjRHakFq?=
 =?utf-8?B?NVRCNWpWaldFaVorR0JjMUVmUjBjWktmVFM2bXYwN0tTNWRBdE9PNEdKS1Yx?=
 =?utf-8?B?eGhTMTl0MWNmSUZxd2NRc0JzVkJ1bG41M3ZpSGMvS0RmbEkvY3RGYmEyenRh?=
 =?utf-8?B?bWRVSVR5L2hnTjJmdmdBZEk4YjgxeWo2WHRyeTJBT3pKb0pPalI4VzdwNnVY?=
 =?utf-8?B?eDY0eVNOVmdrSHRxUlp0Qmkva1FEMjJmM2VaK0Z3WGs2dklzRjJ5RXFiU1NN?=
 =?utf-8?B?WTN3QlluYk1va08vRzRnK1Ardy9ncGsweDc5S2FLT0M5cmlpSXpramJMOWh3?=
 =?utf-8?B?UHh6UGVmMGFDWWthMzhOaEo1RWtRQWVOWk5wZUVwSkgxd1RISWNVdzhNQnJR?=
 =?utf-8?B?YXRLU2xrbURxdUwxV01GSkNPUGR3MnUxbkR4V01YNzBPQzRVYmRQWHlLbUIz?=
 =?utf-8?B?WklkbXFQS0dpYkd0NHpLR0lPVllQOEl2OXpkdlB3eDdoU1lNWDVUMmE0MHps?=
 =?utf-8?B?elo5TFRXU0h6N3NRTm52SVExUDNHSnNtbkRIbGlzVHROV0Fkc2hTYWF5dEhO?=
 =?utf-8?B?QlEzS2ltaWlpTSsvSTFIUS9hZGpzcU5mVFJES042bWpRUnlLaUJmemsweGx0?=
 =?utf-8?B?WVloRkJkU1lJbUQ4K294a05wbzRHSjNlL1lkNmQyN3NpUWRkT1F0TDZQMGtz?=
 =?utf-8?B?a1V3ZHhaRG1ZcGRHbHFxT1Fwd2pKK0pjVElPQWNzMUFyYzNvL1VWbWtZQUZY?=
 =?utf-8?B?MVBjZ1FTeSt5Q3ZDc3JxN091cytaWE9zMk5GUS9PK2hvVmJOcnFLR1puS0FD?=
 =?utf-8?B?Q0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c5b1ca22-3474-4c8f-ca1b-08db952b5f8a
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 20:42:52.3838
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C2KlPA26Hy9/3ysOZXXMSqLD+OanWHe6SpVYh+Ns521A+mO2IGYsrDT3E3Vbge3F9dNmTTRJlnYPDwDTUc98oP9S8TVjVrl4Z5KDaappuHg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5077
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

On 7/19/2023 4:22 PM, Babu Moger wrote:
> @@ -2591,6 +2599,8 @@ static int rdt_get_tree(struct fs_context *fc)
>  out_schemata_free:
>  	schemata_list_destroy();
>  out_ctx:
> +	if (ctx->enable_debug)
> +		resctrl_debug = false;
>  	if (ctx->enable_mba_mbps)
>  		set_mba_sc(false);
>  	cdp_disable_all();

These changes are a red flag to me. Developers still need to
do what patch #4 was aiming to prevent.

Reinette